You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by reudismam <gi...@git.apache.org> on 2018/02/01 17:33:10 UTC
[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/56
Use equals method of a string literal to prevent NPE and isEmpty() me…
…thod instead of comparing a String object with an empty string.
This change has already been done for some locations in the commit:
https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2d
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reudismam/ant equals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit debf404d170cfd771a517e9c5b408bc9735e2f70
Author: reudismam <re...@...>
Date: 2018-02-01T17:03:19Z
Use equals method of a string literal to prevent NPE and isEmpty() method instead of comparing a String object with an empty string.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/56
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/30/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/56
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/56
this is ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/56
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/36/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/56
many thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/56
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org