You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2025/06/21 03:56:46 UTC
[I] Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` [datafusion]
2010YOUY01 opened a new issue, #16493:
URL: https://github.com/apache/datafusion/issues/16493
### Is your feature request related to a problem or challenge?
`BaselineMetrics` provides a common set of metrics that should be included by all operators. This way we can keep those basic metrics consistent and also simplify implementation when adding more metrics into `BaselineMetrics`
https://github.com/apache/datafusion/blob/a4f4b17f0461b94f220b024ba502c8664f590b9b/datafusion/physical-plan/src/metrics/baseline.rs#L47-L56
However, @hendrikmakait noticed in https://github.com/apache/datafusion/issues/16244#issuecomment-2991828951 that, some operators are not using `BaselineMetrics`, and instead include the same basic metrics into their specific metrics struct.
Specifically, SMJ operator keeps the same `output_rows` metrics but it's missing other baseline metircs.
https://github.com/apache/datafusion/blob/a4f4b17f0461b94f220b024ba502c8664f590b9b/datafusion/physical-plan/src/joins/sort_merge_join.rs#L603-L619
I think it's a good idea to clean it up by reusing `BaselineMetrics`.
### Describe the solution you'd like
Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics`
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #16493: Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics`
URL: https://github.com/apache/datafusion/issues/16493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` [datafusion]
Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man commented on issue #16493:
URL: https://github.com/apache/datafusion/issues/16493#issuecomment-3034026090
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` [datafusion]
Posted by "xytuang (via GitHub)" <gi...@apache.org>.
xytuang commented on issue #16493:
URL: https://github.com/apache/datafusion/issues/16493#issuecomment-2993610068
Hey, can I work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Refactor `SortMergeJoinMetrics` to reuse `BaselineMetrics` [datafusion]
Posted by "xytuang (via GitHub)" <gi...@apache.org>.
xytuang commented on issue #16493:
URL: https://github.com/apache/datafusion/issues/16493#issuecomment-2993610980
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org