You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/22 02:02:43 UTC
[GitHub] [spark] ulysses-you opened a new pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
ulysses-you opened a new pull request #34065:
URL: https://github.com/apache/spark/pull/34065
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Change `nonEquiCond` to all join condition at `JoinSelection.ExtractEquiJoinKeys` pattern.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
At `JoinSelection`, with `ExtractEquiJoinKeys`, we use `nonEquiCond` as the join condition. It's wrong since there should exist some equi condition.
```
Seq(joins.BroadcastNestedLoopJoinExec(
planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
```
But it's should not be a bug, since we always use the smj as the default join strategy for ExtractEquiJoinKeys.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
it's not a bug for now, but we should fix it in case we use this code path in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713663540
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
yes, smj only works with orderable key, but we have checked `orderable` at analyzer side(at `BinaryComparison.checkInputDataTypes`). If we go in the equi-join that means the key is orderable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924521275
**[Test build #143495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143495/testReport)** for PR 34065 at commit [`1f1d8ff`](https://github.com/apache/spark/commit/1f1d8ff73eee0b8d642038a6a56c61a104f41894).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924633437
**[Test build #143495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143495/testReport)** for PR 34065 at commit [`1f1d8ff`](https://github.com/apache/spark/commit/1f1d8ff73eee0b8d642038a6a56c61a104f41894).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924537551
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48006/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713670714
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
Oh okay, so basically we cannot reach here if it is a equi-join with non-orderable keys. And by no means it runs into `createJoinWithoutHint` for equi-join for now.
This is only for preventing possible bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924643433
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924552914
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48006/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34065:
URL: https://github.com/apache/spark/pull/34065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924552923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48006/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924552923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48006/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713651275
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
Isn't smj only for orderable joining keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713637819
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
I read the JIRA description. If the join condition is wrong, isn't this a bug? Even it is not default join strategy, we still possibly hit this path, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713637819
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
I read the JIRA description. If the join condition is wrong, isn't this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713639032
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType, nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType, j.condition))
Review comment:
We would never go to this code path. For equi-join we always use smj by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924521275
**[Test build #143495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143495/testReport)** for PR 34065 at commit [`1f1d8ff`](https://github.com/apache/spark/commit/1f1d8ff73eee0b8d642038a6a56c61a104f41894).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924633400
cc @cloud-fan @viirya @yaooqinn @maryannxue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924746895
The GA failure is unrelated. Thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924643433
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #34065: [SPARK-36822][SQL] BroadcastNestedLoopJoinExec should use all condition instead of non-equi condition
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #34065:
URL: https://github.com/apache/spark/pull/34065#issuecomment-924746895
The GA failure is unrelated. Thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org