[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j

["Kellen Sunderland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283166#comment-15283166 ] 

Kellen Sunderland commented on JOSHUA-262:
------------------------------------------

There's two immediate benefits here:  First to create a loose coupling to concrete logging systems, such that organizations can plug in whatever loggers they want at runtime.

There's also a surprisingly large performance consideration that can be addressed here as well.  There's a few cases where a ton of the cpu work is actually to build strings that don't get logged at the logging levels we're running under.  Lazy evaluation of these strings should prevent this issue.

> Implement all logging as Slf4j over Log4j
> -----------------------------------------
>
>                 Key: JOSHUA-262
>                 URL: https://issues.apache.org/jira/browse/JOSHUA-262
>             Project: Joshua
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 6.0.5
>            Reporter: Lewis John McGibbney
>             Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If we use [parameterized logging notation|http://www.slf4j.org/faq.html#logging_performance] we can have good logging in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)