[jira] [Commented] (STORM-969) HDFS Bolt can end up in an unrecoverable state

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725630#comment-14725630 ] 

ASF GitHub Bot commented on STORM-969:
--------------------------------------

Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/664#issuecomment-136775368
  
    +1 overall the patch looks good once the [comment] (https://github.com/apache/storm/pull/664#commitcomment-13003095) is addressed


> HDFS Bolt can end up in an unrecoverable state
> ----------------------------------------------
>
>                 Key: STORM-969
>                 URL: https://issues.apache.org/jira/browse/STORM-969
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-hdfs
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>
> The body of the HDFSBolt.execute() method is essentially one try-catch block.  The catch block reports the error and fails the current tuple.  In some cases the bolt's FSDataOutputStream object (named 'out') is in an unrecoverable state and no subsequent calls to execute() can succeed.
> To produce this scenario:
> - process some tuples through HDFS bolt
> - put the underlying HDFS system into safemode
> - process some more tuples and receive a correct ClosedChannelException
> - take the underlying HDFS system out of safemode
> - subsequent tuples continue to fail with the same exception
> The three fundamental operations that execute takes (writing, sync'ing, rotating) need to be isolated so that errors from each are specifically handled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)