You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Kostas Kloudas (Jira)" <ji...@apache.org> on 2019/12/14 12:44:00 UTC

[jira] [Closed] (FLINK-15179) Kubernetes should not have a CustomCommandLine.

     [ https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kostas Kloudas closed FLINK-15179.
----------------------------------
    Resolution: Fixed

Merged on master with bc8964c4b01424df6529242053820b89775975e4
and on 1.10 with a0f1def4f8ebecd4b5c677766571d7fa9bd2415b

> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
>                 Key: FLINK-15179
>                 URL: https://issues.apache.org/jira/browse/FLINK-15179
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.10.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options. Given this 1-to-1 mapping, the Kubernetes command line could simply forward the command line arguments to ConfigOptions directly, instead of introducing new command line options. In this case, the user is expected to simply write:
>  
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D kubernetes.container.image=MY_IMAGE ...}} 
> and the CLI will parse the -e to figure out the correct {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the config options specified with {{-D}}. 
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply forward the specified parameters to the executors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)