You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:22:59 UTC
[GitHub] [geode] yozaner1324 opened a new pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
yozaner1324 opened a new pull request #5234:
URL: https://github.com/apache/geode/pull/5234
JBossModuleServiceImpl can now register and load Modules using ModuleDescriptor. The ModuleDescriptor
can now contain source paths to be included in the module as code sources or
have dependencies on other modules.
The same functionality can now be represented/retrieved from the Manifest file
contained within the jar files.
Amended gradle scripts for geode-common-services and geode-common to now generate
manifest files containing "Class-Path" dependencies and project module dependencies
described in the "Dependent-Modules" attribute in the manifest file.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5234:
URL: https://github.com/apache/geode/pull/5234#issuecomment-642153152
This pull request **introduces 2 alerts** and **fixes 1** when merging f0574afef7bc2bab8f1dff503ad5ac78f9f13966 into 923735772bc7d46b84fe430170be875f43713a48 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-7d0610b25102869e8fb68e93ebdfb8779a07b4f0)
**new alerts:**
* 2 for Potential input resource leak
**fixed alerts:**
* 1 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #5234:
URL: https://github.com/apache/geode/pull/5234#discussion_r438264180
##########
File path: gradle/java.gradle
##########
@@ -74,9 +74,9 @@ gradle.taskGraph.whenReady({ graph ->
}
jar.metaInf {
from("$rootDir/geode-assembly/src/main/dist/LICENSE")
- if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
- from("$rootDir/NOTICE")
- }
+// if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
+// from("$rootDir/NOTICE")
+// }
Review comment:
Any idea why these lines were commented out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] yozaner1324 commented on a change in pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
yozaner1324 commented on a change in pull request #5234:
URL: https://github.com/apache/geode/pull/5234#discussion_r438314213
##########
File path: gradle/java.gradle
##########
@@ -74,9 +74,9 @@ gradle.taskGraph.whenReady({ graph ->
}
jar.metaInf {
from("$rootDir/geode-assembly/src/main/dist/LICENSE")
- if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
- from("$rootDir/NOTICE")
- }
+// if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
+// from("$rootDir/NOTICE")
+// }
Review comment:
Nope, not sure where this change came from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal merged pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal merged pull request #5234:
URL: https://github.com/apache/geode/pull/5234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5234:
URL: https://github.com/apache/geode/pull/5234#issuecomment-642251305
This pull request **introduces 2 alerts** and **fixes 1** when merging af021bc39d24556d42a72769c3efb8f73e0e8d95 into 923735772bc7d46b84fe430170be875f43713a48 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-dd4c7a5d95ac7cebf90faf85a7bbf644a1b7f3e1)
**new alerts:**
* 2 for Potential input resource leak
**fixed alerts:**
* 1 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5234:
URL: https://github.com/apache/geode/pull/5234#issuecomment-642321035
This pull request **introduces 2 alerts** and **fixes 1** when merging 6c8e4a33efc066358597b77f4dbce3e3c04dcfdc into 923735772bc7d46b84fe430170be875f43713a48 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-a054db37385626719a0ed1daa7fdb9e8b497f055)
**new alerts:**
* 2 for Potential input resource leak
**fixed alerts:**
* 1 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org