You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/01/10 09:43:38 UTC
[PR] [MINOR][DOCS] Add new dataframe methods to API references [spark]
zhengruifeng opened a new pull request, #49439:
URL: https://github.com/apache/spark/pull/49439
### What changes were proposed in this pull request?
Add new dataframe methods to API references
### Why are the changes needed?
these new methods are missing in docs
### Does this PR introduce _any_ user-facing change?
yes, docs-only changes
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Add new dataframe methods to API references [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #49439:
URL: https://github.com/apache/spark/pull/49439#issuecomment-2582512828
thanks @MaxGekk
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Add new dataframe methods to API references [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #49439:
URL: https://github.com/apache/spark/pull/49439#issuecomment-2583586563
Late LGTM.
@zhengruifeng Thanks for fixing it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Add new dataframe methods to API references [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #49439:
URL: https://github.com/apache/spark/pull/49439#discussion_r1910097626
##########
python/pyspark/sql/dataframe.py:
##########
@@ -6609,10 +6609,10 @@ def asTable(self) -> TableArg:
After obtaining a TableArg from a DataFrame using this method, you can specify partitioning
and ordering for the table argument by calling methods such as `partitionBy`, `orderBy`, and
`withSinglePartition` on the `TableArg` instance.
- - partitionBy(*cols): Partitions the data based on the specified columns. This method cannot
Review Comment:
need such changes, otherwise doc build failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Add new dataframe methods to API references [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #49439: [MINOR][DOCS] Add new dataframe methods to API references
URL: https://github.com/apache/spark/pull/49439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org