You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/23 22:37:00 UTC
[jira] [Commented] (FLINK-10656) Refactor
org.apache.flink.runtime.io.network.api.reader.ReaderBase
[ https://issues.apache.org/jira/browse/FLINK-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661403#comment-16661403 ]
ASF GitHub Bot commented on FLINK-10656:
----------------------------------------
isunjin opened a new pull request #6911: [FLINK-10656] Refactor org.apache.flink.runtime.io.network.api.reader…
URL: https://github.com/apache/flink/pull/6911
## What is the purpose of the change
The interface of ```org.apache.flink.runtime.io.network.api.reader.ReaderBase``` is not very clean, the API in it are called only by iteration and handle event. which is not related the name ```ReaderBase```. And the functionality is independent, so propose to change the name and split the interface to two isolated interface.
## Brief change log
- *Split interface ```ReaderBase``` to ```IterationReader``` and ```TaskEventSender```*
- *rename ```getCurrentBuffer``` to ```resetCurrentBuffer```*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Refactor org.apache.flink.runtime.io.network.api.reader.ReaderBase
> ------------------------------------------------------------------
>
> Key: FLINK-10656
> URL: https://issues.apache.org/jira/browse/FLINK-10656
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Reporter: JIN SUN
> Assignee: JIN SUN
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> The interface of org.apache.flink.runtime.io.network.api.reader.ReaderBase is not very clean, the API in it are called only by iteration and handle event. which is not related the name ReaderBase. And the functionality is independent, so propose to change the name and split the interface to two isolated interface.
> More details please look at the PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)