You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/16 22:03:12 UTC
[GitHub] [spark] seanli-rallyhealth commented on a change in pull request
#26911: [WIP][SPARK-30272][SQL][CORE] Remove usage of Guava that breaks in
27; replace with workalikes
seanli-rallyhealth commented on a change in pull request #26911: [WIP][SPARK-30272][SQL][CORE] Remove usage of Guava that breaks in 27; replace with workalikes
URL: https://github.com/apache/spark/pull/26911#discussion_r358489660
##########
File path: common/kvstore/src/test/java/org/apache/spark/util/kvstore/CustomType1.java
##########
@@ -52,12 +50,7 @@ public int hashCode() {
@Override
public String toString() {
- return Objects.toStringHelper(this)
- .add("key", key)
- .add("id", id)
- .add("name", name)
- .add("num", num)
- .toString();
+ return "CustomType1[key=" + key + ",id=" + id + ",name=" + name + ",num=" + num;
Review comment:
why not use String Interpolation, e.g. s"CustomType1[key=$key, id=$id, name=$name, num=$num]"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org