You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/03 09:11:38 UTC
[GitHub] [spark] panbingkun opened a new pull request, #37062: [MINOR][SQL][TESTS] remove unused super class & unused variable in JDBCXXXSuite
panbingkun opened a new pull request, #37062:
URL: https://github.com/apache/spark/pull/37062
### What changes were proposed in this pull request?
Remove unused super class "" & "" in
Remove unused variable "conn" in
### Why are the changes needed?
Eliminate redundant information and make the code cleaner
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37062: [MINOR][SQL][TESTS] Remove unused super class & unused variable in JDBCXXXSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37062:
URL: https://github.com/apache/spark/pull/37062#issuecomment-1173664270
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #37062: [MINOR][SQL][TESTS] Remove unused super class & unused variable in JDBCXXXSuite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #37062:
URL: https://github.com/apache/spark/pull/37062#issuecomment-1173954426
Merged to master. Thanks @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #37062: [MINOR][SQL][TESTS] Remove unused super class & unused variable in JDBCXXXSuite
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #37062: [MINOR][SQL][TESTS] Remove unused super class & unused variable in JDBCXXXSuite
URL: https://github.com/apache/spark/pull/37062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a diff in pull request #37062: [MINOR][SQL][TESTS] remove unused super class & unused variable in JDBCXXXSuite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #37062:
URL: https://github.com/apache/spark/pull/37062#discussion_r912506901
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -44,7 +44,6 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
val tempDir = Utils.createTempDir()
val url = s"jdbc:h2:${tempDir.getCanonicalPath};user=testUser;password=testPass"
- var conn: java.sql.Connection = null
Review Comment:
There is `var conn` defined in `JDBCTableCatalogSuite` too. Could you please remove that one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #37062: [MINOR][SQL][TESTS] Remove unused super class & unused variable in JDBCXXXSuite
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #37062:
URL: https://github.com/apache/spark/pull/37062#discussion_r912574445
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -44,7 +44,6 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
val tempDir = Utils.createTempDir()
val url = s"jdbc:h2:${tempDir.getCanonicalPath};user=testUser;password=testPass"
- var conn: java.sql.Connection = null
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org