[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

[hhbyyh <gi...@git.apache.org>]

Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12106#discussion_r58478599
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
    @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
           }
           Iterator((stat, gammaPart))
         }
    -    val statsSum: BDM[Double] = stats.map(_._1).reduce(_ += _)
    --- End diff --
    
    I'm thinking `.treeReduce(_ + _)` is fine here. Internally it will transform it into treeAggregate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org