You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by ant elder <an...@gmail.com> on 2007/08/10 10:04:44 UTC

Re: svn commit: r564429 - in /incubator/tuscany/java/sca: modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/ modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/ modules/binding-notification/src/main/java

How about instead of extension having to do "new
ExtensibleServletHost(servletHosts)" that code is moved into the
ExtensionUtils DiscoveryUtils class as a special case so that extensions can
still just use the simple constructor taking a ServletHost and
ExtensionHelper creates the ExtensibleServletHost for them?

Unrelated to that but i was reminded while seeing the code again - how about
adding a getServlet method to the ServletHost interface so things like
jsonrpc and ajax bindings don't have to mess about doing
removeServletMapping/addServletMapping to get the servlet?

   ...ant

On 8/10/07, jsdelfino@apache.org <js...@apache.org> wrote:
>
> Author: jsdelfino
> Date: Thu Aug  9 16:49:11 2007
> New Revision: 564429
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=564429
> Log:
> More changes to dynamically load extension points and help with footprint.
>
> Added:
>
>     incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
>       - copied, changed from r564365,
> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
> (with props)
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
> (with props)
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
> (with props)
>
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
>       - copied, changed from r564365,
> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
> Removed:
>
>     incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/module/
>
>     incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/module/
>
>     incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/DefaultJavaClassIntrospectorExtensionPoint.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/ExtensibleJavaClassIntrospector.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/JavaClassIntrospector.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/JavaClassIntrospectorExtensionPoint.java
> Modified:
>
>     incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
>
>     incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
>
>     incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
>
>     incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
>
>     incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
>
>     incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
>
>     incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
>
>     incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
>
>     incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
>
>     incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
>
>     incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
>
>     incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
>
>     incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
>
>     incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
>
>     incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
>
>     incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
>
>     incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
>
>     incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
>
>     incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
>
>     incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
>
> Modified:
> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -20,7 +20,9 @@
> package org.apache.tuscany.sca.binding.ajax;
>
> import org.apache.tuscany.sca.assembly.Binding;
> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
> import org.apache.tuscany.sca.http.ServletHost;
> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
> import org.apache.tuscany.sca.runtime.RuntimeComponent;
> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
> @@ -32,8 +34,8 @@
>
>      private ServletHost servletHost;
>
> -    public AjaxBindingActivator(ServletHost servletHost) {
> -        this.servletHost = servletHost;
> +    public AjaxBindingActivator(ServletHostExtensionPoint servletHosts) {
> +        this.servletHost = new ExtensibleServletHost(servletHosts);
>      }
>
>      public Class<AjaxBinding> getBindingClass() {
>
> Modified:
> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -20,7 +20,9 @@
> package org.apache.tuscany.sca.binding.jsonrpc;
>
> import org.apache.tuscany.sca.assembly.Binding;
> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
> import org.apache.tuscany.sca.http.ServletHost;
> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
> import org.apache.tuscany.sca.runtime.RuntimeComponent;
> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
> @@ -33,8 +35,8 @@
>
>      protected ServletHost servletHost;
>
> -    public JSONRPCBindingActivator(ServletHost servletHost) {
> -        this.servletHost = servletHost;
> +    public JSONRPCBindingActivator(ServletHostExtensionPoint
> servletHosts) {
> +        this.servletHost = new ExtensibleServletHost(servletHosts);
>      }
>
>      public Class<JSONRPCBinding> getBindingClass() {
>
> Modified:
> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -53,7 +53,9 @@
> import
> org.apache.tuscany.sca.contribution.processor.StAXArtifactProcessorExtensionPoint
> ;
> import org.apache.tuscany.sca.core.ExtensionPointRegistry;
> import org.apache.tuscany.sca.core.ModuleActivator;
> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
> import org.apache.tuscany.sca.http.ServletHost;
> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
> import org.apache.tuscany.sca.policy.PolicyFactory;
> import org.apache.tuscany.sca.provider.ProviderFactoryExtensionPoint;
> @@ -157,7 +159,7 @@
>              httpPort = DEFAULT_PORT;
>          }
>
> -        ServletHost servletHost = registry.getExtensionPoint(
> ServletHost.class);
> +        ServletHost servletHost = new ExtensibleServletHost(
> registry.getExtensionPoint(ServletHostExtensionPoint.class));
>
>          ntm = new NotificationTypeManagerImpl();
>          ntm.setServletHost(servletHost);
> @@ -220,7 +222,4 @@
>          processors.removeArtifactProcessor(bindingProcessor);
>      }
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -20,7 +20,9 @@
> package org.apache.tuscany.sca.binding.rmi;
>
> import org.apache.tuscany.sca.assembly.Binding;
> +import org.apache.tuscany.sca.rmi.ExtensibleRMIHost;
> import org.apache.tuscany.sca.rmi.RMIHost;
> +import org.apache.tuscany.sca.rmi.RMIHostExtensionPoint;
> import org.apache.tuscany.sca.runtime.RuntimeComponent;
> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
> @@ -32,8 +34,8 @@
>
>      private RMIHost rmiHost;
>
> -    public RMIBindingActivator(RMIHost rmiHost) {
> -        this.rmiHost = rmiHost;
> +    public RMIBindingActivator(RMIHostExtensionPoint rmiHosts) {
> +        this.rmiHost = new ExtensibleRMIHost(rmiHosts);
>      }
>
>      public Class<RMIBinding> getBindingClass() {
>
> Modified:
> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -54,10 +54,6 @@
>       */
>      private JavaImportExportListener listener;
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>          importProcessor = new JavaImportProcessor(factory);
>          exportProcessor = new JavaExportProcessor(factory);
>
> Modified:
> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -55,10 +55,6 @@
>       */
>      private NamespaceImportExportListener listener;
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>          importProcessor = new NamespaceImportProcessor(factory);
>          exportProcessor = new NamespaceExportProcessor(factory);
>
> Modified:
> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -40,16 +40,12 @@
>   */
> public class DataBindingModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>          DataBindingExtensionPoint dataBindings =
> registry.getExtensionPoint(DataBindingExtensionPoint.class);
>          TransformerExtensionPoint transformers =
> registry.getExtensionPoint(TransformerExtensionPoint.class);
>
>          //FIXME hack for now
>
> -        ((DefaultTransformerExtensionPoint)transformers).setDataBindings(dataBindings);
>
> +        //((DefaultTransformerExtensionPoint)transformers).setDataBindings(dataBindings);
>
>          MediatorImpl mediator = new MediatorImpl(dataBindings,
> transformers);
>          Input2InputTransformer input2InputTransformer = new
> Input2InputTransformer();
>
> Modified:
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -39,14 +39,6 @@
>   * @version $Rev$ $Date$
>   */
> public interface ModuleActivator {
> -    /**
> -     * Get a map of the extension points defined by this module. The key
> is the
> -     * java interface to represent the extension point and the the value
> is the
> -     * instance of the implementation of the interface.
> -     *
> -     * @return All the extension points defined by this module
> -     */
> -    Object[] getExtensionPoints();
>
>      /**
>       * This method is invoked when the module is started by the Tuscany
> system.
>
> Modified:
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
> Thu Aug  9 16:49:11 2007
> @@ -47,8 +47,6 @@
> import
> org.apache.tuscany.sca.core.spring.assembly.impl.BeanAssemblyFactory;
> import
> org.apache.tuscany.sca.core.spring.implementation.java.impl.BeanJavaImplementationFactory
> ;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
> ;
> @@ -104,7 +102,8 @@
>          InterfaceContractMapper interfaceContractMapper = new
> InterfaceContractMapperImpl();
>          JavaInterfaceFactory javaFactory = new
> DefaultJavaInterfaceFactory();
>          modelFactories.addFactory(javaFactory);
> -        JavaClassIntrospectorExtensionPoint classVisitors = new
> DefaultJavaClassIntrospectorExtensionPoint();
> +        JavaImplementationFactory javaImplementationFactory = new
> BeanJavaImplementationFactory(beanFactory);
> +        modelFactories.addFactory(javaImplementationFactory);
>
>          BaseJavaClassVisitor[] extensions = new BaseJavaClassVisitor[] {
>              new ConstructorProcessor(assemblyFactory),
> @@ -124,10 +123,8 @@
>              new PolicyProcessor(assemblyFactory, policyFactory)
>          };
>          for (JavaClassVisitor e : extensions) {
> -            classVisitors.addClassVisitor(e);
> +            javaImplementationFactory.addClassVisitor(e);
>          }
> -        JavaImplementationFactory javaImplementationFactory = new
> BeanJavaImplementationFactory(beanFactory, classVisitors);
> -        modelFactories.addFactory(javaImplementationFactory);
>
>          // Populate ArtifactProcessor registry
>          DefaultStAXArtifactProcessorExtensionPoint staxProcessors = new
> DefaultStAXArtifactProcessorExtensionPoint();
>
> Modified:
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
> Thu Aug  9 16:49:11 2007
> @@ -18,11 +18,14 @@
>   */
> package org.apache.tuscany.sca.core.spring.implementation.java.impl;
>
> +import java.util.ArrayList;
> +import java.util.List;
> +
> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> import
> org.apache.tuscany.sca.implementation.java.impl.JavaClassIntrospectorImpl;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> +import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import org.springframework.beans.factory.support.BeanDefinitionRegistry;
>
> /**
> @@ -34,10 +37,10 @@
> public class BeanJavaImplementationFactory implements
> JavaImplementationFactory {
>
>      private BeanDefinitionRegistry beanRegistry;
> +    private List<JavaClassVisitor> visitors = new
> ArrayList<JavaClassVisitor>();
>      private JavaClassIntrospectorImpl introspector;
>
> -    public BeanJavaImplementationFactory(BeanDefinitionRegistry
> beanRegistry,
> -
> JavaClassIntrospectorExtensionPoint visitors) {
> +    public BeanJavaImplementationFactory(BeanDefinitionRegistry
> beanRegistry) {
>          this.beanRegistry = beanRegistry;
>          introspector = new JavaClassIntrospectorImpl(visitors);
>      }
> @@ -55,6 +58,18 @@
>          JavaImplementation javaImplementation =
> createJavaImplementation();
>          introspector.introspectClass(javaImplementation,
> implementationClass);
>          return javaImplementation;
> +    }
> +
> +    public void addClassVisitor(JavaClassVisitor visitor) {
> +        visitors.add(visitor);
> +    }
> +
> +    public void removeClassVisitor(JavaClassVisitor visitor) {
> +        visitors.remove(visitor);
> +    }
> +
> +    public List<JavaClassVisitor> getClassVisitors() {
> +        return visitors;
>      }
>
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -32,10 +32,6 @@
>   */
> public class JAXBDataBindingModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>          ModelFactoryExtensionPoint modelFactories =
> registry.getExtensionPoint(ModelFactoryExtensionPoint.class);
>          JavaInterfaceFactory javaFactory = modelFactories.getFactory(
> JavaInterfaceFactory.class);
>
> Modified:
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -24,31 +24,18 @@
> import
> org.apache.tuscany.sca.contribution.processor.StAXArtifactProcessorExtensionPoint
> ;
> import org.apache.tuscany.sca.core.ExtensionPointRegistry;
> import org.apache.tuscany.sca.core.ModuleActivator;
> -import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
> -import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
> -import org.apache.tuscany.sca.databinding.sdo.DataObject2String;
> -import org.apache.tuscany.sca.databinding.sdo.DataObject2XMLStreamReader;
> import org.apache.tuscany.sca.databinding.sdo.HelperContextProcessor;
> import org.apache.tuscany.sca.databinding.sdo.HelperContextRegistry;
> import org.apache.tuscany.sca.databinding.sdo.HelperContextRegistryImpl;
> import org.apache.tuscany.sca.databinding.sdo.ImportSDOProcessor;
> -import org.apache.tuscany.sca.databinding.sdo.SDODataBinding;
> -import org.apache.tuscany.sca.databinding.sdo.String2DataObject;
> -import org.apache.tuscany.sca.databinding.sdo.XMLDocument2String;
> -import org.apache.tuscany.sca.databinding.sdo.XMLDocument2XMLStreamReader
> ;
> -import org.apache.tuscany.sca.databinding.sdo.XMLStreamReader2DataObject;
> -import org.apache.tuscany.sca.databinding.sdo.XMLStreamReader2XMLDocument
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> +import org.apache.tuscany.sca.databinding.sdo.SDOTypeRegisterListener;
> +import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>
> /**
>   * @version $Rev$ $Date$
>   */
> public class SDODataBindingModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
> (ModelFactoryExtensionPoint.class);
>          AssemblyFactory assemblyFactory = factories.getFactory(
> AssemblyFactory.class);
> @@ -60,8 +47,8 @@
>          //ContributionListenerExtensionPoint listeners =
> registry.getExtensionPoint(ContributionListenerExtensionPoint.class);
>          //listeners.addContributionListener(new
> SDOTypeRegisterListener(contextRegistry));
>
> -        JavaClassIntrospectorExtensionPoint introspectors =
> registry.getExtensionPoint(JavaClassIntrospectorExtensionPoint.class);
> -        introspectors.addClassVisitor(new
> HelperContextProcessor(assemblyFactory, contextRegistry));
> +        JavaImplementationFactory javaImplementationFactory =
> registry.getExtensionPoint(JavaImplementationFactory.class);
> +        javaImplementationFactory.addClassVisitor(new
> HelperContextProcessor(assemblyFactory, contextRegistry));
>
>      }
>
>
> Modified:
> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
> Thu Aug  9 16:49:11 2007
> @@ -29,7 +29,6 @@
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> import org.apache.tuscany.sca.implementation.java.impl.JavaResourceImpl;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
>
> import commonj.sdo.helper.HelperContext;
>
> @@ -43,7 +42,7 @@
>          HelperContextRegistry registry = new HelperContextRegistryImpl();
>          HelperContextProcessor processor = new HelperContextProcessor(new
> DefaultAssemblyFactory(), registry);
>
> -        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory(new
> DefaultJavaClassIntrospectorExtensionPoint());
> +        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory();
>          JavaImplementation componentType =
> javaImplementationFactory.createJavaImplementation();
>          componentType.setJavaClass(FooImpl.class);
>          for (Field f : FooImpl.class.getDeclaredFields()) {
>
> Modified:
> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
> Thu Aug  9 16:49:11 2007
> @@ -33,7 +33,6 @@
>   * @version $Rev$ $Date$
>   */
> public class DefaultTransformerExtensionPoint implements
> TransformerExtensionPoint {
> -    private DataBindingExtensionPoint dataBindings;
>      private boolean loadedTransformers;
>
>      private final DirectedGraph<Object, Transformer> graph = new
> DirectedGraph<Object, Transformer>();
> @@ -41,11 +40,6 @@
>      public DefaultTransformerExtensionPoint() {
>      }
>
> -    //FIXME Hack
> -    public void setDataBindings(DataBindingExtensionPoint dataBindings) {
> -        this.dataBindings = dataBindings;
> -    }
> -
>      public void addTransformer(String sourceType, String resultType, int
> weight, Transformer transformer) {
>          graph.addEdge(sourceType, resultType, transformer, weight);
>      }
> @@ -122,8 +116,8 @@
>      public List<Transformer> getTransformerChain(String sourceType,
> String resultType) {
>          loadTransformers();
>
> -        String source = normalize(sourceType);
> -        String result = normalize(resultType);
> +        String source = sourceType;
> +        String result = resultType;
>          List<Transformer> transformers = new ArrayList<Transformer>();
>          DirectedGraph<Object, Transformer>.Path path =
> graph.getShortestPath(source, result);
>          if (path == null) {
> @@ -139,22 +133,6 @@
>          loadTransformers();
>
>          return graph.toString();
> -    }
> -
> -    /**
> -     * Normalize the id to a name of a data binding as databindings may
> have aliases
> -     * @param id
> -     * @return
> -     */
> -    private String normalize(String id) {
> -        loadTransformers();
> -
> -        if (dataBindings != null) {
> -            DataBinding dataBinding = dataBindings.getDataBinding(id);
> -            return dataBinding == null ? id : dataBinding.getName();
> -        } else {
> -            return id;
> -        }
>      }
>
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
> Thu Aug  9 16:49:11 2007
> @@ -253,12 +253,6 @@
>                  Class moduleClass = Class.forName(className, true,
> classLoader);
>                  ModuleActivator module =
> (ModuleActivator)moduleClass.newInstance();
>                  modules.add(module);
> -                Object[] extensionPoints = module.getExtensionPoints();
> -                if (extensionPoints != null) {
> -                    for (Object e : extensionPoints) {
> -                        registry.addExtensionPoint(e);
> -                    }
> -                }
>              }
>          } catch (IOException e) {
>              throw new ActivationException(e);
>
> Modified:
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -140,10 +140,6 @@
>          return new QName(Constants.SCA10_NS, "binding." + sb.toString());
>      }
>
> -    public Object[] getExtensionPoints() {
> -        return null; // not used by binding or implementation extensions
> -    }
> -
>      private final class DelegatingBindingProviderFactory implements
> BindingProviderFactory {
>          private Class modelType;
>
>
> Modified:
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -133,8 +133,4 @@
>          return new QName(Constants.SCA10_NS, "implementation." +
> sb.toString());
>      }
>
> -
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
> Thu Aug  9 16:49:11 2007
> @@ -53,15 +53,6 @@
> import org.apache.tuscany.sca.core.runtime.CompositeActivator;
> import org.apache.tuscany.sca.core.runtime.RuntimeAssemblyFactory;
> import org.apache.tuscany.sca.core.work.ThreadPoolWorkManager;
> -import org.apache.tuscany.sca.databinding.DataBinding;
> -import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
> -import org.apache.tuscany.sca.databinding.PullTransformer;
> -import org.apache.tuscany.sca.databinding.PushTransformer;
> -import org.apache.tuscany.sca.databinding.Transformer;
> -import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
> -import org.apache.tuscany.sca.databinding.impl.LazyDataBinding;
> -import org.apache.tuscany.sca.databinding.impl.LazyPullTransformer;
> -import org.apache.tuscany.sca.databinding.impl.LazyPushTransformer;
> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
> import
> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
> import org.apache.tuscany.sca.interfacedef.impl.TempServiceDeclarationUtil
> ;
> @@ -212,12 +203,6 @@
>                  Class moduleClass = Class.forName(className, true,
> classLoader);
>                  ModuleActivator module =
> (ModuleActivator)moduleClass.newInstance();
>                  modules.add(module);
> -                Object[] extensionPoints = module.getExtensionPoints();
> -                if (extensionPoints != null) {
> -                    for (Object e : extensionPoints) {
> -                        registry.addExtensionPoint(e);
> -                    }
> -                }
>              }
>          } catch (IOException e) {
>              throw new ActivationException(e);
>
> Modified:
> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -43,12 +43,6 @@
>   */
> public class CRUDModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        // This module extension does not contribute any new
> -        // extension point
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>
>          // Create the CRUD implementation factory
>
> Modified:
> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
> Thu Aug  9 16:49:11 2007
> @@ -19,9 +19,6 @@
>
> package org.apache.tuscany.sca.http;
>
> -import java.util.ArrayList;
> -import java.util.List;
> -
> import javax.servlet.Servlet;
>
> /**
> @@ -32,14 +29,12 @@
> public class ExtensibleServletHost implements ServletHost {
>
>      private ServletHostExtensionPoint servletHosts;
> -    private List<String> uriList = new ArrayList<String>();
>
>      public ExtensibleServletHost(ServletHostExtensionPoint servletHosts)
> {
>          this.servletHosts = servletHosts;
>      }
>
>      public void addServletMapping(String uri, Servlet servlet) throws
> ServletMappingException {
> -        uriList.add(uri);
>          if (servletHosts.getServletHosts().isEmpty()) {
>              throw new ServletMappingException("No servlet host
> available");
>          }
> @@ -50,20 +45,9 @@
>      }
>
>      public Servlet removeServletMapping(String uri) throws
> ServletMappingException {
> -        uriList.remove(uri);
>          // TODO implement selection of the correct servlet host based on
> the mapping
>          // For now just select the first one
>          return servletHosts.getServletHosts
> ().get(0).removeServletMapping(uri);
>      }
>
> -    /**
> -     * For debugging purposes this returns the list of URI strings
> -     * that have been passed in
> -     *
> -     * @return the string uri list
> -     */
> -    public List<String> getURIList(){
> -        return uriList;
> -    }
> -
> }
>
> Copied:
> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
> (from r564365,
> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator)
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint?view=diff&rev=564429&p1=incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator&r1=564365&p2=incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
> Thu Aug  9 16:49:11 2007
> @@ -14,5 +14,5 @@
> # KIND, either express or implied.  See the License for the
> # specific language governing permissions and limitations
> # under the License.
> -# Implementation class for the ModuleActivator
> -org.apache.tuscany.sca.http.module.HTTPRuntimeModuleActivator
> +
> +org.apache.tuscany.sca.http.DefaultServletHostExtensionPoint
>
> Added:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java?view=auto&rev=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
> (added)
> +++
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
> Thu Aug  9 16:49:11 2007
> @@ -0,0 +1,49 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +
> +package org.apache.tuscany.sca.rmi;
> +
> +import java.util.ArrayList;
> +import java.util.List;
> +
> +/**
> + * Default implementation of an RMI host extension point.
> + *
> + * @version $Rev$ $Date$
> + */
> +public class DefaultRMIHostExtensionPoint implements
> RMIHostExtensionPoint {
> +
> +    private List<RMIHost> rmiHosts = new ArrayList<RMIHost>();
> +
> +    public DefaultRMIHostExtensionPoint() {
> +        addRMIHost(new DefaultRMIHost());
> +    }
> +
> +    public void addRMIHost(RMIHost rmiHost) {
> +        rmiHosts.add(rmiHost);
> +    }
> +
> +    public void removeRMIHost(RMIHost rmiHost) {
> +        rmiHosts.remove(rmiHost);
> +    }
> +
> +    public List<RMIHost> getRMIHosts() {
> +        return rmiHosts;
> +    }
> +}
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>
> ------------------------------------------------------------------------------
>     svn:keywords = Rev Date
>
> Added:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java?view=auto&rev=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
> (added)
> +++
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
> Thu Aug  9 16:49:11 2007
> @@ -0,0 +1,73 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +
> +package org.apache.tuscany.sca.rmi;
> +
> +import java.rmi.Remote;
> +
> +
> +/**
> + * Default implementation of an extensible servlet host.
> + *
> + * @version $Rev$ $Date$
> + */
> +public class ExtensibleRMIHost implements RMIHost {
> +
> +    private RMIHostExtensionPoint rmiHosts;
> +
> +    public ExtensibleRMIHost(RMIHostExtensionPoint rmiHosts) {
> +        this.rmiHosts = rmiHosts;
> +    }
> +
> +    public void registerService(String serviceName, int port, Remote
> serviceObject) throws RMIHostException, RMIHostRuntimeException {
> +        if (rmiHosts.getRMIHosts().isEmpty()) {
> +            throw new RMIHostException("No RMI host available");
> +        }
> +        rmiHosts.getRMIHosts().get(0).registerService(serviceName, port,
> serviceObject);
> +    }
> +
> +    public Remote findService(String host, String port, String svcName)
> throws RMIHostException, RMIHostRuntimeException {
> +        if (rmiHosts.getRMIHosts().isEmpty()) {
> +            throw new RMIHostException("No RMI host available");
> +        }
> +        return rmiHosts.getRMIHosts().get(0).findService(host, port,
> svcName);
> +    }
> +
> +    public void registerService(String serviceName, Remote serviceObject)
> throws RMIHostException, RMIHostRuntimeException {
> +        if (rmiHosts.getRMIHosts().isEmpty()) {
> +            throw new RMIHostException("No RMI host available");
> +        }
> +        rmiHosts.getRMIHosts().get(0).registerService(serviceName,
> serviceObject);
> +    }
> +
> +    public void unregisterService(String serviceName) throws
> RMIHostException, RMIHostRuntimeException {
> +        if (rmiHosts.getRMIHosts().isEmpty()) {
> +            throw new RMIHostException("No RMI host available");
> +        }
> +        rmiHosts.getRMIHosts().get(0).unregisterService(serviceName);
> +    }
> +
> +    public void unregisterService(String serviceName, int port) throws
> RMIHostException, RMIHostRuntimeException {
> +        if (rmiHosts.getRMIHosts().isEmpty()) {
> +            throw new RMIHostException("No RMI host available");
> +        }
> +        rmiHosts.getRMIHosts().get(0).unregisterService(serviceName,
> port);
> +    }
> +
> +}
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>
> ------------------------------------------------------------------------------
>     svn:keywords = Rev Date
>
> Added:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java?view=auto&rev=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
> (added)
> +++
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
> Thu Aug  9 16:49:11 2007
> @@ -0,0 +1,51 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +package org.apache.tuscany.sca.rmi;
> +
> +import java.util.List;
> +
> +/**
> + * An extension point for RMI hosts.
> + *
> + * @version $Rev$ $Date$
> + */
> +public interface RMIHostExtensionPoint {
> +
> +    /**
> +     * Adds a servlet host extension.
> +     *
> +     * @param rmiHost
> +     */
> +    void addRMIHost(RMIHost rmiHost);
> +
> +    /**
> +     * Removes a servlet host extension.
> +     *
> +     * @param rmiHost
> +     */
> +    void removeRMIHost(RMIHost rmiHost);
> +
> +    /**
> +     * Returns a list of servlet host extensions.
> +     *
> +     * @return
> +     */
> +    List<RMIHost> getRMIHosts();
> +
> +}
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>
> ------------------------------------------------------------------------------
>     svn:eol-style = native
>
> Propchange:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>
> ------------------------------------------------------------------------------
>     svn:keywords = Rev Date
>
> Copied:
> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
> (from r564365,
> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator)
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint?view=diff&rev=564429&p1=incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator&r1=564365&p2=incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
> Thu Aug  9 16:49:11 2007
> @@ -14,5 +14,5 @@
> # KIND, either express or implied.  See the License for the
> # specific language governing permissions and limitations
> # under the License.
> -# Implementation class for the ModuleActivator
> -org.apache.tuscany.sca.rmi.module.RMIRuntimeModuleActivator
> +
> +org.apache.tuscany.sca.rmi.DefaultRMIHostExtensionPoint
>
> Modified:
> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -39,8 +39,4 @@
>      public void stop(ExtensionPointRegistry registry) {
>      }
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -32,10 +32,6 @@
>
>      private JettyServer server;
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry extensionPointRegistry) {
>
>          // Register a Jetty servlet host
>
> Modified:
> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -32,10 +32,6 @@
>
>      private TomcatServer server;
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry extensionPointRegistry) {
>
>          // Register a Tomcat servlet host
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -30,11 +30,8 @@
> import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
> import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
> import org.apache.tuscany.sca.databinding.impl.MediatorImpl;
> -import
> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
> ;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> import
> org.apache.tuscany.sca.implementation.java.context.JavaPropertyValueObjectFactory
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
> ;
> @@ -55,7 +52,6 @@
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.ServiceProcessor
> ;
> import
> org.apache.tuscany.sca.implementation.java.invocation.CglibProxyFactory;
> import
> org.apache.tuscany.sca.implementation.java.invocation.JavaImplementationProviderFactory
> ;
> -import
> org.apache.tuscany.sca.interfacedef.java.DefaultJavaInterfaceFactory;
> import org.apache.tuscany.sca.interfacedef.java.JavaInterfaceFactory;
> import org.apache.tuscany.sca.invocation.MessageFactory;
> import org.apache.tuscany.sca.policy.PolicyFactory;
> @@ -66,17 +62,10 @@
>   */
> public class JavaRuntimeModuleActivator implements ModuleActivator {
>
> -    private JavaClassIntrospectorExtensionPoint classVisitors;
> -
>      public JavaRuntimeModuleActivator() {
>      }
>
>
> -    public Object[] getExtensionPoints() {
> -        classVisitors = new DefaultJavaClassIntrospectorExtensionPoint();
> -        return new Object[] { classVisitors };
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>
>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
> (ModelFactoryExtensionPoint.class);
> @@ -88,6 +77,7 @@
>          proxyFactory.setClassProxyFactory(new
> CglibProxyFactory(messageFactory, proxyFactory.getInterfaceContractMapper
> ()));
>
>          JavaInterfaceFactory javaFactory = factories.getFactory(
> JavaInterfaceFactory.class);
> +        JavaImplementationFactory javaImplementationFactory =
> factories.getFactory(JavaImplementationFactory.class);
>
>          BaseJavaClassVisitor[] extensions = new BaseJavaClassVisitor[] {
>              new ConstructorProcessor(assemblyFactory),
> @@ -108,16 +98,13 @@
>              new PolicyProcessor(assemblyFactory, policyFactory)
>          };
>          for (JavaClassVisitor extension : extensions) {
> -            classVisitors.addClassVisitor(extension);
> +            javaImplementationFactory.addClassVisitor(extension);
>          }
>
>          DataBindingExtensionPoint dataBindings =
> registry.getExtensionPoint(DataBindingExtensionPoint.class);
>          TransformerExtensionPoint transformers =
> registry.getExtensionPoint(TransformerExtensionPoint.class);
>          MediatorImpl mediator =new MediatorImpl(dataBindings,
> transformers);
>          JavaPropertyValueObjectFactory factory = new
> JavaPropertyValueObjectFactory(mediator);
> -
> -        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory(classVisitors);
> -        factories.addFactory(javaImplementationFactory);
>
>          ContextFactoryExtensionPoint contextFactories =
> registry.getExtensionPoint(ContextFactoryExtensionPoint.class);
>          ComponentContextFactory componentContextFactory =
> contextFactories.getFactory(ComponentContextFactory.class);
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
> Thu Aug  9 16:49:11 2007
> @@ -42,7 +42,6 @@
> import org.apache.tuscany.sca.contribution.resolver.ModelResolver;
> import
> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
> ;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
> import
> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
> @@ -75,7 +74,7 @@
>          staxProcessors = new
> DefaultStAXArtifactProcessorExtensionPoint();
>          staxProcessor = new
> ExtensibleStAXArtifactProcessor(staxProcessors,
> XMLInputFactory.newInstance(), XMLOutputFactory.newInstance());
>
> -        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory(new
> DefaultJavaClassIntrospectorExtensionPoint());
> +        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory();
>          modelFactories.addFactory(javaImplementationFactory);
>
>          CompositeProcessor compositeProcessor = new
> CompositeProcessor(new ContributionFactoryImpl(), assemblyFactory,
> policyFactory, mapper, staxProcessor);
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
> Thu Aug  9 16:49:11 2007
> @@ -39,7 +39,6 @@
> import
> org.apache.tuscany.sca.contribution.processor.ExtensibleStAXArtifactProcessor
> ;
> import
> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
> ;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
> import
> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
> @@ -70,7 +69,7 @@
>          staxProcessors = new
> DefaultStAXArtifactProcessorExtensionPoint();
>          staxProcessor = new
> ExtensibleStAXArtifactProcessor(staxProcessors,
> XMLInputFactory.newInstance(), XMLOutputFactory.newInstance());
>
> -        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory(new
> DefaultJavaClassIntrospectorExtensionPoint());
> +        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory();
>          modelFactories.addFactory(javaImplementationFactory);
>
>          staxProcessors.addArtifactProcessor(new CompositeProcessor(null,
> factory, policyFactory, mapper, staxProcessor));
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
> Thu Aug  9 16:49:11 2007
> @@ -22,20 +22,10 @@
>   * A factory for the Java model.
>   */
> import
> org.apache.tuscany.sca.implementation.java.impl.JavaImplementationFactoryImpl
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
>
> public class DefaultJavaImplementationFactory extends
> JavaImplementationFactoryImpl implements JavaImplementationFactory {
>
> -    /**
> -     * @deprecated Please use the constructor that takes a
> JavaClassIntrospectorExtensionPoint.
> -     */
>      public DefaultJavaImplementationFactory() {
> -        super(new DefaultJavaClassIntrospectorExtensionPoint());
> -    }
> -
> -    public
> DefaultJavaImplementationFactory(JavaClassIntrospectorExtensionPoint
> visitors) {
> -        super(visitors);
>      }
>
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
> Thu Aug  9 16:49:11 2007
> @@ -18,6 +18,10 @@
>   */
> package org.apache.tuscany.sca.implementation.java;
>
> +import java.util.List;
> +
> +import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> +
>
> /**
>   * Factory for the Java model
> @@ -48,5 +52,24 @@
>       * @return
>       */
>      void createJavaImplementation(JavaImplementation javaImplementation,
> Class<?> implementationClass) throws IntrospectionException;
> +
> +    /**
> +     * Registers the given visitor.
> +     *
> +     * @param visitor
> +     */
> +    void addClassVisitor(JavaClassVisitor visitor);
> +
> +    /**
> +     * Deregisters the given visitor.
> +     */
> +    void removeClassVisitor(JavaClassVisitor visitor);
> +
> +    /**
> +     * Returns the list of visitors.
> +     *
> +     * @return
> +     */
> +    List<JavaClassVisitor> getClassVisitors();
>
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
> Thu Aug  9 16:49:11 2007
> @@ -26,7 +26,6 @@
>
> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.JavaIntrospectionHelper
> ;
>
> @@ -39,8 +38,8 @@
>
>      private List<JavaClassVisitor> visitors;
>
> -    public JavaClassIntrospectorImpl(JavaClassIntrospectorExtensionPoint
> visitors) {
> -        this.visitors = visitors.getClassVisitors();
> +    public JavaClassIntrospectorImpl(List<JavaClassVisitor> visitors) {
> +        this.visitors = visitors;
>      }
>
>      /**
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
> Thu Aug  9 16:49:11 2007
> @@ -21,16 +21,20 @@
> /**
>   * A factory for the Java model.
>   */
> +import java.util.ArrayList;
> +import java.util.List;
> +
> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> +import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>
> public abstract class JavaImplementationFactoryImpl implements
> JavaImplementationFactory {
>
> +    private List<JavaClassVisitor> visitors = new
> ArrayList<JavaClassVisitor>();
>      private JavaClassIntrospectorImpl introspector;
>
> -    public
> JavaImplementationFactoryImpl(JavaClassIntrospectorExtensionPoint visitors)
> {
> +    public JavaImplementationFactoryImpl() {
>          introspector = new JavaClassIntrospectorImpl(visitors);
>      }
>
> @@ -47,6 +51,18 @@
>
>      public void createJavaImplementation(JavaImplementation
> javaImplementation, Class<?> implementationClass) throws
> IntrospectionException {
>          introspector.introspectClass(javaImplementation,
> implementationClass);
> +    }
> +
> +    public void addClassVisitor(JavaClassVisitor visitor) {
> +        visitors.add(visitor);
> +    }
> +
> +    public void removeClassVisitor(JavaClassVisitor visitor) {
> +        visitors.remove(visitor);
> +    }
> +
> +    public List<JavaClassVisitor> getClassVisitors() {
> +        return visitors;
>      }
>
> }
>
> Added:
> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory?view=auto&rev=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
> (added)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
> Thu Aug  9 16:49:11 2007
> @@ -0,0 +1,18 @@
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements.  See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership.  The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License.  You may obtain a copy of the License at
> +#
> +#   http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied.  See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +
>
> +org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
> Thu Aug  9 16:49:11 2007
> @@ -27,7 +27,6 @@
> import
> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
> ;
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import org.easymock.EasyMock;
>
> @@ -37,21 +36,21 @@
> public class JavaClassIntrospectorImplTestCase extends TestCase {
>
>      public void testRegister() throws Exception {
> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
> DefaultJavaClassIntrospectorExtensionPoint();
> +        JavaImplementationFactory factory = new
> DefaultJavaImplementationFactory();
>          JavaClassVisitor extension = EasyMock.createNiceMock(
> JavaClassVisitor.class);
> -        visitors.addClassVisitor(extension);
> +        factory.addClassVisitor(extension);
>      }
>
>      public void testUnegister() throws Exception {
> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
> DefaultJavaClassIntrospectorExtensionPoint();
> +        JavaImplementationFactory factory = new
> DefaultJavaImplementationFactory();
>          JavaClassVisitor extension = EasyMock.createNiceMock(
> JavaClassVisitor.class);
> -        visitors.addClassVisitor(extension);
> -        visitors.removeClassVisitor(extension);
> +        factory.addClassVisitor(extension);
> +        factory.removeClassVisitor(extension);
>      }
>
>      @SuppressWarnings("unchecked")
>      public void testWalk() throws Exception {
> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
> DefaultJavaClassIntrospectorExtensionPoint();
> +        JavaImplementationFactory factory = new
> DefaultJavaImplementationFactory();
>          JavaClassVisitor extension = EasyMock.createMock(
> JavaClassVisitor.class);
>          extension.visitClass(EasyMock.eq(Bar.class), EasyMock.isA(
> JavaImplementation.class));
>          extension.visitConstructor(EasyMock.isA(Constructor.class),
> EasyMock.isA(JavaImplementation.class));
> @@ -67,9 +66,8 @@
>          // mock.expects(once()).method("visitSuperClass");
>          // mock.expects(once()).method("visitEnd");
>          EasyMock.replay(extension);
> -        visitors.addClassVisitor(extension);
> -        JavaImplementationFactory javaImplementationFactory = new
> DefaultJavaImplementationFactory(visitors);
> -        javaImplementationFactory.createJavaImplementation(
> javaImplementationFactory.createJavaImplementation(), Bar.class);
> +        factory.addClassVisitor(extension);
> +        factory.createJavaImplementation(Bar.class);
>          EasyMock.verify(extension);
>      }
>
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -46,7 +46,4 @@
>          processors.removeArtifactProcessor(implementationLoader);
>      }
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> }
>
> Modified:
> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
> Thu Aug  9 16:49:11 2007
> @@ -30,8 +30,6 @@
> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
> import
> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
> import org.apache.tuscany.sca.implementation.java.impl.JavaElementImpl;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
> ;
> -import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
> ;
> import
> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
> ;
> @@ -60,7 +58,6 @@
>   */
> public class SpringBeanIntrospector {
>
> -    private JavaClassIntrospectorExtensionPoint classVisitors = new
> DefaultJavaClassIntrospectorExtensionPoint();
>      private JavaImplementationFactory javaImplementationFactory;
>
>      /**
> @@ -74,6 +71,8 @@
>                                    JavaInterfaceFactory javaFactory,
>                                    PolicyFactory policyFactory) {
>
> +        javaImplementationFactory = new
> DefaultJavaImplementationFactory();
> +
>          // Create the list of class visitors
>          BaseJavaClassVisitor[] extensions =
>              new BaseJavaClassVisitor[] {
> @@ -93,10 +92,8 @@
>                                          new
> HeuristicPojoProcessor(assemblyFactory, javaFactory),
>                                          new
> PolicyProcessor(assemblyFactory, policyFactory)};
>          for (JavaClassVisitor extension : extensions) {
> -            classVisitors.addClassVisitor(extension);
> +            javaImplementationFactory.addClassVisitor(extension);
>          }
> -
> -        javaImplementationFactory = new
> DefaultJavaImplementationFactory(classVisitors);
>
>      } // end constructor
>
>
> Modified:
> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -32,10 +32,6 @@
>   */
> public class WSDLInterfaceRuntimeModuleActivator implements
> ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>
>          ModelResolverExtensionPoint resolvers =
> registry.getExtensionPoint(ModelResolverExtensionPoint.class);
>
> Modified:
> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -36,11 +36,6 @@
>   */
> public class EchoModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        // No extensionPoints being contributed here
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>
>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
> (ModelFactoryExtensionPoint.class);
>
> Modified:
> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
> (original)
> +++
> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
> Thu Aug  9 16:49:11 2007
> @@ -41,11 +41,6 @@
>   */
> public class CRUDModuleActivator implements ModuleActivator {
>
> -    public Object[] getExtensionPoints() {
> -        // This module extension does not contribute any new extension
> point
> -        return null;
> -    }
> -
>      public void start(ExtensionPointRegistry registry) {
>
>          // Create the CRUD implementation factory
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>
>

Re: svn commit: r564429 - in /incubator/tuscany/java/sca: modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/ modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/ modules/binding-notification/src/main/java

Posted by ant elder <an...@gmail.com>.
On 8/10/07, Jean-Sebastien Delfino <js...@apache.org> wrote:
>
> ant elder wrote:
> > How about instead of extension having to do "new
> > ExtensibleServletHost(servletHosts)" that code is moved into the
> > ExtensionUtils DiscoveryUtils class as a special case so that extensions
> can
> > still just use the simple constructor taking a ServletHost and
> > ExtensionHelper creates the ExtensibleServletHost for them?
> >
> >
>
> Sure, but won't that create a new dependency from extension-helper on
> host-http?


Thats true, and thats no good. Guess it could just use reflection, bit messy
but are there any alternatives? Its just the whole point of it is to avoid
extensions having to know and do stuff like this so it would be really good
to find a way to avoid it.

   ...ant

Re: svn commit: r564429 - in /incubator/tuscany/java/sca: modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/ modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/ modules/binding-notification/src/main/java

Posted by Jean-Sebastien Delfino <js...@apache.org>.
ant elder wrote:
> How about instead of extension having to do "new
> ExtensibleServletHost(servletHosts)" that code is moved into the
> ExtensionUtils DiscoveryUtils class as a special case so that extensions can
> still just use the simple constructor taking a ServletHost and
> ExtensionHelper creates the ExtensibleServletHost for them?
>
>   

Sure, but won't that create a new dependency from extension-helper on 
host-http?

> Unrelated to that but i was reminded while seeing the code again - how about
> adding a getServlet method to the ServletHost interface so things like
> jsonrpc and ajax bindings don't have to mess about doing
> removeServletMapping/addServletMapping to get the servlet?
>
>    ...ant
>   

+1 makes sense

but can you help me understand why the JSON RPC and Ajax bindings need 
to GET the servlet in the first place? aren't they adding  that servlet 
to begin with?

> On 8/10/07, jsdelfino@apache.org <js...@apache.org> wrote:
>   
>> Author: jsdelfino
>> Date: Thu Aug  9 16:49:11 2007
>> New Revision: 564429
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=564429
>> Log:
>> More changes to dynamically load extension points and help with footprint.
>>
>> Added:
>>
>>     incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
>>       - copied, changed from r564365,
>> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>> (with props)
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>> (with props)
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>> (with props)
>>
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
>>       - copied, changed from r564365,
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
>> Removed:
>>
>>     incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/module/
>>
>>     incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>>
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/module/
>>
>>     incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/DefaultJavaClassIntrospectorExtensionPoint.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/ExtensibleJavaClassIntrospector.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/JavaClassIntrospector.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/JavaClassIntrospectorExtensionPoint.java
>> Modified:
>>
>>     incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
>>
>>     incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
>>
>>     incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
>>
>>     incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
>>
>>     incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
>>
>>     incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
>>
>>     incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
>>
>>     incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
>>
>>     incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
>>
>>     incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
>>
>>     incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
>>
>>     incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
>>
>>     incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
>>
>>     incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
>>
>>     incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
>>
>>     incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
>>
>>     incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/binding-ajax/src/main/java/org/apache/tuscany/sca/binding/ajax/AjaxBindingActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -20,7 +20,9 @@
>> package org.apache.tuscany.sca.binding.ajax;
>>
>> import org.apache.tuscany.sca.assembly.Binding;
>> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
>> import org.apache.tuscany.sca.http.ServletHost;
>> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
>> import org.apache.tuscany.sca.runtime.RuntimeComponent;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
>> @@ -32,8 +34,8 @@
>>
>>      private ServletHost servletHost;
>>
>> -    public AjaxBindingActivator(ServletHost servletHost) {
>> -        this.servletHost = servletHost;
>> +    public AjaxBindingActivator(ServletHostExtensionPoint servletHosts) {
>> +        this.servletHost = new ExtensibleServletHost(servletHosts);
>>      }
>>
>>      public Class<AjaxBinding> getBindingClass() {
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/binding-jsonrpc/src/main/java/org/apache/tuscany/sca/binding/jsonrpc/JSONRPCBindingActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -20,7 +20,9 @@
>> package org.apache.tuscany.sca.binding.jsonrpc;
>>
>> import org.apache.tuscany.sca.assembly.Binding;
>> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
>> import org.apache.tuscany.sca.http.ServletHost;
>> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
>> import org.apache.tuscany.sca.runtime.RuntimeComponent;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
>> @@ -33,8 +35,8 @@
>>
>>      protected ServletHost servletHost;
>>
>> -    public JSONRPCBindingActivator(ServletHost servletHost) {
>> -        this.servletHost = servletHost;
>> +    public JSONRPCBindingActivator(ServletHostExtensionPoint
>> servletHosts) {
>> +        this.servletHost = new ExtensibleServletHost(servletHosts);
>>      }
>>
>>      public Class<JSONRPCBinding> getBindingClass() {
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/binding-notification/src/main/java/org/apache/tuscany/sca/binding/notification/NotificationBindingModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -53,7 +53,9 @@
>> import
>> org.apache.tuscany.sca.contribution.processor.StAXArtifactProcessorExtensionPoint
>> ;
>> import org.apache.tuscany.sca.core.ExtensionPointRegistry;
>> import org.apache.tuscany.sca.core.ModuleActivator;
>> +import org.apache.tuscany.sca.http.ExtensibleServletHost;
>> import org.apache.tuscany.sca.http.ServletHost;
>> +import org.apache.tuscany.sca.http.ServletHostExtensionPoint;
>> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
>> import org.apache.tuscany.sca.policy.PolicyFactory;
>> import org.apache.tuscany.sca.provider.ProviderFactoryExtensionPoint;
>> @@ -157,7 +159,7 @@
>>              httpPort = DEFAULT_PORT;
>>          }
>>
>> -        ServletHost servletHost = registry.getExtensionPoint(
>> ServletHost.class);
>> +        ServletHost servletHost = new ExtensibleServletHost(
>> registry.getExtensionPoint(ServletHostExtensionPoint.class));
>>
>>          ntm = new NotificationTypeManagerImpl();
>>          ntm.setServletHost(servletHost);
>> @@ -220,7 +222,4 @@
>>          processors.removeArtifactProcessor(bindingProcessor);
>>      }
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/binding-rmi/src/main/java/org/apache/tuscany/sca/binding/rmi/RMIBindingActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -20,7 +20,9 @@
>> package org.apache.tuscany.sca.binding.rmi;
>>
>> import org.apache.tuscany.sca.assembly.Binding;
>> +import org.apache.tuscany.sca.rmi.ExtensibleRMIHost;
>> import org.apache.tuscany.sca.rmi.RMIHost;
>> +import org.apache.tuscany.sca.rmi.RMIHostExtensionPoint;
>> import org.apache.tuscany.sca.runtime.RuntimeComponent;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentReference;
>> import org.apache.tuscany.sca.runtime.RuntimeComponentService;
>> @@ -32,8 +34,8 @@
>>
>>      private RMIHost rmiHost;
>>
>> -    public RMIBindingActivator(RMIHost rmiHost) {
>> -        this.rmiHost = rmiHost;
>> +    public RMIBindingActivator(RMIHostExtensionPoint rmiHosts) {
>> +        this.rmiHost = new ExtensibleRMIHost(rmiHosts);
>>      }
>>
>>      public Class<RMIBinding> getBindingClass() {
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/contribution-java/src/main/java/org/apache/tuscany/sca/contribution/java/impl/JavaImportExportModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -54,10 +54,6 @@
>>       */
>>      private JavaImportExportListener listener;
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>          importProcessor = new JavaImportProcessor(factory);
>>          exportProcessor = new JavaExportProcessor(factory);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/contribution-namespace/src/main/java/org/apache/tuscany/sca/contribution/namespace/impl/NamespaceImportExportModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -55,10 +55,6 @@
>>       */
>>      private NamespaceImportExportListener listener;
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>          importProcessor = new NamespaceImportProcessor(factory);
>>          exportProcessor = new NamespaceExportProcessor(factory);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/core-databinding/src/main/java/org/apache/tuscany/sca/core/databinding/module/DataBindingModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -40,16 +40,12 @@
>>   */
>> public class DataBindingModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>          DataBindingExtensionPoint dataBindings =
>> registry.getExtensionPoint(DataBindingExtensionPoint.class);
>>          TransformerExtensionPoint transformers =
>> registry.getExtensionPoint(TransformerExtensionPoint.class);
>>
>>          //FIXME hack for now
>>
>> -        ((DefaultTransformerExtensionPoint)transformers).setDataBindings(dataBindings);
>>
>> +        //((DefaultTransformerExtensionPoint)transformers).setDataBindings(dataBindings);
>>
>>          MediatorImpl mediator = new MediatorImpl(dataBindings,
>> transformers);
>>          Input2InputTransformer input2InputTransformer = new
>> Input2InputTransformer();
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/sca/core/ModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -39,14 +39,6 @@
>>   * @version $Rev$ $Date$
>>   */
>> public interface ModuleActivator {
>> -    /**
>> -     * Get a map of the extension points defined by this module. The key
>> is the
>> -     * java interface to represent the extension point and the the value
>> is the
>> -     * instance of the implementation of the interface.
>> -     *
>> -     * @return All the extension points defined by this module
>> -     */
>> -    Object[] getExtensionPoints();
>>
>>      /**
>>       * This method is invoked when the module is started by the Tuscany
>> system.
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/context/SCADomainContext.java
>> Thu Aug  9 16:49:11 2007
>> @@ -47,8 +47,6 @@
>> import
>> org.apache.tuscany.sca.core.spring.assembly.impl.BeanAssemblyFactory;
>> import
>> org.apache.tuscany.sca.core.spring.implementation.java.impl.BeanJavaImplementationFactory
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
>> ;
>> @@ -104,7 +102,8 @@
>>          InterfaceContractMapper interfaceContractMapper = new
>> InterfaceContractMapperImpl();
>>          JavaInterfaceFactory javaFactory = new
>> DefaultJavaInterfaceFactory();
>>          modelFactories.addFactory(javaFactory);
>> -        JavaClassIntrospectorExtensionPoint classVisitors = new
>> DefaultJavaClassIntrospectorExtensionPoint();
>> +        JavaImplementationFactory javaImplementationFactory = new
>> BeanJavaImplementationFactory(beanFactory);
>> +        modelFactories.addFactory(javaImplementationFactory);
>>
>>          BaseJavaClassVisitor[] extensions = new BaseJavaClassVisitor[] {
>>              new ConstructorProcessor(assemblyFactory),
>> @@ -124,10 +123,8 @@
>>              new PolicyProcessor(assemblyFactory, policyFactory)
>>          };
>>          for (JavaClassVisitor e : extensions) {
>> -            classVisitors.addClassVisitor(e);
>> +            javaImplementationFactory.addClassVisitor(e);
>>          }
>> -        JavaImplementationFactory javaImplementationFactory = new
>> BeanJavaImplementationFactory(beanFactory, classVisitors);
>> -        modelFactories.addFactory(javaImplementationFactory);
>>
>>          // Populate ArtifactProcessor registry
>>          DefaultStAXArtifactProcessorExtensionPoint staxProcessors = new
>> DefaultStAXArtifactProcessorExtensionPoint();
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/core-spring/src/main/java/org/apache/tuscany/sca/core/spring/implementation/java/impl/BeanJavaImplementationFactory.java
>> Thu Aug  9 16:49:11 2007
>> @@ -18,11 +18,14 @@
>>   */
>> package org.apache.tuscany.sca.core.spring.implementation.java.impl;
>>
>> +import java.util.ArrayList;
>> +import java.util.List;
>> +
>> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> import
>> org.apache.tuscany.sca.implementation.java.impl.JavaClassIntrospectorImpl;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> +import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import org.springframework.beans.factory.support.BeanDefinitionRegistry;
>>
>> /**
>> @@ -34,10 +37,10 @@
>> public class BeanJavaImplementationFactory implements
>> JavaImplementationFactory {
>>
>>      private BeanDefinitionRegistry beanRegistry;
>> +    private List<JavaClassVisitor> visitors = new
>> ArrayList<JavaClassVisitor>();
>>      private JavaClassIntrospectorImpl introspector;
>>
>> -    public BeanJavaImplementationFactory(BeanDefinitionRegistry
>> beanRegistry,
>> -
>> JavaClassIntrospectorExtensionPoint visitors) {
>> +    public BeanJavaImplementationFactory(BeanDefinitionRegistry
>> beanRegistry) {
>>          this.beanRegistry = beanRegistry;
>>          introspector = new JavaClassIntrospectorImpl(visitors);
>>      }
>> @@ -55,6 +58,18 @@
>>          JavaImplementation javaImplementation =
>> createJavaImplementation();
>>          introspector.introspectClass(javaImplementation,
>> implementationClass);
>>          return javaImplementation;
>> +    }
>> +
>> +    public void addClassVisitor(JavaClassVisitor visitor) {
>> +        visitors.add(visitor);
>> +    }
>> +
>> +    public void removeClassVisitor(JavaClassVisitor visitor) {
>> +        visitors.remove(visitor);
>> +    }
>> +
>> +    public List<JavaClassVisitor> getClassVisitors() {
>> +        return visitors;
>>      }
>>
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/databinding-jaxb/src/main/java/org/apache/tuscany/sca/databinding/jaxb/module/JAXBDataBindingModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -32,10 +32,6 @@
>>   */
>> public class JAXBDataBindingModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>          ModelFactoryExtensionPoint modelFactories =
>> registry.getExtensionPoint(ModelFactoryExtensionPoint.class);
>>          JavaInterfaceFactory javaFactory = modelFactories.getFactory(
>> JavaInterfaceFactory.class);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/module/SDODataBindingModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -24,31 +24,18 @@
>> import
>> org.apache.tuscany.sca.contribution.processor.StAXArtifactProcessorExtensionPoint
>> ;
>> import org.apache.tuscany.sca.core.ExtensionPointRegistry;
>> import org.apache.tuscany.sca.core.ModuleActivator;
>> -import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
>> -import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
>> -import org.apache.tuscany.sca.databinding.sdo.DataObject2String;
>> -import org.apache.tuscany.sca.databinding.sdo.DataObject2XMLStreamReader;
>> import org.apache.tuscany.sca.databinding.sdo.HelperContextProcessor;
>> import org.apache.tuscany.sca.databinding.sdo.HelperContextRegistry;
>> import org.apache.tuscany.sca.databinding.sdo.HelperContextRegistryImpl;
>> import org.apache.tuscany.sca.databinding.sdo.ImportSDOProcessor;
>> -import org.apache.tuscany.sca.databinding.sdo.SDODataBinding;
>> -import org.apache.tuscany.sca.databinding.sdo.String2DataObject;
>> -import org.apache.tuscany.sca.databinding.sdo.XMLDocument2String;
>> -import org.apache.tuscany.sca.databinding.sdo.XMLDocument2XMLStreamReader
>> ;
>> -import org.apache.tuscany.sca.databinding.sdo.XMLStreamReader2DataObject;
>> -import org.apache.tuscany.sca.databinding.sdo.XMLStreamReader2XMLDocument
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> +import org.apache.tuscany.sca.databinding.sdo.SDOTypeRegisterListener;
>> +import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>>
>> /**
>>   * @version $Rev$ $Date$
>>   */
>> public class SDODataBindingModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
>> (ModelFactoryExtensionPoint.class);
>>          AssemblyFactory assemblyFactory = factories.getFactory(
>> AssemblyFactory.class);
>> @@ -60,8 +47,8 @@
>>          //ContributionListenerExtensionPoint listeners =
>> registry.getExtensionPoint(ContributionListenerExtensionPoint.class);
>>          //listeners.addContributionListener(new
>> SDOTypeRegisterListener(contextRegistry));
>>
>> -        JavaClassIntrospectorExtensionPoint introspectors =
>> registry.getExtensionPoint(JavaClassIntrospectorExtensionPoint.class);
>> -        introspectors.addClassVisitor(new
>> HelperContextProcessor(assemblyFactory, contextRegistry));
>> +        JavaImplementationFactory javaImplementationFactory =
>> registry.getExtensionPoint(JavaImplementationFactory.class);
>> +        javaImplementationFactory.addClassVisitor(new
>> HelperContextProcessor(assemblyFactory, contextRegistry));
>>
>>      }
>>
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/databinding-sdo/src/test/java/org/apache/tuscany/sca/databinding/sdo/HelperContextProcessorTestCase.java
>> Thu Aug  9 16:49:11 2007
>> @@ -29,7 +29,6 @@
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> import org.apache.tuscany.sca.implementation.java.impl.JavaResourceImpl;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>>
>> import commonj.sdo.helper.HelperContext;
>>
>> @@ -43,7 +42,7 @@
>>          HelperContextRegistry registry = new HelperContextRegistryImpl();
>>          HelperContextProcessor processor = new HelperContextProcessor(new
>> DefaultAssemblyFactory(), registry);
>>
>> -        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory(new
>> DefaultJavaClassIntrospectorExtensionPoint());
>> +        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory();
>>          JavaImplementation componentType =
>> javaImplementationFactory.createJavaImplementation();
>>          componentType.setJavaClass(FooImpl.class);
>>          for (Field f : FooImpl.class.getDeclaredFields()) {
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/DefaultTransformerExtensionPoint.java
>> Thu Aug  9 16:49:11 2007
>> @@ -33,7 +33,6 @@
>>   * @version $Rev$ $Date$
>>   */
>> public class DefaultTransformerExtensionPoint implements
>> TransformerExtensionPoint {
>> -    private DataBindingExtensionPoint dataBindings;
>>      private boolean loadedTransformers;
>>
>>      private final DirectedGraph<Object, Transformer> graph = new
>> DirectedGraph<Object, Transformer>();
>> @@ -41,11 +40,6 @@
>>      public DefaultTransformerExtensionPoint() {
>>      }
>>
>> -    //FIXME Hack
>> -    public void setDataBindings(DataBindingExtensionPoint dataBindings) {
>> -        this.dataBindings = dataBindings;
>> -    }
>> -
>>      public void addTransformer(String sourceType, String resultType, int
>> weight, Transformer transformer) {
>>          graph.addEdge(sourceType, resultType, transformer, weight);
>>      }
>> @@ -122,8 +116,8 @@
>>      public List<Transformer> getTransformerChain(String sourceType,
>> String resultType) {
>>          loadTransformers();
>>
>> -        String source = normalize(sourceType);
>> -        String result = normalize(resultType);
>> +        String source = sourceType;
>> +        String result = resultType;
>>          List<Transformer> transformers = new ArrayList<Transformer>();
>>          DirectedGraph<Object, Transformer>.Path path =
>> graph.getShortestPath(source, result);
>>          if (path == null) {
>> @@ -139,22 +133,6 @@
>>          loadTransformers();
>>
>>          return graph.toString();
>> -    }
>> -
>> -    /**
>> -     * Normalize the id to a name of a data binding as databindings may
>> have aliases
>> -     * @param id
>> -     * @return
>> -     */
>> -    private String normalize(String id) {
>> -        loadTransformers();
>> -
>> -        if (dataBindings != null) {
>> -            DataBinding dataBinding = dataBindings.getDataBinding(id);
>> -            return dataBinding == null ? id : dataBinding.getName();
>> -        } else {
>> -            return id;
>> -        }
>>      }
>>
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
>> Thu Aug  9 16:49:11 2007
>> @@ -253,12 +253,6 @@
>>                  Class moduleClass = Class.forName(className, true,
>> classLoader);
>>                  ModuleActivator module =
>> (ModuleActivator)moduleClass.newInstance();
>>                  modules.add(module);
>> -                Object[] extensionPoints = module.getExtensionPoints();
>> -                if (extensionPoints != null) {
>> -                    for (Object e : extensionPoints) {
>> -                        registry.addExtensionPoint(e);
>> -                    }
>> -                }
>>              }
>>          } catch (IOException e) {
>>              throw new ActivationException(e);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/BindingsActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -140,10 +140,6 @@
>>          return new QName(Constants.SCA10_NS, "binding." + sb.toString());
>>      }
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null; // not used by binding or implementation extensions
>> -    }
>> -
>>      private final class DelegatingBindingProviderFactory implements
>> BindingProviderFactory {
>>          private Class modelType;
>>
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -133,8 +133,4 @@
>>          return new QName(Constants.SCA10_NS, "implementation." +
>> sb.toString());
>>      }
>>
>> -
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntime.java
>> Thu Aug  9 16:49:11 2007
>> @@ -53,15 +53,6 @@
>> import org.apache.tuscany.sca.core.runtime.CompositeActivator;
>> import org.apache.tuscany.sca.core.runtime.RuntimeAssemblyFactory;
>> import org.apache.tuscany.sca.core.work.ThreadPoolWorkManager;
>> -import org.apache.tuscany.sca.databinding.DataBinding;
>> -import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
>> -import org.apache.tuscany.sca.databinding.PullTransformer;
>> -import org.apache.tuscany.sca.databinding.PushTransformer;
>> -import org.apache.tuscany.sca.databinding.Transformer;
>> -import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
>> -import org.apache.tuscany.sca.databinding.impl.LazyDataBinding;
>> -import org.apache.tuscany.sca.databinding.impl.LazyPullTransformer;
>> -import org.apache.tuscany.sca.databinding.impl.LazyPushTransformer;
>> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
>> import
>> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
>> import org.apache.tuscany.sca.interfacedef.impl.TempServiceDeclarationUtil
>> ;
>> @@ -212,12 +203,6 @@
>>                  Class moduleClass = Class.forName(className, true,
>> classLoader);
>>                  ModuleActivator module =
>> (ModuleActivator)moduleClass.newInstance();
>>                  modules.add(module);
>> -                Object[] extensionPoints = module.getExtensionPoints();
>> -                if (extensionPoints != null) {
>> -                    for (Object e : extensionPoints) {
>> -                        registry.addExtensionPoint(e);
>> -                    }
>> -                }
>>              }
>>          } catch (IOException e) {
>>              throw new ActivationException(e);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-embedded/src/test/java/crud/module/CRUDModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -43,12 +43,6 @@
>>   */
>> public class CRUDModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        // This module extension does not contribute any new
>> -        // extension point
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>
>>          // Create the CRUD implementation factory
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-http/src/main/java/org/apache/tuscany/sca/http/ExtensibleServletHost.java
>> Thu Aug  9 16:49:11 2007
>> @@ -19,9 +19,6 @@
>>
>> package org.apache.tuscany.sca.http;
>>
>> -import java.util.ArrayList;
>> -import java.util.List;
>> -
>> import javax.servlet.Servlet;
>>
>> /**
>> @@ -32,14 +29,12 @@
>> public class ExtensibleServletHost implements ServletHost {
>>
>>      private ServletHostExtensionPoint servletHosts;
>> -    private List<String> uriList = new ArrayList<String>();
>>
>>      public ExtensibleServletHost(ServletHostExtensionPoint servletHosts)
>> {
>>          this.servletHosts = servletHosts;
>>      }
>>
>>      public void addServletMapping(String uri, Servlet servlet) throws
>> ServletMappingException {
>> -        uriList.add(uri);
>>          if (servletHosts.getServletHosts().isEmpty()) {
>>              throw new ServletMappingException("No servlet host
>> available");
>>          }
>> @@ -50,20 +45,9 @@
>>      }
>>
>>      public Servlet removeServletMapping(String uri) throws
>> ServletMappingException {
>> -        uriList.remove(uri);
>>          // TODO implement selection of the correct servlet host based on
>> the mapping
>>          // For now just select the first one
>>          return servletHosts.getServletHosts
>> ().get(0).removeServletMapping(uri);
>>      }
>>
>> -    /**
>> -     * For debugging purposes this returns the list of URI strings
>> -     * that have been passed in
>> -     *
>> -     * @return the string uri list
>> -     */
>> -    public List<String> getURIList(){
>> -        return uriList;
>> -    }
>> -
>> }
>>
>> Copied:
>> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
>> (from r564365,
>> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator)
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint?view=diff&rev=564429&p1=incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator&r1=564365&p2=incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-http/src/main/resources/META-INF/services/org.apache.tuscany.sca.http.ServletHostExtensionPoint
>> Thu Aug  9 16:49:11 2007
>> @@ -14,5 +14,5 @@
>> # KIND, either express or implied.  See the License for the
>> # specific language governing permissions and limitations
>> # under the License.
>> -# Implementation class for the ModuleActivator
>> -org.apache.tuscany.sca.http.module.HTTPRuntimeModuleActivator
>> +
>> +org.apache.tuscany.sca.http.DefaultServletHostExtensionPoint
>>
>> Added:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java?view=auto&rev=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>> (added)
>> +++
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>> Thu Aug  9 16:49:11 2007
>> @@ -0,0 +1,49 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one
>> + * or more contributor license agreements.  See the NOTICE file
>> + * distributed with this work for additional information
>> + * regarding copyright ownership.  The ASF licenses this file
>> + * to you under the Apache License, Version 2.0 (the
>> + * "License"); you may not use this file except in compliance
>> + * with the License.  You may obtain a copy of the License at
>> + *
>> + *   http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing,
>> + * software distributed under the License is distributed on an
>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> + * KIND, either express or implied.  See the License for the
>> + * specific language governing permissions and limitations
>> + * under the License.
>> + */
>> +
>> +package org.apache.tuscany.sca.rmi;
>> +
>> +import java.util.ArrayList;
>> +import java.util.List;
>> +
>> +/**
>> + * Default implementation of an RMI host extension point.
>> + *
>> + * @version $Rev$ $Date$
>> + */
>> +public class DefaultRMIHostExtensionPoint implements
>> RMIHostExtensionPoint {
>> +
>> +    private List<RMIHost> rmiHosts = new ArrayList<RMIHost>();
>> +
>> +    public DefaultRMIHostExtensionPoint() {
>> +        addRMIHost(new DefaultRMIHost());
>> +    }
>> +
>> +    public void addRMIHost(RMIHost rmiHost) {
>> +        rmiHosts.add(rmiHost);
>> +    }
>> +
>> +    public void removeRMIHost(RMIHost rmiHost) {
>> +        rmiHosts.remove(rmiHost);
>> +    }
>> +
>> +    public List<RMIHost> getRMIHosts() {
>> +        return rmiHosts;
>> +    }
>> +}
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>>
>> ------------------------------------------------------------------------------
>>     svn:eol-style = native
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/DefaultRMIHostExtensionPoint.java
>>
>> ------------------------------------------------------------------------------
>>     svn:keywords = Rev Date
>>
>> Added:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java?view=auto&rev=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>> (added)
>> +++
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>> Thu Aug  9 16:49:11 2007
>> @@ -0,0 +1,73 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one
>> + * or more contributor license agreements.  See the NOTICE file
>> + * distributed with this work for additional information
>> + * regarding copyright ownership.  The ASF licenses this file
>> + * to you under the Apache License, Version 2.0 (the
>> + * "License"); you may not use this file except in compliance
>> + * with the License.  You may obtain a copy of the License at
>> + *
>> + *   http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing,
>> + * software distributed under the License is distributed on an
>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> + * KIND, either express or implied.  See the License for the
>> + * specific language governing permissions and limitations
>> + * under the License.
>> + */
>> +
>> +package org.apache.tuscany.sca.rmi;
>> +
>> +import java.rmi.Remote;
>> +
>> +
>> +/**
>> + * Default implementation of an extensible servlet host.
>> + *
>> + * @version $Rev$ $Date$
>> + */
>> +public class ExtensibleRMIHost implements RMIHost {
>> +
>> +    private RMIHostExtensionPoint rmiHosts;
>> +
>> +    public ExtensibleRMIHost(RMIHostExtensionPoint rmiHosts) {
>> +        this.rmiHosts = rmiHosts;
>> +    }
>> +
>> +    public void registerService(String serviceName, int port, Remote
>> serviceObject) throws RMIHostException, RMIHostRuntimeException {
>> +        if (rmiHosts.getRMIHosts().isEmpty()) {
>> +            throw new RMIHostException("No RMI host available");
>> +        }
>> +        rmiHosts.getRMIHosts().get(0).registerService(serviceName, port,
>> serviceObject);
>> +    }
>> +
>> +    public Remote findService(String host, String port, String svcName)
>> throws RMIHostException, RMIHostRuntimeException {
>> +        if (rmiHosts.getRMIHosts().isEmpty()) {
>> +            throw new RMIHostException("No RMI host available");
>> +        }
>> +        return rmiHosts.getRMIHosts().get(0).findService(host, port,
>> svcName);
>> +    }
>> +
>> +    public void registerService(String serviceName, Remote serviceObject)
>> throws RMIHostException, RMIHostRuntimeException {
>> +        if (rmiHosts.getRMIHosts().isEmpty()) {
>> +            throw new RMIHostException("No RMI host available");
>> +        }
>> +        rmiHosts.getRMIHosts().get(0).registerService(serviceName,
>> serviceObject);
>> +    }
>> +
>> +    public void unregisterService(String serviceName) throws
>> RMIHostException, RMIHostRuntimeException {
>> +        if (rmiHosts.getRMIHosts().isEmpty()) {
>> +            throw new RMIHostException("No RMI host available");
>> +        }
>> +        rmiHosts.getRMIHosts().get(0).unregisterService(serviceName);
>> +    }
>> +
>> +    public void unregisterService(String serviceName, int port) throws
>> RMIHostException, RMIHostRuntimeException {
>> +        if (rmiHosts.getRMIHosts().isEmpty()) {
>> +            throw new RMIHostException("No RMI host available");
>> +        }
>> +        rmiHosts.getRMIHosts().get(0).unregisterService(serviceName,
>> port);
>> +    }
>> +
>> +}
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>>
>> ------------------------------------------------------------------------------
>>     svn:eol-style = native
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/ExtensibleRMIHost.java
>>
>> ------------------------------------------------------------------------------
>>     svn:keywords = Rev Date
>>
>> Added:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java?view=auto&rev=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>> (added)
>> +++
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>> Thu Aug  9 16:49:11 2007
>> @@ -0,0 +1,51 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one
>> + * or more contributor license agreements.  See the NOTICE file
>> + * distributed with this work for additional information
>> + * regarding copyright ownership.  The ASF licenses this file
>> + * to you under the Apache License, Version 2.0 (the
>> + * "License"); you may not use this file except in compliance
>> + * with the License.  You may obtain a copy of the License at
>> + *
>> + *   http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing,
>> + * software distributed under the License is distributed on an
>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> + * KIND, either express or implied.  See the License for the
>> + * specific language governing permissions and limitations
>> + * under the License.
>> + */
>> +package org.apache.tuscany.sca.rmi;
>> +
>> +import java.util.List;
>> +
>> +/**
>> + * An extension point for RMI hosts.
>> + *
>> + * @version $Rev$ $Date$
>> + */
>> +public interface RMIHostExtensionPoint {
>> +
>> +    /**
>> +     * Adds a servlet host extension.
>> +     *
>> +     * @param rmiHost
>> +     */
>> +    void addRMIHost(RMIHost rmiHost);
>> +
>> +    /**
>> +     * Removes a servlet host extension.
>> +     *
>> +     * @param rmiHost
>> +     */
>> +    void removeRMIHost(RMIHost rmiHost);
>> +
>> +    /**
>> +     * Returns a list of servlet host extensions.
>> +     *
>> +     * @return
>> +     */
>> +    List<RMIHost> getRMIHosts();
>> +
>> +}
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>>
>> ------------------------------------------------------------------------------
>>     svn:eol-style = native
>>
>> Propchange:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/java/org/apache/tuscany/sca/rmi/RMIHostExtensionPoint.java
>>
>> ------------------------------------------------------------------------------
>>     svn:keywords = Rev Date
>>
>> Copied:
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
>> (from r564365,
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator)
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint?view=diff&rev=564429&p1=incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator&r1=564365&p2=incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.core.ModuleActivator
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-rmi/src/main/resources/META-INF/services/org.apache.tuscany.sca.rmi.RMIHostExtensionPoint
>> Thu Aug  9 16:49:11 2007
>> @@ -14,5 +14,5 @@
>> # KIND, either express or implied.  See the License for the
>> # specific language governing permissions and limitations
>> # under the License.
>> -# Implementation class for the ModuleActivator
>> -org.apache.tuscany.sca.rmi.module.RMIRuntimeModuleActivator
>> +
>> +org.apache.tuscany.sca.rmi.DefaultRMIHostExtensionPoint
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/host-webapp/src/main/java/org/apache/tuscany/sca/webapp/WebAppModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -39,8 +39,4 @@
>>      public void stop(ExtensionPointRegistry registry) {
>>      }
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/http-jetty/src/main/java/org/apache/tuscany/sca/http/jetty/module/JettyRuntimeModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -32,10 +32,6 @@
>>
>>      private JettyServer server;
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry extensionPointRegistry) {
>>
>>          // Register a Jetty servlet host
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/http-tomcat/src/main/java/org/apache/tuscany/sca/http/tomcat/module/TomcatRuntimeModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -32,10 +32,6 @@
>>
>>      private TomcatServer server;
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry extensionPointRegistry) {
>>
>>          // Register a Tomcat servlet host
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/module/JavaRuntimeModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -30,11 +30,8 @@
>> import org.apache.tuscany.sca.databinding.DataBindingExtensionPoint;
>> import org.apache.tuscany.sca.databinding.TransformerExtensionPoint;
>> import org.apache.tuscany.sca.databinding.impl.MediatorImpl;
>> -import
>> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> import
>> org.apache.tuscany.sca.implementation.java.context.JavaPropertyValueObjectFactory
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
>> ;
>> @@ -55,7 +52,6 @@
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.ServiceProcessor
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.invocation.CglibProxyFactory;
>> import
>> org.apache.tuscany.sca.implementation.java.invocation.JavaImplementationProviderFactory
>> ;
>> -import
>> org.apache.tuscany.sca.interfacedef.java.DefaultJavaInterfaceFactory;
>> import org.apache.tuscany.sca.interfacedef.java.JavaInterfaceFactory;
>> import org.apache.tuscany.sca.invocation.MessageFactory;
>> import org.apache.tuscany.sca.policy.PolicyFactory;
>> @@ -66,17 +62,10 @@
>>   */
>> public class JavaRuntimeModuleActivator implements ModuleActivator {
>>
>> -    private JavaClassIntrospectorExtensionPoint classVisitors;
>> -
>>      public JavaRuntimeModuleActivator() {
>>      }
>>
>>
>> -    public Object[] getExtensionPoints() {
>> -        classVisitors = new DefaultJavaClassIntrospectorExtensionPoint();
>> -        return new Object[] { classVisitors };
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>
>>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
>> (ModelFactoryExtensionPoint.class);
>> @@ -88,6 +77,7 @@
>>          proxyFactory.setClassProxyFactory(new
>> CglibProxyFactory(messageFactory, proxyFactory.getInterfaceContractMapper
>> ()));
>>
>>          JavaInterfaceFactory javaFactory = factories.getFactory(
>> JavaInterfaceFactory.class);
>> +        JavaImplementationFactory javaImplementationFactory =
>> factories.getFactory(JavaImplementationFactory.class);
>>
>>          BaseJavaClassVisitor[] extensions = new BaseJavaClassVisitor[] {
>>              new ConstructorProcessor(assemblyFactory),
>> @@ -108,16 +98,13 @@
>>              new PolicyProcessor(assemblyFactory, policyFactory)
>>          };
>>          for (JavaClassVisitor extension : extensions) {
>> -            classVisitors.addClassVisitor(extension);
>> +            javaImplementationFactory.addClassVisitor(extension);
>>          }
>>
>>          DataBindingExtensionPoint dataBindings =
>> registry.getExtensionPoint(DataBindingExtensionPoint.class);
>>          TransformerExtensionPoint transformers =
>> registry.getExtensionPoint(TransformerExtensionPoint.class);
>>          MediatorImpl mediator =new MediatorImpl(dataBindings,
>> transformers);
>>          JavaPropertyValueObjectFactory factory = new
>> JavaPropertyValueObjectFactory(mediator);
>> -
>> -        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory(classVisitors);
>> -        factories.addFactory(javaImplementationFactory);
>>
>>          ContextFactoryExtensionPoint contextFactories =
>> registry.getExtensionPoint(ContextFactoryExtensionPoint.class);
>>          ComponentContextFactory componentContextFactory =
>> contextFactories.getFactory(ComponentContextFactory.class);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/ReadTestCase.java
>> Thu Aug  9 16:49:11 2007
>> @@ -42,7 +42,6 @@
>> import org.apache.tuscany.sca.contribution.resolver.ModelResolver;
>> import
>> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
>> import
>> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
>> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
>> @@ -75,7 +74,7 @@
>>          staxProcessors = new
>> DefaultStAXArtifactProcessorExtensionPoint();
>>          staxProcessor = new
>> ExtensibleStAXArtifactProcessor(staxProcessors,
>> XMLInputFactory.newInstance(), XMLOutputFactory.newInstance());
>>
>> -        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory(new
>> DefaultJavaClassIntrospectorExtensionPoint());
>> +        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory();
>>          modelFactories.addFactory(javaImplementationFactory);
>>
>>          CompositeProcessor compositeProcessor = new
>> CompositeProcessor(new ContributionFactoryImpl(), assemblyFactory,
>> policyFactory, mapper, staxProcessor);
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java-xml/src/test/java/org/apache/tuscany/sca/implementation/java/xml/WriteTestCase.java
>> Thu Aug  9 16:49:11 2007
>> @@ -39,7 +39,6 @@
>> import
>> org.apache.tuscany.sca.contribution.processor.ExtensibleStAXArtifactProcessor
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> import org.apache.tuscany.sca.interfacedef.InterfaceContractMapper;
>> import
>> org.apache.tuscany.sca.interfacedef.impl.InterfaceContractMapperImpl;
>> import org.apache.tuscany.sca.policy.DefaultPolicyFactory;
>> @@ -70,7 +69,7 @@
>>          staxProcessors = new
>> DefaultStAXArtifactProcessorExtensionPoint();
>>          staxProcessor = new
>> ExtensibleStAXArtifactProcessor(staxProcessors,
>> XMLInputFactory.newInstance(), XMLOutputFactory.newInstance());
>>
>> -        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory(new
>> DefaultJavaClassIntrospectorExtensionPoint());
>> +        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory();
>>          modelFactories.addFactory(javaImplementationFactory);
>>
>>          staxProcessors.addArtifactProcessor(new CompositeProcessor(null,
>> factory, policyFactory, mapper, staxProcessor));
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/DefaultJavaImplementationFactory.java
>> Thu Aug  9 16:49:11 2007
>> @@ -22,20 +22,10 @@
>>   * A factory for the Java model.
>>   */
>> import
>> org.apache.tuscany.sca.implementation.java.impl.JavaImplementationFactoryImpl
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>>
>> public class DefaultJavaImplementationFactory extends
>> JavaImplementationFactoryImpl implements JavaImplementationFactory {
>>
>> -    /**
>> -     * @deprecated Please use the constructor that takes a
>> JavaClassIntrospectorExtensionPoint.
>> -     */
>>      public DefaultJavaImplementationFactory() {
>> -        super(new DefaultJavaClassIntrospectorExtensionPoint());
>> -    }
>> -
>> -    public
>> DefaultJavaImplementationFactory(JavaClassIntrospectorExtensionPoint
>> visitors) {
>> -        super(visitors);
>>      }
>>
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/JavaImplementationFactory.java
>> Thu Aug  9 16:49:11 2007
>> @@ -18,6 +18,10 @@
>>   */
>> package org.apache.tuscany.sca.implementation.java;
>>
>> +import java.util.List;
>> +
>> +import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> +
>>
>> /**
>>   * Factory for the Java model
>> @@ -48,5 +52,24 @@
>>       * @return
>>       */
>>      void createJavaImplementation(JavaImplementation javaImplementation,
>> Class<?> implementationClass) throws IntrospectionException;
>> +
>> +    /**
>> +     * Registers the given visitor.
>> +     *
>> +     * @param visitor
>> +     */
>> +    void addClassVisitor(JavaClassVisitor visitor);
>> +
>> +    /**
>> +     * Deregisters the given visitor.
>> +     */
>> +    void removeClassVisitor(JavaClassVisitor visitor);
>> +
>> +    /**
>> +     * Returns the list of visitors.
>> +     *
>> +     * @return
>> +     */
>> +    List<JavaClassVisitor> getClassVisitors();
>>
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaClassIntrospectorImpl.java
>> Thu Aug  9 16:49:11 2007
>> @@ -26,7 +26,6 @@
>>
>> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.JavaIntrospectionHelper
>> ;
>>
>> @@ -39,8 +38,8 @@
>>
>>      private List<JavaClassVisitor> visitors;
>>
>> -    public JavaClassIntrospectorImpl(JavaClassIntrospectorExtensionPoint
>> visitors) {
>> -        this.visitors = visitors.getClassVisitors();
>> +    public JavaClassIntrospectorImpl(List<JavaClassVisitor> visitors) {
>> +        this.visitors = visitors;
>>      }
>>
>>      /**
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/impl/JavaImplementationFactoryImpl.java
>> Thu Aug  9 16:49:11 2007
>> @@ -21,16 +21,20 @@
>> /**
>>   * A factory for the Java model.
>>   */
>> +import java.util.ArrayList;
>> +import java.util.List;
>> +
>> import org.apache.tuscany.sca.implementation.java.IntrospectionException;
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> +import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>>
>> public abstract class JavaImplementationFactoryImpl implements
>> JavaImplementationFactory {
>>
>> +    private List<JavaClassVisitor> visitors = new
>> ArrayList<JavaClassVisitor>();
>>      private JavaClassIntrospectorImpl introspector;
>>
>> -    public
>> JavaImplementationFactoryImpl(JavaClassIntrospectorExtensionPoint visitors)
>> {
>> +    public JavaImplementationFactoryImpl() {
>>          introspector = new JavaClassIntrospectorImpl(visitors);
>>      }
>>
>> @@ -47,6 +51,18 @@
>>
>>      public void createJavaImplementation(JavaImplementation
>> javaImplementation, Class<?> implementationClass) throws
>> IntrospectionException {
>>          introspector.introspectClass(javaImplementation,
>> implementationClass);
>> +    }
>> +
>> +    public void addClassVisitor(JavaClassVisitor visitor) {
>> +        visitors.add(visitor);
>> +    }
>> +
>> +    public void removeClassVisitor(JavaClassVisitor visitor) {
>> +        visitors.remove(visitor);
>> +    }
>> +
>> +    public List<JavaClassVisitor> getClassVisitors() {
>> +        return visitors;
>>      }
>>
>> }
>>
>> Added:
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory?view=auto&rev=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
>> (added)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/main/resources/META-INF/services/org.apache.tuscany.sca.implementation.java.JavaImplementationFactory
>> Thu Aug  9 16:49:11 2007
>> @@ -0,0 +1,18 @@
>> +# Licensed to the Apache Software Foundation (ASF) under one
>> +# or more contributor license agreements.  See the NOTICE file
>> +# distributed with this work for additional information
>> +# regarding copyright ownership.  The ASF licenses this file
>> +# to you under the Apache License, Version 2.0 (the
>> +# "License"); you may not use this file except in compliance
>> +# with the License.  You may obtain a copy of the License at
>> +#
>> +#   http://www.apache.org/licenses/LICENSE-2.0
>> +#
>> +# Unless required by applicable law or agreed to in writing,
>> +# software distributed under the License is distributed on an
>> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> +# KIND, either express or implied.  See the License for the
>> +# specific language governing permissions and limitations
>> +# under the License.
>> +
>>
>> +org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/JavaClassIntrospectorImplTestCase.java
>> Thu Aug  9 16:49:11 2007
>> @@ -27,7 +27,6 @@
>> import
>> org.apache.tuscany.sca.implementation.java.DefaultJavaImplementationFactory
>> ;
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import org.easymock.EasyMock;
>>
>> @@ -37,21 +36,21 @@
>> public class JavaClassIntrospectorImplTestCase extends TestCase {
>>
>>      public void testRegister() throws Exception {
>> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
>> DefaultJavaClassIntrospectorExtensionPoint();
>> +        JavaImplementationFactory factory = new
>> DefaultJavaImplementationFactory();
>>          JavaClassVisitor extension = EasyMock.createNiceMock(
>> JavaClassVisitor.class);
>> -        visitors.addClassVisitor(extension);
>> +        factory.addClassVisitor(extension);
>>      }
>>
>>      public void testUnegister() throws Exception {
>> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
>> DefaultJavaClassIntrospectorExtensionPoint();
>> +        JavaImplementationFactory factory = new
>> DefaultJavaImplementationFactory();
>>          JavaClassVisitor extension = EasyMock.createNiceMock(
>> JavaClassVisitor.class);
>> -        visitors.addClassVisitor(extension);
>> -        visitors.removeClassVisitor(extension);
>> +        factory.addClassVisitor(extension);
>> +        factory.removeClassVisitor(extension);
>>      }
>>
>>      @SuppressWarnings("unchecked")
>>      public void testWalk() throws Exception {
>> -        DefaultJavaClassIntrospectorExtensionPoint visitors = new
>> DefaultJavaClassIntrospectorExtensionPoint();
>> +        JavaImplementationFactory factory = new
>> DefaultJavaImplementationFactory();
>>          JavaClassVisitor extension = EasyMock.createMock(
>> JavaClassVisitor.class);
>>          extension.visitClass(EasyMock.eq(Bar.class), EasyMock.isA(
>> JavaImplementation.class));
>>          extension.visitConstructor(EasyMock.isA(Constructor.class),
>> EasyMock.isA(JavaImplementation.class));
>> @@ -67,9 +66,8 @@
>>          // mock.expects(once()).method("visitSuperClass");
>>          // mock.expects(once()).method("visitEnd");
>>          EasyMock.replay(extension);
>> -        visitors.addClassVisitor(extension);
>> -        JavaImplementationFactory javaImplementationFactory = new
>> DefaultJavaImplementationFactory(visitors);
>> -        javaImplementationFactory.createJavaImplementation(
>> javaImplementationFactory.createJavaImplementation(), Bar.class);
>> +        factory.addClassVisitor(extension);
>> +        factory.createJavaImplementation(Bar.class);
>>          EasyMock.verify(extension);
>>      }
>>
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-notification/src/main/java/org/apache/tuscany/sca/implementation/notification/NotificationModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -46,7 +46,4 @@
>>          processors.removeArtifactProcessor(implementationLoader);
>>      }
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> }
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/implementation-spring/src/main/java/org/apache/tuscany/sca/implementation/spring/xml/SpringBeanIntrospector.java
>> Thu Aug  9 16:49:11 2007
>> @@ -30,8 +30,6 @@
>> import org.apache.tuscany.sca.implementation.java.JavaImplementation;
>> import
>> org.apache.tuscany.sca.implementation.java.JavaImplementationFactory;
>> import org.apache.tuscany.sca.implementation.java.impl.JavaElementImpl;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.DefaultJavaClassIntrospectorExtensionPoint
>> ;
>> -import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassIntrospectorExtensionPoint
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.JavaClassVisitor;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.AllowsPassByReferenceProcessor
>> ;
>> import
>> org.apache.tuscany.sca.implementation.java.introspect.impl.BaseJavaClassVisitor
>> ;
>> @@ -60,7 +58,6 @@
>>   */
>> public class SpringBeanIntrospector {
>>
>> -    private JavaClassIntrospectorExtensionPoint classVisitors = new
>> DefaultJavaClassIntrospectorExtensionPoint();
>>      private JavaImplementationFactory javaImplementationFactory;
>>
>>      /**
>> @@ -74,6 +71,8 @@
>>                                    JavaInterfaceFactory javaFactory,
>>                                    PolicyFactory policyFactory) {
>>
>> +        javaImplementationFactory = new
>> DefaultJavaImplementationFactory();
>> +
>>          // Create the list of class visitors
>>          BaseJavaClassVisitor[] extensions =
>>              new BaseJavaClassVisitor[] {
>> @@ -93,10 +92,8 @@
>>                                          new
>> HeuristicPojoProcessor(assemblyFactory, javaFactory),
>>                                          new
>> PolicyProcessor(assemblyFactory, policyFactory)};
>>          for (JavaClassVisitor extension : extensions) {
>> -            classVisitors.addClassVisitor(extension);
>> +            javaImplementationFactory.addClassVisitor(extension);
>>          }
>> -
>> -        javaImplementationFactory = new
>> DefaultJavaImplementationFactory(classVisitors);
>>
>>      } // end constructor
>>
>>
>> Modified:
>> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/modules/interface-wsdl-runtime/src/main/java/org/apache/tuscany/sca/interfacedef/wsdl/module/WSDLInterfaceRuntimeModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -32,10 +32,6 @@
>>   */
>> public class WSDLInterfaceRuntimeModuleActivator implements
>> ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>
>>          ModelResolverExtensionPoint resolvers =
>> registry.getExtensionPoint(ModelResolverExtensionPoint.class);
>>
>> Modified:
>> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/samples/binding-echo-extension/src/main/java/echo/module/EchoModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -36,11 +36,6 @@
>>   */
>> public class EchoModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        // No extensionPoints being contributed here
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>
>>          ModelFactoryExtensionPoint factories = registry.getExtensionPoint
>> (ModelFactoryExtensionPoint.class);
>>
>> Modified:
>> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java?view=diff&rev=564429&r1=564428&r2=564429
>>
>> ==============================================================================
>> ---
>> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
>> (original)
>> +++
>> incubator/tuscany/java/sca/samples/implementation-crud-extension/src/main/java/crud/module/CRUDModuleActivator.java
>> Thu Aug  9 16:49:11 2007
>> @@ -41,11 +41,6 @@
>>   */
>> public class CRUDModuleActivator implements ModuleActivator {
>>
>> -    public Object[] getExtensionPoints() {
>> -        // This module extension does not contribute any new extension
>> point
>> -        return null;
>> -    }
>> -
>>      public void start(ExtensionPointRegistry registry) {
>>
>>          // Create the CRUD implementation factory
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>>
>>
>>     
>
>   


-- 
Jean-Sebastien


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org