You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/06/12 11:58:28 UTC

[GitHub] [buildstream] gtristan commented on pull request #1655: source.py: Don't ignore project.refs of subprojects

gtristan commented on PR #1655:
URL: https://github.com/apache/buildstream/pull/1655#issuecomment-1153142081

   Right, I gave more thought to this patch and it makes more sense to me now.
   
   * We can **not** write to `project.refs` in subprojects when tracking new refs (we can only track them in the toplevel, if the toplevel uses `project.refs`)
   * We **can** read the `project.refs` _from subprojects_
   * We **still** prioritize local `project.refs` in the toplevel if they exist when _reading_ refs for subproject elements


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org