You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/26 22:01:54 UTC
[GitHub] [lucene] gsmiller opened a new pull request #48: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3)
gsmiller opened a new pull request #48:
URL: https://github.com/apache/lucene/pull/48
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene:
* https://issues.apache.org/jira/browse/LUCENE-9877
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This change allows PForUtil to encode up to 7 exceptions per encoded block (instead of the 3 allowed today) in order to reduce index size.
# Solution
I tested the impact of 7 exceptions vs. 3 using a new tool I wrote to directly inspect the contents of PFOR encoded index blocks (details in the Jira) as well as inspected overall index size reduction. I also tested QPS impact using luceneutil benchmark tools. All details are in the Jira issue.
Note that this change should be fully backwards compatible, even though I don't think that needs to be a requirement. Details of this are also mentioned in the Jira issue.
# Tests
All existing tests pass. No new tests seemed necessary as TestPForUtil already exercises the code.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #48: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3)
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #48:
URL: https://github.com/apache/lucene/pull/48#issuecomment-809630728
Thanks @jpountz. I updated CHANGES.txt just now. As for updating 8.x, I'm a bit naive on how to go about suggesting that change. The change is backwards-compatible so this should be possible. I think this would involve opening an PR against the old repo and then also updating the backwards_codecs version of PForUtil in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #48: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3)
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #48:
URL: https://github.com/apache/lucene/pull/48#issuecomment-810205059
I've opened a separate [PR](https://github.com/apache/lucene-solr/pull/2474) to backport this into branch_8x as well since it's fully backwards compatible. I updated this PR to also include the change in "backwards_codecs", assuming that we want to backport. If we decide not to, I can remove that change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #48: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3)
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #48:
URL: https://github.com/apache/lucene/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org