You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by ke...@apache.org on 2007/10/19 09:00:50 UTC
svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Author: kevj
Date: Fri Oct 19 00:00:50 2007
New Revision: 586283
URL: http://svn.apache.org/viewvc?rev=586283&view=rev
Log:
-allow use of antlr 3+
Modified:
ant/core/branches/ANT_17_BRANCH/build.xml
Modified: ant/core/branches/ANT_17_BRANCH/build.xml
URL: http://svn.apache.org/viewvc/ant/core/branches/ANT_17_BRANCH/build.xml?rev=586283&r1=586282&r2=586283&view=diff
==============================================================================
--- ant/core/branches/ANT_17_BRANCH/build.xml (original)
+++ ant/core/branches/ANT_17_BRANCH/build.xml Fri Oct 19 00:00:50 2007
@@ -427,9 +427,12 @@
<available property="starteam.present"
classname="com.starbase.util.Platform"
classpathref="classpath"/>
- <available property="antlr.present"
- classname="antlr.Tool"
- classpathref="classpath"/>
+ <condition property="antlr.present">
+ <or>
+ <available classname="org.antlr.Tool" classpathref="classpath"/>
+ <available classname="antlr.Tool" classpathref="classpath"/>
+ </or>
+ </condition>
<available property="stylebook.present"
classname="org.apache.stylebook.Engine"
classpathref="classpath"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Posted by Matt Benson <gu...@yahoo.com>.
--- Kevin Jackson <fo...@gmail.com> wrote:
> Hi,
>
> > Kev--I don't get it. The ANTLR task isn't
> compatible
> > with Antlr 3, though a compatible version is
> available
> > at antlr.org . Did I miss something?
>
> Sorry, I was getting all dependencies for the build
> and just
> downloaded the latest antlr (3). When the build
> failed I noticed that
> it was a selector issue and modified it.
>
> So should I fix the task to be antlr3 compat or
> remove the change?
I had quite some time back gotten Ter(ence Parr) to
agree to host future versions of any ANTLR task. I
would say we can stick with the one we have as a
matter of necessity only. FWIW, antlr2.org is now the
site for ANTLR 2.x stuff. We should probably add
something to the task doc to emphasize that it does
not work with ANTLR 3. AFAIK the command-line options
are different enough that trying to make the task
handle both would be a real PITA. Not to mention the
fact that the meta-grammar is completely changed which
means existing dependency calculation logic probably
wouldn't work either. Finally, ANTLR 3 actually
provides some hooks for tools to get generated
artifact names so that the kind of kludgery in our
task doesn't have to take place.
-Matt
>
> (I'll remove the change and get antlr 2.7x for the
> ant build)
>
> Thanks for catching that,
>
> Kev
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Posted by Peter Reilly <pe...@gmail.com>.
There is no compile time dependency on antlr classes
in the optional ANTLR task ;- so one could use java.lang.Object
as the test class to see if one can compile it.
Peter
On 10/22/07, Stefan Bodewig <bo...@apache.org> wrote:
> On Sat, 20 Oct 2007, Kevin Jackson <fo...@gmail.com> wrote:
>
> > So should I fix the task to be antlr3 compat or remove the change?
>
> If the antlr folks provide a task of their own now, we shouldn't
> change ours (but point to theirs and keep ours for people using ANTLR
> 2.x), IMHO.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On Sat, 20 Oct 2007, Kevin Jackson <fo...@gmail.com> wrote:
> So should I fix the task to be antlr3 compat or remove the change?
If the antlr folks provide a task of their own now, we shouldn't
change ours (but point to theirs and keep ours for people using ANTLR
2.x), IMHO.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Posted by Kevin Jackson <fo...@gmail.com>.
Hi,
> Kev--I don't get it. The ANTLR task isn't compatible
> with Antlr 3, though a compatible version is available
> at antlr.org . Did I miss something?
Sorry, I was getting all dependencies for the build and just
downloaded the latest antlr (3). When the build failed I noticed that
it was a selector issue and modified it.
So should I fix the task to be antlr3 compat or remove the change?
(I'll remove the change and get antlr 2.7x for the ant build)
Thanks for catching that,
Kev
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r586283 - /ant/core/branches/ANT_17_BRANCH/build.xml
Posted by Matt Benson <gu...@yahoo.com>.
Kev--I don't get it. The ANTLR task isn't compatible
with Antlr 3, though a compatible version is available
at antlr.org . Did I miss something?
-Matt
--- kevj@apache.org wrote:
> Author: kevj
> Date: Fri Oct 19 00:00:50 2007
> New Revision: 586283
>
> URL:
> http://svn.apache.org/viewvc?rev=586283&view=rev
> Log:
> -allow use of antlr 3+
>
> Modified:
> ant/core/branches/ANT_17_BRANCH/build.xml
>
> Modified: ant/core/branches/ANT_17_BRANCH/build.xml
> URL:
>
http://svn.apache.org/viewvc/ant/core/branches/ANT_17_BRANCH/build.xml?rev=586283&r1=586282&r2=586283&view=diff
>
==============================================================================
> --- ant/core/branches/ANT_17_BRANCH/build.xml
> (original)
> +++ ant/core/branches/ANT_17_BRANCH/build.xml Fri
> Oct 19 00:00:50 2007
> @@ -427,9 +427,12 @@
> <available property="starteam.present"
> classname="com.starbase.util.Platform"
> classpathref="classpath"/>
> - <available property="antlr.present"
> - classname="antlr.Tool"
> - classpathref="classpath"/>
> + <condition property="antlr.present">
> + <or>
> + <available classname="org.antlr.Tool"
> classpathref="classpath"/>
> + <available classname="antlr.Tool"
> classpathref="classpath"/>
> + </or>
> + </condition>
> <available property="stylebook.present"
> classname="org.apache.stylebook.Engine"
> classpathref="classpath"/>
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org