You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/03/24 14:58:30 UTC

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893 

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15544


Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................

IMPALA-9548: UdfExecutorTest failures after HIVE-22893

HIVE-22893: "Enhance data size estimation for fields computed by UDFs"
modified o.a.h.hive.ql.udf.UDFSubstr and added a dependency on a few new
Hive classes located in the hive-exec jar. These classes include:

o.a.h.hive.ql.plan.ColStatistics
o.a.h.hive.ql.stats.estimator.StatEstimator
o.a.h.hive.ql.stats.estimator.StatEstimatorProvider

The test UdfExecutorTest#HiveStringsTest loads the class UDFSubstr and
thus needs to load the aforementioned stats classes as well.

shaded-deps/pom.xml selectively pulls in certain classes from the
hive-exec jar, and excludes all others. This patch simply addes the
necessary stats classes to load UDFSubstr. Thus, fixing
UdfExecutorTest.

Testing:
* Ran core tests with CDP_BUILD_NUMBER=2244454 and USE_CDP_HIVE=true,
  validated that UdfExecutorTest now passes

Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
---
M shaded-deps/pom.xml
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/15544/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 16:35:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:44:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 1:

Going to wait for https://gerrit.cloudera.org/#/c/15533/ to get merged first, since that does the GBN upgrade.


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 14:59:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5547/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:49:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 3:

GVO failed due to an unrelated error. Filed IMPALA-9552


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:52:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................

IMPALA-9548: UdfExecutorTest failures after HIVE-22893

HIVE-22893: "Enhance data size estimation for fields computed by UDFs"
modified o.a.h.hive.ql.udf.UDFSubstr and added a dependency on a few new
Hive classes located in the hive-exec jar. These classes include:

o.a.h.hive.ql.plan.ColStatistics
o.a.h.hive.ql.stats.estimator.StatEstimator
o.a.h.hive.ql.stats.estimator.StatEstimatorProvider

The test UdfExecutorTest#HiveStringsTest loads the class UDFSubstr and
thus needs to load the aforementioned stats classes as well.

shaded-deps/pom.xml selectively pulls in certain classes from the
hive-exec jar, and excludes all others. This patch simply addes the
necessary stats classes to load UDFSubstr. Thus, fixing
UdfExecutorTest.

Testing:
* Ran core tests with CDP_BUILD_NUMBER=2244454 and USE_CDP_HIVE=true,
  validated that UdfExecutorTest now passes

Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Reviewed-on: http://gerrit.cloudera.org:8080/15544
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shaded-deps/pom.xml
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5546/


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:41:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5546/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:44:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5586/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 15:39:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Mar 2020 00:48:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9548: UdfExecutorTest failures after HIVE-22893

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15544 )

Change subject: IMPALA-9548: UdfExecutorTest failures after HIVE-22893
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d5df08c2d48d21293d5a5308eb453f40184bf
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:49:42 +0000
Gerrit-HasComments: No