[jira] [Commented] (BEAM-945) BigQueryIO.parseTableSpec is package-private

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655595#comment-15655595 ] 

ASF GitHub Bot commented on BEAM-945:
-------------------------------------

GitHub user andrewsmartin opened a pull request:

    https://github.com/apache/incubator-beam/pull/1345

    [BEAM-945] Make BigQueryIO.parseTableSpec public

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewsmartin/incubator-beam fix-parse-table-spec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1345
    
----
commit 2ba3ab20363a6160d3bf42b8c321fc299babfcef
Author: Andrew Martin <am...@spotify.com>
Date:   2016-11-08T20:09:50Z

    Make BigQueryIO.parseTableSpec public

----


> BigQueryIO.parseTableSpec is package-private
> --------------------------------------------
>
>                 Key: BEAM-945
>                 URL: https://issues.apache.org/jira/browse/BEAM-945
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>    Affects Versions: 0.3.0-incubating
>            Reporter: Andrew Martin
>            Assignee: Daniel Halperin
>            Priority: Blocker
>
> It was changed in this commit. https://github.com/apache/incubator-beam/commit/dbbcbe604e167b306feac2443bec85f2da3c1dd6.
> Is there a good reason for it to not be public? If not I will submit a PR to change it back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)