You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/02/02 20:59:31 UTC
Re: [mp2] exists_config_define
Philippe M. Chiasson wrote:
> On Mon, 2004-01-19 at 14:06, Geoffrey Young wrote:
>
>>>[...]
>>>
>>>May be we should take this further and make Apache::Server what Apache::
>>>is used to be: i.e., just the httpd accessors. And create
>>>Apache::ServerRec similar to Apache::RequestRec which will give the
>>>access to $s?
>>>
>>>Same with ConnRec?
>>
>>I was going to suggest the same thing to one of Perrin's comments, so +1 on
>>A::ServerRec and A::ConnRec in place of A::Server and A::Connection.
>
>
> It does sound like a good and logical change to me too...
>
>
>>>Obviously we need to wait a bit with changing everything and sleep on it
>>>for some time.
>>
>>agreed :)
So, we need to complete this API renaming. 1.99_13 can't be released with half
changed API. At the moment Apache::Server namespace contains functions
operating on $s instances and global accessors to the Apache server, which is
incorrect.
Looks like Apache::ServerRec was agreed upon.
Now we also need to agree whether we do the same change for Connection: i.e.
Apache::ConnRec or Apache::ConnectionRec?
Since we fully spell RequestRec, FilterRec, and ServerRec, I think I like to
fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] exists_config_define
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>Now we also need to agree whether we do the same change for Connection:
>>i.e.
>>Apache::ConnRec or Apache::ConnectionRec?
>>
>>Since we fully spell RequestRec, FilterRec, and ServerRec, I think I
>>like to fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec.
>
>
> I think I prefer the class to match the C structure, leaving it
> Apache::ConnRec. but I'm not sure about this - ConnRec is rather ugly.
Yup, I prefer ConnectionRec.
> also, don't forget about Apache::ProcessRec :)
That's right.
Though, the notation of Rec is quite messed up in other places. We have Filter
and FilterRec, both are records, but totally different ones. There is the
abstract filter record container which in turn contains a specific filter record.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] exists_config_define
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Now we also need to agree whether we do the same change for Connection:
> i.e.
> Apache::ConnRec or Apache::ConnectionRec?
>
> Since we fully spell RequestRec, FilterRec, and ServerRec, I think I
> like to fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec.
I think I prefer the class to match the C structure, leaving it
Apache::ConnRec. but I'm not sure about this - ConnRec is rather ugly.
also, don't forget about Apache::ProcessRec :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] exists_config_define
Posted by Stas Bekman <st...@stason.org>.
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
>
>> On Mon, 2004-01-19 at 14:06, Geoffrey Young wrote:
>>
>>>> [...]
>>>>
>>>> May be we should take this further and make Apache::Server what
>>>> Apache::
>>>> is used to be: i.e., just the httpd accessors. And create
>>>> Apache::ServerRec similar to Apache::RequestRec which will give the
>>>> access to $s?
>>>>
>>>> Same with ConnRec?
>>>
>>>
>>> I was going to suggest the same thing to one of Perrin's comments, so
>>> +1 on
>>> A::ServerRec and A::ConnRec in place of A::Server and A::Connection.
>>
>>
>>
>> It does sound like a good and logical change to me too...
>>
>>
>>>> Obviously we need to wait a bit with changing everything and sleep
>>>> on it
>>>> for some time.
>>>
>>>
>>> agreed :)
>
>
> So, we need to complete this API renaming. 1.99_13 can't be released
> with half changed API. At the moment Apache::Server namespace contains
> functions operating on $s instances and global accessors to the Apache
> server, which is incorrect.
>
> Looks like Apache::ServerRec was agreed upon.
>
> Now we also need to agree whether we do the same change for Connection:
> i.e.
> Apache::ConnRec or Apache::ConnectionRec?
>
> Since we fully spell RequestRec, FilterRec, and ServerRec, I think I
> like to fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec.
I also have an alternative solution, more compatible with mp1 and requiring
far less changes.
- revert the Apache:: -> Apache::Server:: changes
- redo them into Apache:: -> Apache::Program::
(of course shortcutting it to be Apache::Server:: -> Apache::Server::)
So all functions that alter or read the state of the Apache *program* will
live in their own space. This is really the same as Apache::, but less
confusing. Doing that will allow us to keep Apache::Server dealing with $s
instances.
I do like the ConnectionRec, ServerRec idea, but I think it'll require a way
too many changes for those porting to 2.0.
Of course we may decide to do both: Apache::Program and
Apache::ServerRec/Apache::ConnectionRec, to make things less ambiguos. For
example many people confuse Apache::Request and Apache::RequestRec. So if we
will have Apache::Server and Apache::ServerRec we will have another confusion
source.
Finally if you have a better idea then 'Program' in Apache::Program, please
suggest alternative names.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org