[GitHub] [incubator-nuttx] xiaoxiang781216 removed a comment on pull request #3170: Move getopt() variables into TLS

[GitBox <gi...@apache.org>]

xiaoxiang781216 removed a comment on pull request #3170:
URL: https://github.com/apache/incubator-nuttx/pull/3170#issuecomment-807972525


   > > You are right, details are the devil. Maybe, we can add a size field as the first member of tls_info_s, to reduce the code need to check whether the caller come from the main task or the background/work thread.
   > 
   > I am beginning to think that the best way to implement per-process globals might be the same way that we already implement other per-process, application data like file descriptor, streams, etc. Allocate then with umm_malloc(), but retain them in the group structure with the system call to access them.
   > 
   
   Yes, it's another approach, but why not move all pure userspace stuff to the main stack? So we don't have some FILE function inside the kernel space.
   
   > With PR #3182, I will need to have per-process key and destructor data. The data itself goes in thread-specific storage, but the keys are process-wide. We should agree on a technical approach. Without some agreement, I think I will need to implement the initial version with more system-wide global data.
   > 
   > I will need to do that tomorrow so I can't really wait, but I don't mind reworking as necessary at a later point in time.
   > 
   > This discussion really should be in Issue #3168 which is more in line with topic.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org