[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL

["Harry Metske (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746174#comment-15746174 ] 

Harry Metske commented on JSPWIKI-1035:
---------------------------------------

Jurgen, can you create the patch files with the -u option, so we can apply them with the patch cmd (or IDE of course) ?
Then I suggest we create a separate (JSPWIKI-1035) branch for it, so we can continue testing and patching it.

> get rid of jspwiki.baseURL
> --------------------------
>
>                 Key: JSPWIKI-1035
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1035
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.10.2
>            Reporter: Jürgen Weber
>         Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, jspwiki.properties.patch
>
>
> Could we get rid of  jspwiki.baseURL and calculate it on HttpServletRequest#getContextPath() ?
> It's the only mandatory property you have to set for JSPWiki, so removing it would make installation much easier.
> And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. you cannot use the same JSPWiki instance in an intranet and on the internet (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed Apache, neither SSL and non-SSL.
> If you look at the source of https://jspwiki-wiki.apache.org/ 
> there are not many places where the whole base url is used. So, I wonder, if context relative links could be sufficient.
> http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)