[jira] [Work logged] (BEAM-8473) Python typehints: spurious warnings for Generator None args

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-8473?focusedWorklogId=617816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617816 ]

ASF GitHub Bot logged work on BEAM-8473:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/21 20:25
            Start Date: 01/Jul/21 20:25
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on pull request #15061:
URL: https://github.com/apache/beam/pull/15061#issuecomment-872528250


   Run Python PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 617816)
    Time Spent: 2h  (was: 1h 50m)

> Python typehints: spurious warnings for Generator None args
> -----------------------------------------------------------
>
>                 Key: BEAM-8473
>                 URL: https://issues.apache.org/jira/browse/BEAM-8473
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Udi Meiri
>            Priority: P3
>              Labels: types
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> GeneratorHint outputs warnings if the 2 last args of typing.Generator are not None.
> 1. Compare to type(None) instead of None, since that's what the code converts those to. (assert on logging output)
> 2. (fixed) Bug: comparing send_type in both cases.
> https://github.com/apache/beam/blob/06fa1cc2a92a6f4f0e05f162ee2eb78b072920d9/sdks/python/apache_beam/typehints/typehints.py#L1088-L1091



--
This message was sent by Atlassian Jira
(v8.3.4#803005)