You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2014/07/18 06:20:04 UTC

[jira] [Commented] (HIVE-7419) Missing break in SemanticAnalyzer#getTableDescFromSerDe()

    [ https://issues.apache.org/jira/browse/HIVE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066003#comment-14066003 ] 

Ted Yu commented on HIVE-7419:
------------------------------

Thanks for taking care of this.

> Missing break in SemanticAnalyzer#getTableDescFromSerDe()
> ---------------------------------------------------------
>
>                 Key: HIVE-7419
>                 URL: https://issues.apache.org/jira/browse/HIVE-7419
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-7419.1.patch.txt
>
>
> {code}
>         case HiveParser.TOK_TABLEROWFORMATLINES:
>           String lineDelim = unescapeSQLString(rowChild.getChild(0).getText());
>           tblDesc.getProperties().setProperty(serdeConstants.LINE_DELIM, lineDelim);
>           if (!lineDelim.equals("\n") && !lineDelim.equals("10")) {
>             throw new SemanticException(generateErrorMessage(rowChild,
>                 ErrorMsg.LINES_TERMINATED_BY_NON_NEWLINE.getMsg()));
>           }
>         case HiveParser.TOK_TABLEROWFORMATNULL:
>           String nullFormat = unescapeSQLString(rowChild.getChild(0).getText());
> {code}
> break seems to be missing for TOK_TABLEROWFORMATLINES case.



--
This message was sent by Atlassian JIRA
(v6.2#6252)