You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/23 10:14:43 UTC

[GitHub] [systemds] corepointer commented on pull request #924: WIP: Spoof cuda initial cellwise

corepointer commented on pull request #924:
URL: https://github.com/apache/systemds/pull/924#issuecomment-697270429


   > Hi @corepointer - Thanks a lot for working on this! smiley
   > 
   > **Few more ingredients:** salt
   > 
   >     1. Shall we add the design documentation? A helpful example is
   > 
   > 
   > https://github.com/apache/systemds/blob/7cdb51d18ee1a9d7a957f366a71d04ca818bdf91/src/main/java/org/apache/sysds/runtime/matrix/data/CudaSupportFunctions.java#L31-L58
   > 
   >     1. Can we breakdown the whole into a few logical PRs.
   >        The other `TODO` can be handled in a different PR. If this PR adds the `sufficient intended functionality` and is `robust`
   >        enough to that extent, we can plan to merge it.
   > 
   > 
   > Thank you,
   > Janardhan
   
   Thank you for the pointer to the design docs. I'll take that into account once this is ready to be documented. 
   For now I'll retract the PR and bring everything up to speed.
   best,
   Mark


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org