You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/05 07:55:00 UTC

[jira] [Work logged] (BEAM-9887) Throw IllegalArgumentException when building Row with logical types with Invalid input

     [ https://issues.apache.org/jira/browse/BEAM-9887?focusedWorklogId=430566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430566 ]

ASF GitHub Bot logged work on BEAM-9887:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/May/20 07:54
            Start Date: 05/May/20 07:54
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-623911388


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 430566)
    Time Spent: 40m  (was: 0.5h)

> Throw IllegalArgumentException when building Row with logical types with Invalid input 
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-9887
>                 URL: https://issues.apache.org/jira/browse/BEAM-9887
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Rahul Patwari
>            Assignee: Rahul Patwari
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> schema.logicaltypes.FixedBytes logical type expects an argument - the length of the byte[].
> When an invalid input value (with length < expectedLength) is provided while building the Row with FixedBytes logical type, IllegalArgumentException is expected. But, the Exception is not thrown. The below code illustrates the behaviour:
> {code:java}
>  Schema schema = Schema.builder().addLogicalTypeField("char", FixedBytes.of(10)).build();
>  byte[] byteArray = {1, 2, 3, 4, 5};
>  Row row = Row.withSchema(schema).withFieldValue("char", byteArray).build();
>  System.out.println(Arrays.toString(row.getLogicalTypeValue("char", byte[].class)));
> {code}
> The above code prints "[1, 2, 3, 4, 5]" with length 5 to the console, whereas the expected length of FixedBytes, is 10.
> The code is run on the master branch.
> The behaviour is as expected with 2.20.0 release.
> {{ }}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)