svn commit: r355910 - in /geronimo/trunk: configs/j2ee-system/src/plan/plan.xml modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java

[am...@apache.org]

Author: ammulder
Date: Sat Dec 10 20:58:47 2005
New Revision: 355910

URL: http://svn.apache.org/viewcvs?rev=355910&view=rev
Log:
Make the configuration manager editable.
Now saves new GBeans to config.xml without any special effort for the ECM.

Modified:
    geronimo/trunk/configs/j2ee-system/src/plan/plan.xml
    geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java

Modified: geronimo/trunk/configs/j2ee-system/src/plan/plan.xml
URL: http://svn.apache.org/viewcvs/geronimo/trunk/configs/j2ee-system/src/plan/plan.xml?rev=355910&r1=355909&r2=355910&view=diff
==============================================================================
--- geronimo/trunk/configs/j2ee-system/src/plan/plan.xml (original)
+++ geronimo/trunk/configs/j2ee-system/src/plan/plan.xml Sat Dec 10 20:58:47 2005
@@ -37,7 +37,7 @@
     <gbean name="ServerInfo" class="org.apache.geronimo.system.serverinfo.BasicServerInfo"/>
 
     <!-- Configuration Manager service -->
-    <gbean name="ConfigurationManager" class="org.apache.geronimo.kernel.config.ConfigurationManagerImpl">
+    <gbean name="ConfigurationManager" class="org.apache.geronimo.kernel.config.EditableConfigurationManagerImpl">
         <reference name="Stores">
             <gbean-name>*:j2eeType=ConfigurationStore,*</gbean-name>
         </reference>

Modified: geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java
URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java?rev=355910&r1=355909&r2=355910&view=diff
==============================================================================
--- geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java (original)
+++ geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/kernel/config/EditableConfigurationManagerImpl.java Sat Dec 10 20:58:47 2005
@@ -38,8 +38,6 @@
     }
 
     public void addGBeanToConfiguration(URI configID, GBeanData gbean, boolean start) throws InvalidConfigException {
-        //todo: when able to, save new GBean data in attribute store rather than in serialized state
-        //that is, replace the code below with only calls to the attribute store
         try {
             ObjectName name = Configuration.getConfigurationObjectName(configID);
             kernel.invoke(name, "addGBean", new Object[]{gbean, start ? Boolean.TRUE : Boolean.FALSE}, new String[]{GBeanData.class.getName(), boolean.class.getName()});