[jira] Commented: (SHINDIG-476) JSON-RPC handler

["Cassie Doll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617071#action_12617071 ] 

Cassie Doll commented on SHINDIG-476:
-------------------------------------

Comments so far:

- why do you have your own servlet? can't you reuse the servlet logic just like the current batching mechanism does? also, i think you might have a smaller diff if you replace the old batching with the new rpc batching - both in the js and java. we don't want that old stuff hanging around. 

- why do you have a special class for parsing the rpc? can't you just use the BeanJsonConverter? The JsonConversionUtils is ugly ugly code - code I hoped never to see again once we had the converters :( Plus, if you use the converter then we can get other format support for free. 

- there's an author tag in RequestItem that should be removed.

- JsonRpcServlet - converting objects on the way out should also be more automatic here. instead of result.put("error", error) we should make a BatchResponse object with an error field. (i know the current batching doesn't do this, but it should.) Again, this will allow other formats more easily. 

- when you want to commit this code at some later date it would be really nice to break this up. there are some style changes, import reorderings, and some general refactorings that could be split out which would make everything easier to understand. 

- things like adding @me support can also be done before rpc gets approved
 

> JSON-RPC handler
> ----------------
>
>                 Key: SHINDIG-476
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-476
>             Project: Shindig
>          Issue Type: New Feature
>          Components: RESTful API (Java)
>            Reporter: Louis Ryan
>            Assignee: Louis Ryan
>         Attachments: JSONRPC.patch
>
>
> This patch contains a largely working implementation of the JSON-RPC proposal I suggested to the spec list.
> Major changes include
> - Abstracting out common base types for RequestItem and added subclasses of RestfulRequestItem and RPC.
> - Abstracting out common base type for API servlets
> - New jsonrpccontainer.js
> - Make request handlers respect operation/verb synonyms
> All existing test pass and end-to-end tests work.
> This is very much a WIP but should be enough for folks to look at.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.