You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Aaron Radzinski <ar...@datalingvo.com> on 2020/10/21 16:35:13 UTC
[VOTE] Release Apache NLPCraft (Incubating) 0.7.1
NLPCraft-ers,
This is a call for a vote to release Apache NLPCraft (incubating) version
0.7.1. This release includes bug fixes and incremental improvements for
NLPCraft 0.7.0 release.
Release information:
1. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
4. JIRA issues fixed in release:
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
5. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
The vote will be open for at least 72 hours or until a necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you,
Aaron (NLPCraft community).
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Ifropc <if...@protonmail.com.INVALID>.
Hi, now keys are valid.
+1
Thank you,
Gleb.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, October 22, 2020 10:01 AM, Aaron Radzinski <ar...@datalingvo.com> wrote:
> Please, re-import KEYS file again (download & re-import).
>
> Thank you,
>
> ----------------------------------------------------------------------
>
> Aaron Radzinski
>
> On Thu, Oct 22, 2020 at 9:48 AM Ifropc ifropc@protonmail.com.invalid
> wrote:
>
> > Hi,
> > I have the same error with signature. My keys are up to date with
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > > gpg --import KEYS.2
> > > gpg: key C7C43555607FE2EF: "Nikita Ivanov nivanov30@gmail.com" not
> > > changed
> > > gpg: key 91D161EDD8405C82: "Aaron Radzinski aradzinski@datalingvo.com"
> > > not changed
> > > gpg: key 825F1640958F5D27: "Aaron Radzinski aradzinski@datalingvo.com"
> > > not changed
> > > gpg: Total number processed: 3
> > > gpg: unchanged: 3
> > > gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> > > gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> > > gpg: Signature made Wed 21 Oct 2020 08:51:24 AM PDT
> > > gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> > > gpg: Can't check signature: No public key
> >
> > Regards,
> > Gleb.
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > On Thursday, October 22, 2020 3:38 AM, Sergey Makov smakov@apache.org
> > wrote:
> >
> > > I imported it from
> > >
> > > 5. KEYS file:
> > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >
> > >
> > > Regards,
> > > Sergey
> > > On Thu, Oct 22, 2020 at 5:17 AM Aaron Radzinski
> > > aradzinski@datalingvo.com wrote:
> > >
> > > > Did you pull the updated KEYS file from SVN repo? I'm using the same
> > > > key as
> > >
> > > > for 0.7.0 release...
> > > > Thank you,
> > > >
> > > > Aaron Radzinski
> > > > On Wed, Oct 21, 2020 at 12:08 PM Sergey Makov smakov@apache.org wrote:
> > > >
> > > > > Looks like keys are invalid:
> > > > > $ gpg --import KEYS
> > > > > gpg: key C7C43555607FE2EF: "Nikita Ivanov nivanov30@gmail.com" not
> > > > > changed
> > > > > gpg: key 91D161EDD8405C82: "Aaron Radzinski
> > > > > aradzinski@datalingvo.com" not changed
> > > > > gpg: key 825F1640958F5D27: "Aaron Radzinski
> > > > > aradzinski@datalingvo.com" not changed
> > > > > gpg: Total number processed: 3
> > > > > gpg: unchanged: 3
> > > > > $ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> > > > > gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> > > > > gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
> > > > > gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> > > > > gpg: Can't check signature: No public key
> > > > > Regards,
> > > > > Sergey
> > > > > On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
> > > > > aradzinski@datalingvo.com wrote:
> > > > >
> > > > > > NLPCraft-ers,
> > > > > > This is a call for a vote to release Apache NLPCraft (incubating)
> > > > > > version
> > >
> > > > > > 0.7.1. This release includes bug fixes and incremental
> > > > > > improvements for
> > >
> > > > > > NLPCraft 0.7.0 release.
> > > > > > Release information:
> > > > > >
> > > > > > 1. Release location:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> >
> > > > > > 3. Git tag:
> > > > > > https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > > > > >
> > >
> > > > > > 4. JIRA issues fixed in release:
> >
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> >
> > > > > > 5. KEYS file:
> >
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > > > > > The vote will be open for at least 72 hours or until a necessary
> > > > > > number
> > >
> > > > > > of
> > > > > > votes are reached.
> > > > > > Please vote accordingly:
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove with the reason
> > > > > > Thank you,
> > > > > > Aaron (NLPCraft community).
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Please, re-import KEYS file again (download & re-import).
Thank you,
--
Aaron Radzinski
On Thu, Oct 22, 2020 at 9:48 AM Ifropc <if...@protonmail.com.invalid>
wrote:
> Hi,
>
> I have the same error with signature. My keys are up to date with
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> > gpg --import KEYS.2
> gpg: key C7C43555607FE2EF: "Nikita Ivanov <ni...@gmail.com>" not
> changed
> gpg: key 91D161EDD8405C82: "Aaron Radzinski <ar...@datalingvo.com>"
> not changed
> gpg: key 825F1640958F5D27: "Aaron Radzinski <ar...@datalingvo.com>"
> not changed
> gpg: Total number processed: 3
> gpg: unchanged: 3
> > gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> gpg: Signature made Wed 21 Oct 2020 08:51:24 AM PDT
> gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> gpg: Can't check signature: No public key
>
> Regards,
> Gleb.
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Thursday, October 22, 2020 3:38 AM, Sergey Makov <sm...@apache.org>
> wrote:
>
> > I imported it from
> >
> > -------------------
> >
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> >
> > Regards,
> > Sergey
> >
> > On Thu, Oct 22, 2020 at 5:17 AM Aaron Radzinski
> > aradzinski@datalingvo.com wrote:
> >
> > > Did you pull the updated KEYS file from SVN repo? I'm using the same
> key as
> > > for 0.7.0 release...
> > >
> > > Thank you,
> > >
> > > -----------
> > >
> > > Aaron Radzinski
> > > On Wed, Oct 21, 2020 at 12:08 PM Sergey Makov smakov@apache.org wrote:
> > >
> > > > Looks like keys are invalid:
> > > > $ gpg --import KEYS
> > > > gpg: key C7C43555607FE2EF: "Nikita Ivanov nivanov30@gmail.com" not
> > > > changed
> > > > gpg: key 91D161EDD8405C82: "Aaron Radzinski
> > > > aradzinski@datalingvo.com" not changed
> > > > gpg: key 825F1640958F5D27: "Aaron Radzinski
> > > > aradzinski@datalingvo.com" not changed
> > > > gpg: Total number processed: 3
> > > > gpg: unchanged: 3
> > > > $ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> > > > gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> > > > gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
> > > > gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> > > > gpg: Can't check signature: No public key
> > > > Regards,
> > > > Sergey
> > > > On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
> > > > aradzinski@datalingvo.com wrote:
> > > >
> > > > > NLPCraft-ers,
> > > > > This is a call for a vote to release Apache NLPCraft (incubating)
> version
> > > > > 0.7.1. This release includes bug fixes and incremental
> improvements for
> > > > > NLPCraft 0.7.0 release.
> > > > > Release information:
> > > > >
> > > > > 1. Release location:
> > > >
> > > >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > > >
> > > > > 3. Git tag:
> https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > > > > 4. JIRA issues fixed in release:
> > > > >
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > > > >
> > > > > 5. KEYS file:
> > > > >
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > > > >
> > > > >
> > > > > The vote will be open for at least 72 hours or until a necessary
> number
> > > > > of
> > > > > votes are reached.
> > > > > Please vote accordingly:
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > > Thank you,
> > > > > Aaron (NLPCraft community).
>
>
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Ifropc <if...@protonmail.com.INVALID>.
Hi,
I have the same error with signature. My keys are up to date with
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> gpg --import KEYS.2
gpg: key C7C43555607FE2EF: "Nikita Ivanov <ni...@gmail.com>" not changed
gpg: key 91D161EDD8405C82: "Aaron Radzinski <ar...@datalingvo.com>" not changed
gpg: key 825F1640958F5D27: "Aaron Radzinski <ar...@datalingvo.com>" not changed
gpg: Total number processed: 3
gpg: unchanged: 3
> gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
gpg: Signature made Wed 21 Oct 2020 08:51:24 AM PDT
gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
gpg: Can't check signature: No public key
Regards,
Gleb.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, October 22, 2020 3:38 AM, Sergey Makov <sm...@apache.org> wrote:
> I imported it from
>
> -------------------
>
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
>
> Regards,
> Sergey
>
> On Thu, Oct 22, 2020 at 5:17 AM Aaron Radzinski
> aradzinski@datalingvo.com wrote:
>
> > Did you pull the updated KEYS file from SVN repo? I'm using the same key as
> > for 0.7.0 release...
> >
> > Thank you,
> >
> > -----------
> >
> > Aaron Radzinski
> > On Wed, Oct 21, 2020 at 12:08 PM Sergey Makov smakov@apache.org wrote:
> >
> > > Looks like keys are invalid:
> > > $ gpg --import KEYS
> > > gpg: key C7C43555607FE2EF: "Nikita Ivanov nivanov30@gmail.com" not
> > > changed
> > > gpg: key 91D161EDD8405C82: "Aaron Radzinski
> > > aradzinski@datalingvo.com" not changed
> > > gpg: key 825F1640958F5D27: "Aaron Radzinski
> > > aradzinski@datalingvo.com" not changed
> > > gpg: Total number processed: 3
> > > gpg: unchanged: 3
> > > $ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> > > gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> > > gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
> > > gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> > > gpg: Can't check signature: No public key
> > > Regards,
> > > Sergey
> > > On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
> > > aradzinski@datalingvo.com wrote:
> > >
> > > > NLPCraft-ers,
> > > > This is a call for a vote to release Apache NLPCraft (incubating) version
> > > > 0.7.1. This release includes bug fixes and incremental improvements for
> > > > NLPCraft 0.7.0 release.
> > > > Release information:
> > > >
> > > > 1. Release location:
> > >
> > > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > >
> > > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > > > 4. JIRA issues fixed in release:
> > > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > > >
> > > > 5. KEYS file:
> > > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > > >
> > > >
> > > > The vote will be open for at least 72 hours or until a necessary number
> > > > of
> > > > votes are reached.
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > > Thank you,
> > > > Aaron (NLPCraft community).
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Sergey Makov <sm...@apache.org>.
I imported it from
---
5. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
---
Regards,
Sergey
On Thu, Oct 22, 2020 at 5:17 AM Aaron Radzinski
<ar...@datalingvo.com> wrote:
>
> Did you pull the updated KEYS file from SVN repo? I'm using the same key as
> for 0.7.0 release...
>
> Thank you,
> --
> Aaron Radzinski
>
>
>
> On Wed, Oct 21, 2020 at 12:08 PM Sergey Makov <sm...@apache.org> wrote:
>
> > Looks like keys are invalid:
> >
> > $ gpg --import KEYS
> > gpg: key C7C43555607FE2EF: "Nikita Ivanov <ni...@gmail.com>" not
> > changed
> > gpg: key 91D161EDD8405C82: "Aaron Radzinski
> > <ar...@datalingvo.com>" not changed
> > gpg: key 825F1640958F5D27: "Aaron Radzinski
> > <ar...@datalingvo.com>" not changed
> > gpg: Total number processed: 3
> > gpg: unchanged: 3
> >
> > $ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> > gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> > gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
> > gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> > gpg: Can't check signature: No public key
> >
> > Regards,
> > Sergey
> >
> > On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
> > <ar...@datalingvo.com> wrote:
> > >
> > > NLPCraft-ers,
> > > This is a call for a vote to release Apache NLPCraft (incubating) version
> > > 0.7.1. This release includes bug fixes and incremental improvements for
> > > NLPCraft 0.7.0 release.
> > >
> > > Release information:
> > > 1. Release location:
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > > 4. JIRA issues fixed in release:
> > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > > 5. KEYS file:
> > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >
> > > The vote will be open for at least 72 hours or until a necessary number
> > of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thank you,
> > > Aaron (NLPCraft community).
> >
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Did you pull the updated KEYS file from SVN repo? I'm using the same key as
for 0.7.0 release...
Thank you,
--
Aaron Radzinski
On Wed, Oct 21, 2020 at 12:08 PM Sergey Makov <sm...@apache.org> wrote:
> Looks like keys are invalid:
>
> $ gpg --import KEYS
> gpg: key C7C43555607FE2EF: "Nikita Ivanov <ni...@gmail.com>" not
> changed
> gpg: key 91D161EDD8405C82: "Aaron Radzinski
> <ar...@datalingvo.com>" not changed
> gpg: key 825F1640958F5D27: "Aaron Radzinski
> <ar...@datalingvo.com>" not changed
> gpg: Total number processed: 3
> gpg: unchanged: 3
>
> $ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
> gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
> gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
> gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
> gpg: Can't check signature: No public key
>
> Regards,
> Sergey
>
> On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
> <ar...@datalingvo.com> wrote:
> >
> > NLPCraft-ers,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.7.1. This release includes bug fixes and incremental improvements for
> > NLPCraft 0.7.0 release.
> >
> > Release information:
> > 1. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > Aaron (NLPCraft community).
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Sergey Makov <sm...@apache.org>.
Looks like keys are invalid:
$ gpg --import KEYS
gpg: key C7C43555607FE2EF: "Nikita Ivanov <ni...@gmail.com>" not changed
gpg: key 91D161EDD8405C82: "Aaron Radzinski
<ar...@datalingvo.com>" not changed
gpg: key 825F1640958F5D27: "Aaron Radzinski
<ar...@datalingvo.com>" not changed
gpg: Total number processed: 3
gpg: unchanged: 3
$ gpg --verify apache-nlpcraft-incubating-0.7.1.zip.asc
gpg: assuming signed data in 'apache-nlpcraft-incubating-0.7.1.zip'
gpg: Signature made Wed Oct 21 18:51:24 2020 MSK
gpg: using RSA key 79BB50129889A04C68BD7A4ABCD48C7B6C94ED02
gpg: Can't check signature: No public key
Regards,
Sergey
On Wed, Oct 21, 2020 at 7:35 PM Aaron Radzinski
<ar...@datalingvo.com> wrote:
>
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.1. This release includes bug fixes and incremental improvements for
> NLPCraft 0.7.0 release.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Nikita Ivanov <mk...@gmail.com>.
Agree w/Paul. I'd remove KEYS from the source repository to avoid further
confusion.
Thanks,
--
Nikita Ivanov.
On Fri, Oct 23, 2020 at 7:20 PM Paul King <pa...@asert.com.au> wrote:
> One point I forgot - There is certainly mixed practice with regard to
> whether the KEYS file should be checked into the source repo. Some projects
> place it just on dist.apache.org/repos/dist/release. That way there is a
> single point of truth. Right now the one in the source repo is out of sync
> with the dist.apache.org one.
>
> Cheers, Paul.
>
> On Sat, Oct 24, 2020 at 12:11 PM Paul King <pa...@asert.com.au> wrote:
>
> > +1
> >
> > Checked hashes and signatures.
> > "mvn clean verify" passes
> > "mvn apache-rat:rat" passes
> > incubating in name
> > DISCLAIMER exists
> > NOTICE seems okay
> > LICENSE seems okay
> > no unexpected binary files
> >
> > Mentoring notes:
> > * You should minimise changes to KEYS since ideally each release manager
> > would attend a key-signing party and have their key spread amongst other
> > trusted parties. Then verifiers could verify that the release has been
> > signed not only with a valid key but also from a trusted source. Key
> > signing would need to be repeated each time a release manager's key
> > changes. Key signing isn't mandatory, just highly recommended, but isn't
> > easy to do right now due to COVID.
> > * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
> > and NOTICE, thanks) if the statement "Code almost entirely based on work
> of
> > ..." is indeed true, then I believe it is usually clearer to leave the
> > original license header in the source file and perhaps amend with
> > "Subsequent changes Copyright by the NLPCraft team and made under the
> > ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> > but my understanding is that you have the obligation to make it clear
> that
> > the requirements the original author requested for use of that file in
> > source form etc. are still in play and aren't overwritten by slapping the
> > ASLv2 header at the front of the file.
> >
> > Cheers, Paul.
> >
> >
> > On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <
> aradzinski@datalingvo.com>
> > wrote:
> >
> >> NLPCraft-ers,
> >> This is a call for a vote to release Apache NLPCraft (incubating)
> version
> >> 0.7.1. This release includes bug fixes and incremental improvements for
> >> NLPCraft 0.7.0 release.
> >>
> >> Release information:
> >> 1. Release location:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> >> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> >> 4. JIRA issues fixed in release:
> >> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> >> 5. KEYS file:
> >> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >>
> >> The vote will be open for at least 72 hours or until a necessary number
> of
> >> votes are reached.
> >>
> >> Please vote accordingly:
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thank you,
> >> Aaron (NLPCraft community).
> >>
> >
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
On Sat, Oct 24, 2020 at 5:20 AM Paul King <pa...@asert.com.au> wrote:
> One point I forgot - There is certainly mixed practice with regard to
> whether the KEYS file should be checked into the source repo. Some projects
> place it just on dist.apache.org/repos/dist/release. That way there is a
> single point of truth. Right now the one in the source repo is out of sync
> with the dist.apache.org one.
>
> Cheers, Paul.
>
> On Sat, Oct 24, 2020 at 12:11 PM Paul King <pa...@asert.com.au> wrote:
>
> > +1
> >
> > Checked hashes and signatures.
> > "mvn clean verify" passes
> > "mvn apache-rat:rat" passes
> > incubating in name
> > DISCLAIMER exists
> > NOTICE seems okay
> > LICENSE seems okay
> > no unexpected binary files
> >
> > Mentoring notes:
> > * You should minimise changes to KEYS since ideally each release manager
> > would attend a key-signing party and have their key spread amongst other
> > trusted parties. Then verifiers could verify that the release has been
> > signed not only with a valid key but also from a trusted source. Key
> > signing would need to be repeated each time a release manager's key
> > changes. Key signing isn't mandatory, just highly recommended, but isn't
> > easy to do right now due to COVID.
> > * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
> > and NOTICE, thanks) if the statement "Code almost entirely based on work
> of
> > ..." is indeed true, then I believe it is usually clearer to leave the
> > original license header in the source file and perhaps amend with
> > "Subsequent changes Copyright by the NLPCraft team and made under the
> > ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> > but my understanding is that you have the obligation to make it clear
> that
> > the requirements the original author requested for use of that file in
> > source form etc. are still in play and aren't overwritten by slapping the
> > ASLv2 header at the front of the file.
> >
> > Cheers, Paul.
> >
> >
> > On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <
> aradzinski@datalingvo.com>
> > wrote:
> >
> >> NLPCraft-ers,
> >> This is a call for a vote to release Apache NLPCraft (incubating)
> version
> >> 0.7.1. This release includes bug fixes and incremental improvements for
> >> NLPCraft 0.7.0 release.
> >>
> >> Release information:
> >> 1. Release location:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> >> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> >> 4. JIRA issues fixed in release:
> >> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> >> 5. KEYS file:
> >> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >>
> >> The vote will be open for at least 72 hours or until a necessary number
> of
> >> votes are reached.
> >>
> >> Please vote accordingly:
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thank you,
> >> Aaron (NLPCraft community).
> >>
> >
>
[RESULT] [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Aaron Radzinski <ar...@datalingvo.com>.
NLPCraft-ers,
The vote for Apache NLPCraft 0.7.1 release is closed now.
Vote result: the vote PASSES with 8 votes +1 and no -1.
+1 votes:
- Nikita Ivanov
- Aaron Radzinski
- Sergey Kamov
- Gleb Ifrops
- Sergey Makov
- Furkan Kamaci (IPMC)
- Konstantin Boudnik (IPMC)
- Paul King (IPMC)
I will proceed with starting the final vote at IPMC shortly.
Thank you,
--
Aaron Radzinski
On Sun, Oct 25, 2020 at 12:34 AM Konstantin Boudnik <co...@apache.org> wrote:
> +1 [biding]
>
> Checked all usual things, nothing overly suspicious. And I agree with Paul
> on
> both counts - keeping KEYS in the version control is a bit unusual and
> doesn't
> solve anything.
>
> --
> Cos
>
> On Sat, Oct 24, 2020 at 12:19PM, Paul King wrote:
> > One point I forgot - There is certainly mixed practice with regard to
> > whether the KEYS file should be checked into the source repo. Some
> projects
> > place it just on dist.apache.org/repos/dist/release. That way there is a
> > single point of truth. Right now the one in the source repo is out of
> sync
> > with the dist.apache.org one.
> >
> > Cheers, Paul.
> >
> > On Sat, Oct 24, 2020 at 12:11 PM Paul King <pa...@asert.com.au> wrote:
> >
> > > +1
> > >
> > > Checked hashes and signatures.
> > > "mvn clean verify" passes
> > > "mvn apache-rat:rat" passes
> > > incubating in name
> > > DISCLAIMER exists
> > > NOTICE seems okay
> > > LICENSE seems okay
> > > no unexpected binary files
> > >
> > > Mentoring notes:
> > > * You should minimise changes to KEYS since ideally each release
> manager
> > > would attend a key-signing party and have their key spread amongst
> other
> > > trusted parties. Then verifiers could verify that the release has been
> > > signed not only with a valid key but also from a trusted source. Key
> > > signing would need to be repeated each time a release manager's key
> > > changes. Key signing isn't mandatory, just highly recommended, but
> isn't
> > > easy to do right now due to COVID.
> > > * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
> > > and NOTICE, thanks) if the statement "Code almost entirely based on
> work of
> > > ..." is indeed true, then I believe it is usually clearer to leave the
> > > original license header in the source file and perhaps amend with
> > > "Subsequent changes Copyright by the NLPCraft team and made under the
> > > ASLv2..." but what you have is possibly okay - just not as clear.
> IANAL,
> > > but my understanding is that you have the obligation to make it clear
> that
> > > the requirements the original author requested for use of that file in
> > > source form etc. are still in play and aren't overwritten by slapping
> the
> > > ASLv2 header at the front of the file.
> > >
> > > Cheers, Paul.
> > >
> > >
> > > On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <
> aradzinski@datalingvo.com>
> > > wrote:
> > >
> > >> NLPCraft-ers,
> > >> This is a call for a vote to release Apache NLPCraft (incubating)
> version
> > >> 0.7.1. This release includes bug fixes and incremental improvements
> for
> > >> NLPCraft 0.7.0 release.
> > >>
> > >> Release information:
> > >> 1. Release location:
> > >>
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > >> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > >> 4. JIRA issues fixed in release:
> > >> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > >> 5. KEYS file:
> > >> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >>
> > >> The vote will be open for at least 72 hours or until a necessary
> number of
> > >> votes are reached.
> > >>
> > >> Please vote accordingly:
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove with the reason
> > >>
> > >> Thank you,
> > >> Aaron (NLPCraft community).
> > >>
> > >
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Konstantin Boudnik <co...@apache.org>.
+1 [biding]
Checked all usual things, nothing overly suspicious. And I agree with Paul on
both counts - keeping KEYS in the version control is a bit unusual and doesn't
solve anything.
--
Cos
On Sat, Oct 24, 2020 at 12:19PM, Paul King wrote:
> One point I forgot - There is certainly mixed practice with regard to
> whether the KEYS file should be checked into the source repo. Some projects
> place it just on dist.apache.org/repos/dist/release. That way there is a
> single point of truth. Right now the one in the source repo is out of sync
> with the dist.apache.org one.
>
> Cheers, Paul.
>
> On Sat, Oct 24, 2020 at 12:11 PM Paul King <pa...@asert.com.au> wrote:
>
> > +1
> >
> > Checked hashes and signatures.
> > "mvn clean verify" passes
> > "mvn apache-rat:rat" passes
> > incubating in name
> > DISCLAIMER exists
> > NOTICE seems okay
> > LICENSE seems okay
> > no unexpected binary files
> >
> > Mentoring notes:
> > * You should minimise changes to KEYS since ideally each release manager
> > would attend a key-signing party and have their key spread amongst other
> > trusted parties. Then verifiers could verify that the release has been
> > signed not only with a valid key but also from a trusted source. Key
> > signing would need to be repeated each time a release manager's key
> > changes. Key signing isn't mandatory, just highly recommended, but isn't
> > easy to do right now due to COVID.
> > * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
> > and NOTICE, thanks) if the statement "Code almost entirely based on work of
> > ..." is indeed true, then I believe it is usually clearer to leave the
> > original license header in the source file and perhaps amend with
> > "Subsequent changes Copyright by the NLPCraft team and made under the
> > ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> > but my understanding is that you have the obligation to make it clear that
> > the requirements the original author requested for use of that file in
> > source form etc. are still in play and aren't overwritten by slapping the
> > ASLv2 header at the front of the file.
> >
> > Cheers, Paul.
> >
> >
> > On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <ar...@datalingvo.com>
> > wrote:
> >
> >> NLPCraft-ers,
> >> This is a call for a vote to release Apache NLPCraft (incubating) version
> >> 0.7.1. This release includes bug fixes and incremental improvements for
> >> NLPCraft 0.7.0 release.
> >>
> >> Release information:
> >> 1. Release location:
> >> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> >> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> >> 4. JIRA issues fixed in release:
> >> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> >> 5. KEYS file:
> >> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >>
> >> The vote will be open for at least 72 hours or until a necessary number of
> >> votes are reached.
> >>
> >> Please vote accordingly:
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thank you,
> >> Aaron (NLPCraft community).
> >>
> >
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Paul King <pa...@asert.com.au>.
One point I forgot - There is certainly mixed practice with regard to
whether the KEYS file should be checked into the source repo. Some projects
place it just on dist.apache.org/repos/dist/release. That way there is a
single point of truth. Right now the one in the source repo is out of sync
with the dist.apache.org one.
Cheers, Paul.
On Sat, Oct 24, 2020 at 12:11 PM Paul King <pa...@asert.com.au> wrote:
> +1
>
> Checked hashes and signatures.
> "mvn clean verify" passes
> "mvn apache-rat:rat" passes
> incubating in name
> DISCLAIMER exists
> NOTICE seems okay
> LICENSE seems okay
> no unexpected binary files
>
> Mentoring notes:
> * You should minimise changes to KEYS since ideally each release manager
> would attend a key-signing party and have their key spread amongst other
> trusted parties. Then verifiers could verify that the release has been
> signed not only with a valid key but also from a trusted source. Key
> signing would need to be repeated each time a release manager's key
> changes. Key signing isn't mandatory, just highly recommended, but isn't
> easy to do right now due to COVID.
> * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE
> and NOTICE, thanks) if the statement "Code almost entirely based on work of
> ..." is indeed true, then I believe it is usually clearer to leave the
> original license header in the source file and perhaps amend with
> "Subsequent changes Copyright by the NLPCraft team and made under the
> ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
> but my understanding is that you have the obligation to make it clear that
> the requirements the original author requested for use of that file in
> source form etc. are still in play and aren't overwritten by slapping the
> ASLv2 header at the front of the file.
>
> Cheers, Paul.
>
>
> On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <ar...@datalingvo.com>
> wrote:
>
>> NLPCraft-ers,
>> This is a call for a vote to release Apache NLPCraft (incubating) version
>> 0.7.1. This release includes bug fixes and incremental improvements for
>> NLPCraft 0.7.0 release.
>>
>> Release information:
>> 1. Release location:
>> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
>> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
>> 4. JIRA issues fixed in release:
>> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
>> 5. KEYS file:
>> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>>
>> The vote will be open for at least 72 hours or until a necessary number of
>> votes are reached.
>>
>> Please vote accordingly:
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thank you,
>> Aaron (NLPCraft community).
>>
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Paul King <pa...@asert.com.au>.
+1
Checked hashes and signatures.
"mvn clean verify" passes
"mvn apache-rat:rat" passes
incubating in name
DISCLAIMER exists
NOTICE seems okay
LICENSE seems okay
no unexpected binary files
Mentoring notes:
* You should minimise changes to KEYS since ideally each release manager
would attend a key-signing party and have their key spread amongst other
trusted parties. Then verifiers could verify that the release has been
signed not only with a valid key but also from a trusted source. Key
signing would need to be repeated each time a release manager's key
changes. Key signing isn't mandatory, just highly recommended, but isn't
easy to do right now due to COVID.
* For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and
NOTICE, thanks) if the statement "Code almost entirely based on work of
..." is indeed true, then I believe it is usually clearer to leave the
original license header in the source file and perhaps amend with
"Subsequent changes Copyright by the NLPCraft team and made under the
ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
but my understanding is that you have the obligation to make it clear that
the requirements the original author requested for use of that file in
source form etc. are still in play and aren't overwritten by slapping the
ASLv2 header at the front of the file.
Cheers, Paul.
On Thu, Oct 22, 2020 at 2:35 AM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.1. This release includes bug fixes and incremental improvements for
> NLPCraft 0.7.0 release.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Sergey Makov <sm...@apache.org>.
+1
- mvn clean package verify (MacOS)
- signatures
Thanks,
Sergey
On Thu, Oct 22, 2020 at 9:20 PM Nikita Ivanov <ni...@gmail.com> wrote:
>
> +1
>
> - sigs
> - mvn clean package verify (Win10/MacOS/Ubuntu 20.04)
> - apache RAT
> --
> Nikita Ivanov
>
>
> On Thu, Oct 22, 2020 at 10:25 AM Sergey Kamov <sk...@gmail.com> wrote:
>
> > +1
> >
> > checked files, `mvn verify`, tests
> >
> >
> > Regards,
> >
> > Sergey
> >
> > 21.10.2020 19:35, Aaron Radzinski пишет:
> > > NLPCraft-ers,
> > > This is a call for a vote to release Apache NLPCraft (incubating) version
> > > 0.7.1. This release includes bug fixes and incremental improvements for
> > > NLPCraft 0.7.0 release.
> > >
> > > Release information:
> > > 1. Release location:
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > > 4. JIRA issues fixed in release:
> > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > > 5. KEYS file:
> > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >
> > > The vote will be open for at least 72 hours or until a necessary number
> > of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thank you,
> > > Aaron (NLPCraft community).
> > >
> >
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Nikita Ivanov <ni...@gmail.com>.
+1
- sigs
- mvn clean package verify (Win10/MacOS/Ubuntu 20.04)
- apache RAT
--
Nikita Ivanov
On Thu, Oct 22, 2020 at 10:25 AM Sergey Kamov <sk...@gmail.com> wrote:
> +1
>
> checked files, `mvn verify`, tests
>
>
> Regards,
>
> Sergey
>
> 21.10.2020 19:35, Aaron Radzinski пишет:
> > NLPCraft-ers,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.7.1. This release includes bug fixes and incremental improvements for
> > NLPCraft 0.7.0 release.
> >
> > Release information:
> > 1. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > Aaron (NLPCraft community).
> >
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.7.1
Posted by Sergey Kamov <sk...@gmail.com>.
+1
checked files, `mvn verify`, tests
Regards,
Sergey
21.10.2020 19:35, Aaron Radzinski пишет:
> NLPCraft-ers,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.7.1. This release includes bug fixes and incremental improvements for
> NLPCraft 0.7.0 release.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.1/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.1
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347777
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Aaron (NLPCraft community).
>