[jira] [Commented] (ROCKETMQ-239) Query message by time and get queue offset by time return is always less than want.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290403#comment-16290403 ] 

ASF GitHub Bot commented on ROCKETMQ-239:
-----------------------------------------

lindzh commented on a change in pull request #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time
URL: https://github.com/apache/rocketmq/pull/129#discussion_r156863055
 
 

 ##########
 File path: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
 ##########
 @@ -151,7 +151,7 @@ public void recover() {
         }
     }
 
-    public long getOffsetInQueueByTime(final long timestamp) {
+    public long getOffsetInQueueByTime(final long timestamp, boolean isGetTimeLast) {
         MappedFile mappedFile = this.mappedFileQueue.getMappedFileByTime(timestamp);
 
 Review comment:
   Thanks for you advice,I will check it later.If exist i will change it in the next commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Query message by time and get queue offset by time return is always less than want. 
> ------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-239
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-239
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-store
>    Affects Versions: 4.1.0-incubating
>            Reporter: lindzh
>            Assignee: yukon
>             Fix For: 4.3.0
>
>
> When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime , DefaultMessageStore return offset is not so accurate as we want.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)