You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/19 06:38:58 UTC
[GitHub] [maven-surefire] andpab opened a new pull request, #585: [SUREFIRE-2136] Rename test dir that contains colon
andpab opened a new pull request, #585:
URL: https://github.com/apache/maven-surefire/pull/585
In the UmlautDirIT two special directories are created that have a colon character in the name. This causes problems with the artifact upload of the Github actions, so we rename those directories at the end of the test to something without a colon character in it.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #585: [SUREFIRE-2136] Rename test dir that contains colon
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #585:
URL: https://github.com/apache/maven-surefire/pull/585#discussion_r1051938452
##########
surefire-its/src/test/java/org/apache/maven/surefire/its/UmlautDirIT.java:
##########
@@ -112,19 +114,29 @@ public void surefire1617WithColonInLocalRepo()
.executeTest()
.verifyErrorFreeLog()
.assertTestSuiteResults( 1, 0, 0, 0 );
+
+ String unproblematicDirName = "surefire-1617-colon-in-local-repo_renamed-after-test";
+ Path localRepoDirWithUnproblematicName = localRepoDirWithColonInName.resolveSibling( unproblematicDirName );
+ Files.move( localRepoDirWithColonInName, localRepoDirWithUnproblematicName );
Review Comment:
We should put it in a final section to allow works also when test fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #585: [SUREFIRE-2136] Rename test dir that contains colon
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #585:
URL: https://github.com/apache/maven-surefire/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a diff in pull request #585: [SUREFIRE-2136] Rename test dir that contains colon
Posted by GitBox <gi...@apache.org>.
andpab commented on code in PR #585:
URL: https://github.com/apache/maven-surefire/pull/585#discussion_r1051986956
##########
surefire-its/src/test/java/org/apache/maven/surefire/its/UmlautDirIT.java:
##########
@@ -112,19 +114,29 @@ public void surefire1617WithColonInLocalRepo()
.executeTest()
.verifyErrorFreeLog()
.assertTestSuiteResults( 1, 0, 0, 0 );
+
+ String unproblematicDirName = "surefire-1617-colon-in-local-repo_renamed-after-test";
+ Path localRepoDirWithUnproblematicName = localRepoDirWithColonInName.resolveSibling( unproblematicDirName );
+ Files.move( localRepoDirWithColonInName, localRepoDirWithUnproblematicName );
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org