You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/03 09:22:07 UTC
[GitHub] [spark] gengliangwang opened a new pull request #34796: [SPARK-37533][SQL]New SQL function: try_element_at
gengliangwang opened a new pull request #34796:
URL: https://github.com/apache/spark/pull/34796
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add New SQL functions `try_element_at`, which is identical to the `element_at` except that it returns null if error occurs
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
After some data science on real world SQL queries, we found that some users are using the following queries
```
select ... where mapCol.key is not null
select ... where arrayCol[index] is not null
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, an alternative function `try_element_at` which will return null on array index out of bound or map key doesn't exist under ANSI mode.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985375204
**[Test build #145896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145896/testReport)** for PR 34796 at commit [`eea0910`](https://github.com/apache/spark/commit/eea0910f8fcdd3c2bd00927f541f45f09c0ce948).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985408190
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34796: [SPARK-37533][SQL]New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985375019
cc @cloud-fan @entong @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985446086
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985455528
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145893/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986027490
**[Test build #145921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145921/testReport)** for PR 34796 at commit [`cd76350`](https://github.com/apache/spark/commit/cd763506e46ab44c10c113dc7c69b100e3ae1474).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985442251
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985611742
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL]New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985367337
**[Test build #145893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145893/testReport)** for PR 34796 at commit [`38f2fab`](https://github.com/apache/spark/commit/38f2fabc4787c7fbe647aec439ea6b3c27b75a3d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985410863
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL]New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985375204
**[Test build #145896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145896/testReport)** for PR 34796 at commit [`eea0910`](https://github.com/apache/spark/commit/eea0910f8fcdd3c2bd00927f541f45f09c0ce948).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985482655
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145896/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986020585
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50397/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #34796:
URL: https://github.com/apache/spark/pull/34796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34796:
URL: https://github.com/apache/spark/pull/34796#discussion_r761967943
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -296,7 +296,7 @@ case class Elt(
val index = indexObj.asInstanceOf[Int]
if (index <= 0 || index > inputExprs.length) {
if (failOnError) {
- throw QueryExecutionErrors.invalidArrayIndexError(index, inputExprs.length)
+ throw QueryExecutionErrors.invalidStringIndexError(index, inputExprs.length)
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985662679
**[Test build #145902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145902/testReport)** for PR 34796 at commit [`9d09ee1`](https://github.com/apache/spark/commit/9d09ee15ba3098cebc817a3a36cae0bd6b3ab973).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985569589
**[Test build #145902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145902/testReport)** for PR 34796 at commit [`9d09ee1`](https://github.com/apache/spark/commit/9d09ee15ba3098cebc817a3a36cae0bd6b3ab973).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986046776
Thanks for the review.
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985455528
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145893/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985646975
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #34796:
URL: https://github.com/apache/spark/pull/34796#discussion_r762175325
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -348,11 +348,13 @@ case class Elt(
}.mkString)
val indexOutOfBoundBranch = if (failOnError) {
+ // scalastyle:off line.size.limit
s"""
|if (!$indexMatched) {
- | throw QueryExecutionErrors.invalidArrayIndexError(${index.value}, ${inputExprs.length});
+ | throw QueryExecutionErrors.invalidStringIndexError(${index.value}, ${inputExprs.length});
Review comment:
`invalidInputIndexError`
##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -82,6 +82,9 @@
"message" : [ "The fraction of sec must be zero. Valid range is [0, 60]. If necessary set %s to false to bypass this error. " ],
"sqlState" : "22023"
},
+ "INVALID_INPUT_INDEX" : {
Review comment:
Do we need to add a new error? The error message here seems a little inconsistent between map and array access using `[]` operator:
```
SELECT array(1,2,3)[3]; // Do not hint `try_element_at`
SELECT map('a', 1, 'b', 2)['c']; // Hint `try_element_at`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985663667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985660357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985660357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34796:
URL: https://github.com/apache/spark/pull/34796#discussion_r761946227
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -296,7 +296,7 @@ case class Elt(
val index = indexObj.asInstanceOf[Int]
if (index <= 0 || index > inputExprs.length) {
if (failOnError) {
- throw QueryExecutionErrors.invalidArrayIndexError(index, inputExprs.length)
+ throw QueryExecutionErrors.invalidStringIndexError(index, inputExprs.length)
Review comment:
the name `StringIndex` is a bit misleading. how about `InputIndex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986028497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145921/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986028497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145921/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985449720
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #34796:
URL: https://github.com/apache/spark/pull/34796#discussion_r762181023
##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -82,6 +82,9 @@
"message" : [ "The fraction of sec must be zero. Valid range is [0, 60]. If necessary set %s to false to bypass this error. " ],
"sqlState" : "22023"
},
+ "INVALID_INPUT_INDEX" : {
Review comment:
Do we need to add a new error? The error message here seems a little inconsistent between map and array access using `[]` operator:
```
SELECT array(1,2,3)[3]; // Do not hint `try_element_at`
SELECT map('a', 1, 'b', 2)['c']; // Hint `try_element_at`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985459940
**[Test build #145896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145896/testReport)** for PR 34796 at commit [`eea0910`](https://github.com/apache/spark/commit/eea0910f8fcdd3c2bd00927f541f45f09c0ce948).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985663667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986008261
**[Test build #145921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145921/testReport)** for PR 34796 at commit [`cd76350`](https://github.com/apache/spark/commit/cd763506e46ab44c10c113dc7c69b100e3ae1474).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985455267
**[Test build #145893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145893/testReport)** for PR 34796 at commit [`38f2fab`](https://github.com/apache/spark/commit/38f2fabc4787c7fbe647aec439ea6b3c27b75a3d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class TryElementAt(left: Expression, right: Expression, child: Expression)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985367337
**[Test build #145893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145893/testReport)** for PR 34796 at commit [`38f2fab`](https://github.com/apache/spark/commit/38f2fabc4787c7fbe647aec439ea6b3c27b75a3d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985449720
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986019916
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50397/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986020585
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50397/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986012941
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50397/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-986008261
**[Test build #145921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145921/testReport)** for PR 34796 at commit [`cd76350`](https://github.com/apache/spark/commit/cd763506e46ab44c10c113dc7c69b100e3ae1474).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985569589
**[Test build #145902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145902/testReport)** for PR 34796 at commit [`9d09ee1`](https://github.com/apache/spark/commit/9d09ee15ba3098cebc817a3a36cae0bd6b3ab973).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985446086
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985449682
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34796:
URL: https://github.com/apache/spark/pull/34796#issuecomment-985482655
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145896/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org