You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/13 05:41:37 UTC

[GitHub] [incubator-inlong] shink opened a new pull request, #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

shink opened a new pull request, #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654

   Fixes #4653
   
   ### Motivation
   
   Add concurrency support on GitHub Actions
   
   ### Modifications
   
   Add concurrency support on GitHub Actions.
   See https://docs.github.com/en/actions/using-jobs/using-concurrency for more information.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#issuecomment-1153567197

   @dockerzhang OK.
   BTW, I don't think the `master` branch can be force updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on a diff in pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#discussion_r896580167


##########
.github/workflows/ci_docker.yml:
##########
@@ -73,6 +77,13 @@ jobs:
         env:
           CI: false
 
+      # Check if only the workflow file is changed.
+      - name: Check workflow diff
+        id: check-workflow-diff
+        uses: apache/pulsar-test-infra/diff-only@master
+        with:
+          args: .github/workflows/ci_docker.yml
+

Review Comment:
   The `apache/pulsar-test-infradiff-only` action is used here. See https://github.com/apache/pulsar-test-infra/tree/master/diff-only for more information.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang commented on pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#issuecomment-1153565153

   @shink please rebase from master firstly, thanks.
   ![image](https://user-images.githubusercontent.com/18047329/173300641-d3ba122f-5549-4eaa-9784-b0767199c966.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#issuecomment-1153582514

   It works.
   See this commit: https://github.com/apache/incubator-inlong/pull/4654/commits/2c906a755fc1fceb782686704270d71f9f2495b0
   
   ![image](https://user-images.githubusercontent.com/49934421/173303840-057c70bd-108d-4ad8-90cf-40da01b21935.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on a diff in pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#discussion_r896580167


##########
.github/workflows/ci_docker.yml:
##########
@@ -73,6 +77,13 @@ jobs:
         env:
           CI: false
 
+      # Check if only the workflow file is changed.
+      - name: Check workflow diff
+        id: check-workflow-diff
+        uses: apache/pulsar-test-infra/diff-only@master
+        with:
+          args: .github/workflows/ci_docker.yml
+

Review Comment:
   The `apache/pulsar-test-infra/diff-only` action is used here. See https://github.com/apache/pulsar-test-infra/tree/master/diff-only for more information.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#issuecomment-1154925888

   @dockerzhang I know. I mean the `master` branch should not be force-updated. It will cause additional work for all developers. This is a default norm.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] shink commented on a diff in pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#discussion_r896389773


##########
.github/workflows/ci_docker.yml:
##########
@@ -90,7 +97,10 @@ jobs:
           fi
 
       - name: Push Docker images to Docker Hub
-        if: ${{ success() && steps.match-branch.outputs.match == 'true' }}
+        if: |
+          success()
+          && steps.check-workflow-diff.outputs.changed_only == 'no'
+          && steps.match-branch.outputs.match == 'true'

Review Comment:
   If only the workflow file (`.github/workflows/ci_docker.yml`) is changed, there is no need to publish images.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang commented on pull request #4654: [INLONG-4653][CI] Add concurrency support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #4654:
URL: https://github.com/apache/incubator-inlong/pull/4654#issuecomment-1154900589

   > @dockerzhang OK. BTW, I don't think the `master` branch can be force updated.
   
   force update your PR branch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org