You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jf...@apache.org on 2011/11/05 14:16:35 UTC
svn commit: r1197955 -
/thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc
Author: jfarrell
Date: Sat Nov 5 13:16:34 2011
New Revision: 1197955
URL: http://svn.apache.org/viewvc?rev=1197955&view=rev
Log:
Thrift-1277: Node.js serializes false booleans as null
Client: js
Patch: Hans Duedal
When serializing boolean types, false booleans are serialized as null instead of false switching to using loose compare instead
Modified:
thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc
Modified: thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc
URL: http://svn.apache.org/viewvc/thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc?rev=1197955&r1=1197954&r2=1197955&view=diff
==============================================================================
--- thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc (original)
+++ thrift/trunk/compiler/cpp/src/generate/t_js_generator.cc Sat Nov 5 13:16:34 2011
@@ -688,7 +688,7 @@ void t_js_generator::generate_js_struct_
indent(out) << "output.writeStructBegin('" << name << "');" << endl;
for (f_iter = fields.begin(); f_iter != fields.end(); ++f_iter) {
- out << indent() << "if (this." << (*f_iter)->get_name() << ") {" << endl;
+ out << indent() << "if (this." << (*f_iter)->get_name() << " != null) {" << endl;
indent_up();
indent(out) <<