You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/14 19:21:27 UTC
[jira] [Commented] (TS-4535) segfault in hostdb for serve_stale_for
with no hostname
[ https://issues.apache.org/jira/browse/TS-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330222#comment-15330222 ]
ASF GitHub Bot commented on TS-4535:
------------------------------------
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/714
TS-4535 fix segfault in hostdb for serve_stale_for with no hostname
Not all requests have host_name (such as reverse lookups) -- but we want to serve stale but revalidate for all of them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver TS-4535
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #714
----
commit 26fad35524584a4cd9dc13c26b2a9b9f1c160abb
Author: Thomas Jackson <ja...@gmail.com>
Date: 2016-06-14T19:20:14Z
TS-4535 fix segfault in hostdb for serve_stale_for with no hostname
Not all requests have host_name (such as reverse lookups) -- but we want to serve stale but revalidate for all of them
----
> segfault in hostdb for serve_stale_for with no hostname
> -------------------------------------------------------
>
> Key: TS-4535
> URL: https://issues.apache.org/jira/browse/TS-4535
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
> Reporter: Thomas Jackson
> Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> Before starting the background continuation to refresh the IP hostdb attempts to verify that the request is `!is_dotted_form_hostname`, in the reverse-dns case there is no hostname so the method segfaults. Regardless of format, if the record is expired and we are configured to serve stale while revalidating-- we should do just that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)