[GitHub] [flink] wangyang0918 commented on a change in pull request #14570: [FLINK-20798][k8s] Use namespaced kubernetes client when creating FlinkKubeClient

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #14570:
URL: https://github.com/apache/flink/pull/14570#discussion_r553836507



##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClientTest.java
##########
@@ -456,6 +461,20 @@ public void testCheckAndUpdateConfigMapWhenReplaceConfigMapFailed() throws Excep
         }
     }
 
+    @Test
+    public void testWatchConfigMaps() throws Exception {
+        flinkKubeClient.watchConfigMaps(TESTING_CONFIG_MAP_NAME, new NoOpWatchCallbackHandler<>());

Review comment:
       I also have this concern. And that is why I did not add the unit test at the very begging. Making `KubernetesMockServer` work with a real `KubeClient` is not very easy. I will try to dig more.
   
   If we could not git it done, I will add an integration test using `minikube` and a real `KubeClient`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org