[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #335: GUACAMOLE-1307: Use VerifyCertificateEx callback if supported.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #335:
URL: https://github.com/apache/guacamole-server/pull/335#discussion_r591782908



##########
File path: configure.ac
##########
@@ -897,6 +897,14 @@ then
                      [[#include <freerdp/freerdp.h>]])
 fi
 
+# Updated certificate verification callback (introduced with 2.0.0, not present
+# in 2.0.0-rc4 or earlier)
+if test "x${have_freerdp2}" = "xyes"
+then
+    AC_CHECK_MEMBERS([freerdp.VerifyCertificateEx],,,
+                     [[#include <freerdp/freerdp.h>]])
+fi
+

Review comment:
       `AC_CHECK_MEMBERS` will automatically define its own macro based on the name of the structure and member provided. For example:
   
   https://github.com/apache/guacamole-server/blob/e2a136f41e729a80f14ef479321ab8a5d753e6d2/configure.ac#L888-L897
   
   The above call results in the following within `config.h` when the check passes:
   
   ```c
   /* Define to 1 if `AllowUnanouncedOrdersFromServer' is a member of
      `rdpSettings'. */
   #define HAVE_RDPSETTINGS_ALLOWUNANOUNCEDORDERSFROMSERVER 1
   ```
   
   From https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Generic-Structures.html:
   
   > ... When _member_ belongs to _aggregate_, define HAVE_aggregate_member (in all capitals, with spaces and dots replaced by underscores). ...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org