You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:18:01 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #21501: Improve consistency check job stop/cancel/progress
sandynz opened a new pull request, #21501:
URL: https://github.com/apache/shardingsphere/pull/21501
Changes proposed in this pull request:
- Fix getJobProgressInfo when check job is stopped
- Ignore exception persistence when check canceling
- Clean error message before checking
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #21501: Improve consistency check job stop/cancel/progress
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #21501:
URL: https://github.com/apache/shardingsphere/pull/21501#issuecomment-1274479492
When consistency check job is stopped, `remaining_seconds` and `duration_seconds` will not growing again, and `check_end_time` will use job stopped time.
The result is consistent if we run this DistSQL several times:
```
mysql> show migration check status 'j0101270cbb6714cff0d7d13db9fa23c7c0a1';
+---------+--------+---------------------+-------------------+-------------------------+-------------------------+------------------+---------------+
| tables | result | finished_percentage | remaining_seconds | check_begin_time | check_end_time | duration_seconds | error_message |
+---------+--------+---------------------+-------------------+-------------------------+-------------------------+------------------+---------------+
| sbtest1 | false | 45 | 421 | 2022-10-11 18:03:20.956 | 2022-10-11 18:09:09.686 | 348 | |
+---------+--------+---------------------+-------------------+-------------------------+-------------------------+------------------+---------------+
1 row in set (0.01 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21501: Improve consistency check job stop/cancel/progress
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21501:
URL: https://github.com/apache/shardingsphere/pull/21501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org