You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bruno Busco (JIRA)" <ji...@apache.org> on 2009/02/22 16:11:02 UTC
[jira] Created: (OFBIZ-2201) Theme component should be loaded after
applications component
Theme component should be loaded after applications component
-------------------------------------------------------------
Key: OFBIZ-2201
URL: https://issues.apache.org/jira/browse/OFBIZ-2201
Project: OFBiz
Issue Type: Improvement
Reporter: Bruno Busco
In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
In EcommerceTypeData.xml:
<VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
The multiflex theme is defined as:
<VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2201) Theme component should be loaded after
applications component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2201.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Bruno Busco
Thanks Bruno,
Your patch is in trunk at r746905
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2201) Theme component should be loaded after
applications component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2201.
----------------------------------
Resolution: Fixed
Thanks Bruno,
Your patch is in trunk at revision: 748333
I close, if needed could be reopened anyway
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: betterSolution.patch, themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2201) Theme component should be loaded
after applications component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676944#action_12676944 ]
Jacques Le Roux commented on OFBIZ-2201:
----------------------------------------
I know the MULTIFLEX theme is new an experimental. I just wanted to note here that client order view is ugly even in FF3
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2201) Theme component should be loaded
after applications component
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677221#action_12677221 ]
David E. Jones commented on OFBIZ-2201:
---------------------------------------
Don't worry too much about something that says "ECOMMERCE" existing in the framework. The framework has lots of resources that support ecommerce sites. Consider that we could have also have theme sets for things like managed content sites, blog/forum only sites, partner/supplier/customer/etc access sites, and so on.
Right now we also have special stylesheets and such in the framework that are used by ecommerce, but that is something that we have discussed changing. We haven't changed it because we want all static content like that to be in a single place so that it is easy to change the contentUrl prefix in the url.properties file (or on the WebSite entity) and have the content moved to another server, like a static file web server or a service like Akamai.
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: betterSolution.patch, themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2201) Theme component should be loaded
after applications component
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677103#action_12677103 ]
Bruno Busco commented on OFBIZ-2201:
------------------------------------
Sorry for not having replied soon to this.
I have tried to find a solution but not found a no-drawback one.
I think the solution to have the "ECOMMERCE" VisualThemeSet definition in the framework is the best one even if I do not like the idea of the esistence of an "ECOMMERCE" VisualThemeSet in a framework-only installation.
Unfortunately this is a must if we want the framework only installation have the whole themes folder deployed and only the application and specialpurpose folder removed.
If no objections I will go for this solution and submit a patch.
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2201) Theme component should be loaded after
applications component
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-2201:
-------------------------------
Attachment: betterSolution.patch
Please find attached the "Better Solution" patch ;-)
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: betterSolution.patch, themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-2201) Theme component should be loaded
after applications component
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reopened OFBIZ-2201:
--------------------------------------
Maybe there are better solutions to this, for example:
a) move the VisualThemeSet from ecommerce to the specific theme folder
b) or use the following entry in the theme folder:
<VisualTheme visualThemeId="MULTIFLEX" description="Alternative VisualTheme for Ecommerce"/ >
and the following in ecommerce:
<VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
<VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE"/ >
The main concern I have with the patch that has been committed is that it will break the run-install target for framework only (no applications folder) builds.
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2201) Theme component should be loaded after
applications component
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-2201:
-------------------------------
Attachment: themeload.patch
The attached patch fixes the issue
> Theme component should be loaded after applications component
> -------------------------------------------------------------
>
> Key: OFBIZ-2201
> URL: https://issues.apache.org/jira/browse/OFBIZ-2201
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Bruno Busco
> Attachments: themeload.patch
>
>
> In the ecommerce application a specific (to the ecommerce application) VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE" description="ECommerce Visual Themes"/>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>
> When doing "ant run-install" for the first time the visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity gets created.
> This is the reason I think themes should be loaded AFTER the applications because, actually, they apply ON applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.