You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/06/19 13:39:47 UTC

[GitHub] [hive] Xiwu1994 opened a new pull request #837: CliDriver skipping through comments

Xiwu1994 opened a new pull request #837:
URL: https://github.com/apache/hive/pull/837


   two examples of errors:
   
   case1.hql
   ``` sql
   -- 1
     -- 1;
   select 1;
   ```
   
   case2.hql
   ``` sql
   -- 1
     -- 1
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] github-actions[bot] commented on pull request #837: CliDriver skipping through comments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #837:
URL: https://github.com/apache/hive/pull/837#issuecomment-684124284


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] github-actions[bot] closed pull request #837: CliDriver skipping through comments

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #837:
URL: https://github.com/apache/hive/pull/837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] belugabehr commented on pull request #837: CliDriver skipping through comments

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #837:
URL: https://github.com/apache/hive/pull/837#issuecomment-639057217


   Technically, Hive no longer is going to support the CLI, but I until it's removed, I can entertain adding small fixes like this.
   
   Can you please open a JIRA for this, create a git branch with the JIRA ID (HIVE-xxxx) and then make the commit message: "HIVE-xxxx: Trim Lines To detect comments"?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] belugabehr commented on a change in pull request #837: CliDriver skipping through comments

Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #837:
URL: https://github.com/apache/hive/pull/837#discussion_r435486685



##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -490,7 +490,7 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
 
     while ((line = r.readLine()) != null) {
       // Skipping through comments
-      if (! line.startsWith("--")) {
+      if (! line.trim().startsWith("--")) {
         qsb.append(line + "\n");

Review comment:
       Can you also please change this to...
   
   ```
   qsb.append(line).append("\n");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] belugabehr closed pull request #837: CliDriver skipping through comments

Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #837:
URL: https://github.com/apache/hive/pull/837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org