You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2017/02/15 18:06:38 UTC
[GitHub] flink pull request #3328: [FLINK-5812] [core] Cleanups in the FileSystem cla...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/3328
[FLINK-5812] [core] Cleanups in the FileSystem class
The FileSystem class is overloaded and has methods that are not well supported.
This pull request does the following cleanups:
Commit 1:
- Pull the safety net into a separate class
- Extend the docs of the safety net.
Commit 2:
- Use the `WriteMode` to indicate overwriting behavior. Right now, the `FileSystem` class defines that enum and never uses it. It feels weird.
- Remove the method `FsDataOutputStream create(path, overwrite, blocksize, replication, ...)`, which is not really supported across file system implementations. For HDFS, the behavior should be set via the configuration anyways.
All changes have to be made in a non-API-breaking fashion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink fs_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3328
----
commit 6c86f901427d4bb077f27c84c90abeafec019449
Author: Stephan Ewen <se...@apache.org>
Date: 2017-02-15T16:10:53Z
[FLINK-5812] [core] Cleanups in FileSystem (round 1)
- This makes the FileSystem use the 'WriteMode' (otherwise it was an unused enumeration)
- Extends comments
- Deprecate the method that controls the replication factor and block size
commit 83578e2b8e2e1ca03b14e8d47f7a122aa07fd517
Author: Stephan Ewen <se...@apache.org>
Date: 2017-02-15T16:58:37Z
[FLINK-5812] [core] Cleanups in FileSystem (round 2)
Move the FileSystem safety net to a separate class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3328: [FLINK-5812] [core] Cleanups in the FileSystem class
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3328
Yes, it was accidentally merged together with another PR.
Since the changes were mostly comments and annotations, it should not be a problem.
Closing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3328: [FLINK-5812] [core] Cleanups in the FileSystem cla...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/3328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3328: [FLINK-5812] [core] Cleanups in the FileSystem class
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3328
@StephanEwen Can this PR be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---