[GitHub] [daffodil] stevedlawrence commented on pull request #977: Add WarnID to Schema Definition Warning messages

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on PR #977:
URL: https://github.com/apache/daffodil/pull/977#issuecomment-1453878934

   > Can I get a second committer to agree about 1) removing all SDW macros/methods that don't take a WarnID, and 2) renaming the schemaDefinitionWarningWhen/Unless methods to SDWwhen/SDWunless to make it easier to find all SDW calls with a single grep for "SDW"?
   
   Both changes seem like good improvements to me. We might also want to shorten `schemaDefinitionUnless` and `schemaDefintionWhen` and make everything consistent. I also kindof like an alternative capitalization of `sdwWhen` vs `SDWwhen`, but don't feel strongly about it. Though we might want to do all the renaming of stuff in a separate PR though, as it's creeping outside the scope just including warnID in messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org