You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/07 20:58:36 UTC

[GitHub] [thrift] fishy opened a new pull request #2172: THRIFT-5214: Push read deadline in socketConn

fishy opened a new pull request #2172:
URL: https://github.com/apache/thrift/pull/2172


   Client: go
   
   We added socketConn to go library for connectivity check in
   https://github.com/apache/thrift/pull/2153, but forgot to push read
   deadline on the socket when doing the connectivity checks. This caused
   the issue of large number of connectivity checks to fail with I/O
   timeout errors.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2172: THRIFT-5214: Push read deadline in socketConn

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2172:
URL: https://github.com/apache/thrift/pull/2172#issuecomment-640590661


   Must have missed it :) Travis failures are unrelated so LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2172: THRIFT-5214: Push read deadline in socketConn

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2172:
URL: https://github.com/apache/thrift/pull/2172#issuecomment-640585210


   @dcelasun that was already fixed in the force pushed new version :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2172: THRIFT-5214: Push read deadline in socketConn

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2172:
URL: https://github.com/apache/thrift/pull/2172#issuecomment-640285203


   @dcelasun :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun merged pull request #2172: THRIFT-5214: Push read deadline in socketConn

Posted by GitBox <gi...@apache.org>.
dcelasun merged pull request #2172:
URL: https://github.com/apache/thrift/pull/2172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2172: THRIFT-5214: Push read deadline in socketConn

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2172:
URL: https://github.com/apache/thrift/pull/2172#issuecomment-640501867


   This broke tests:
   
   ```
   panic: runtime error: invalid memory address or nil pointer dereference
   [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x6c99cd]
   
   goroutine 1 [running]:
   thrift.NewTSSLSocketTimeout(...)
   	/thrift/src/test/go/src/thrift/ssl_socket.go:56
   thrift.NewTSSLSocket(...)
   	/thrift/src/test/go/src/thrift/ssl_socket.go:46
   common.StartClient(0x77a80a, 0x9, 0xa671, 0x0, 0x0, 0x7ffdc5b07c19, 0x8, 0x7ffdc5b07c06, 0x6, 0xc000084c01, ...)
   	/thrift/src/test/go/src/common/client.go:67 +0xccd
   main.main()
   	/thrift/src/test/go/src/bin/testclient/main.go:43 +0x108
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org