[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

[GitBox <gi...@apache.org>]

vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.
URL: https://github.com/apache/drill/pull/1387#discussion_r203543266
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHelper.java
 ##########
 @@ -48,13 +48,19 @@ static boolean isAllNulls(Statistics stat, long rowCount) {
   }
 
   /**
-   * Checks that column chunk's statistics does not have nulls
+   * Checks that column chunk's statistics does not have nulls.
+   *
+   * <ul>
+   * <li>If number of nulls is more then 0, it means column has nulls.</li>
+   * <li>If number of nulls is less then zero (usually -1), it means that stats are unavailable.</li>
 
 Review comment:
   Please see the documentation for `getNumNulls()`. In case the number of nulls is not set it is `-1`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services