You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "smbecker (via GitHub)" <gi...@apache.org> on 2026/04/21 17:56:38 UTC
[PR] Add cert annotation configuration [pulsar-helm-chart]
smbecker opened a new pull request, #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673
### Motivation
This PR adds the ability to customize the annotations that are applied to the certificates that are generated by cert-manager. This can be useful for allowing tools like [reflector](https://github.com/emberstack/kubernetes-reflector) to propagate the certificate secrets to required namespaces.
### Modifications
Modifies the cert generation template to look for `annotations` property that gets merged into the `secretTemplate.annotations` property on the cert spec.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add cert annotation configuration [pulsar-helm-chart]
Posted by "smbecker (via GitHub)" <gi...@apache.org>.
smbecker commented on code in PR #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673#discussion_r3120797838
##########
charts/pulsar/templates/_certs.tpl:
##########
@@ -75,6 +75,10 @@ metadata:
labels:
{{- include "pulsar.standardLabels" .root | nindent 4 }}
spec:
+{{- if .tlsConfig.secretAnnotations }}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add cert annotation configuration [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673#discussion_r3120451355
##########
charts/pulsar/templates/_certs.tpl:
##########
@@ -75,6 +75,10 @@ metadata:
labels:
{{- include "pulsar.standardLabels" .root | nindent 4 }}
spec:
+{{- if .tlsConfig.secretAnnotations }}
Review Comment:
please also add a `secretAnnotations` config to `.ci/clusters/values-tls.yaml` to exercise this in CI. We don't have great validation for all features, so it's fine to just add the annotations to let's say `tls.proxy.secretAnnotations` in `.ci/clusters/values-tls.yaml` to validate that it doesn't error out after adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add cert annotation configuration [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add cert annotation configuration [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #673:
URL: https://github.com/apache/pulsar-helm-chart/pull/673#discussion_r3120432558
##########
charts/pulsar/templates/_certs.tpl:
##########
@@ -75,6 +75,10 @@ metadata:
labels:
{{- include "pulsar.standardLabels" .root | nindent 4 }}
spec:
+{{- if .tlsConfig.secretAnnotations }}
Review Comment:
Please document this by adding commented out lines in `charts/pulsar/values.yaml` for at least one of the "tlsConfigs" under the `tls:` key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org