You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/30 02:13:57 UTC

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5052: Use focal release for travis ci

ningyougang commented on code in PR #5052:
URL: https://github.com/apache/openwhisk/pull/5052#discussion_r933708338


##########
tests/src/test/scala/org/apache/openwhisk/core/admin/WskAdminTests.scala:
##########
@@ -252,7 +252,8 @@ class WskAdminTests extends TestHelpers with WskActorSystem with Matchers with B
       // check correctly set
       val lines = wskadmin.cli(Seq("limits", "get", subject)).stdout.linesIterator.toSeq
       lines should have size 1
-      lines(0) shouldBe "allowedKinds = [u'nodejs:10', u'blackbox']"
+      lines(0) should (be("allowedKinds = [u'nodejs:10', u'blackbox']") or be(
+        "allowedKinds = ['nodejs:10', 'blackbox']"))

Review Comment:
   * If use python3 as default: `ln -s  /usr/bin/python3  /usr/bin/python`
      `lines(0)` is `['nodejs:10', 'blackbox']`
   * If use python2 as default: `ln -s  /usr/bin/python2  /usr/bin/python`
      `lines(0)` is `[u'nodejs:10', u'blackbox']`
   So here meets 2 cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org