You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/07/01 17:11:14 UTC
Review Request 36090: Config groups can't be saved in some cases
(additional patch)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36090/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
Repository: ambari
Description
-------
Go to HDFS config page on installed cluster.
Create config group (assigned hosts doesn't matter).
Change config dfs.namenode.handler.count and save. At this time it's ok.
Change dtnode_heapsize and click save. Server returns 500 error with no info about error.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ConfigGroupDAO.java a2dd29b
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 73df75b
Diff: https://reviews.apache.org/r/36090/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 36090: Config groups can't be saved in some cases
(additional patch)
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36090/#review90115
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On July 1, 2015, 7:23 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36090/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 7:23 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Go to HDFS config page on installed cluster.
> Create config group (assigned hosts doesn't matter).
> Change config dfs.namenode.handler.count and save. At this time it's ok.
> Change dtnode_heapsize and click save. Server returns 500 error with no info about error.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 73df75b
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java f1de58e
>
> Diff: https://reviews.apache.org/r/36090/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36090: Config groups can't be saved in some cases
(additional patch)
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36090/
-----------------------------------------------------------
(Updated Июль 1, 2015, 9:15 п.п.)
Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
Repository: ambari
Description
-------
Go to HDFS config page on installed cluster.
Create config group (assigned hosts doesn't matter).
Change config dfs.namenode.handler.count and save. At this time it's ok.
Change dtnode_heapsize and click save. Server returns 500 error with no info about error.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 73df75b
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java f1de58e
Diff: https://reviews.apache.org/r/36090/diff/
Testing (updated)
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.218s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
[INFO] Ambari Web ........................................ SUCCESS [30.363s]
[INFO] Ambari Views ...................................... SUCCESS [1.855s]
[INFO] Ambari Admin View ................................. SUCCESS [8.590s]
[INFO] ambari-metrics .................................... SUCCESS [0.406s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.097s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.691s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.439s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [7.451s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [0.991s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [3:30.517s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [1.311s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:47.330s]
[INFO] Ambari Server ..................................... SUCCESS [1:45:50.989s]
[INFO] Ambari Agent ...................................... SUCCESS [18.725s]
[INFO] Ambari Client ..................................... SUCCESS [0.028s]
[INFO] Ambari Python Client .............................. SUCCESS [0.312s]
[INFO] Ambari Groovy Client .............................. SUCCESS [8.571s]
[INFO] Ambari Shell ...................................... SUCCESS [0.009s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.006s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [5.541s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 36090: Config groups can't be saved in some cases
(additional patch)
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36090/#review90116
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On July 1, 2015, 7:23 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36090/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 7:23 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Go to HDFS config page on installed cluster.
> Create config group (assigned hosts doesn't matter).
> Change config dfs.namenode.handler.count and save. At this time it's ok.
> Change dtnode_heapsize and click save. Server returns 500 error with no info about error.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 73df75b
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java f1de58e
>
> Diff: https://reviews.apache.org/r/36090/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36090: Config groups can't be saved in some cases
(additional patch)
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36090/
-----------------------------------------------------------
(Updated Июль 1, 2015, 7:23 п.п.)
Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
Repository: ambari
Description
-------
Go to HDFS config page on installed cluster.
Create config group (assigned hosts doesn't matter).
Change config dfs.namenode.handler.count and save. At this time it's ok.
Change dtnode_heapsize and click save. Server returns 500 error with no info about error.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java 73df75b
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java f1de58e
Diff: https://reviews.apache.org/r/36090/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen