You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2016/09/12 05:40:20 UTC
[4/5] kudu git commit: linked_list-test: set longer history retention
linked_list-test: set longer history retention
The default 15 minute history retention was causing linked_list-test to
GC some history in the case that -seconds_to_run was set significantly
longer than the default.
This sets the retention to 1 day to prevent such issues.
I also removed an old unused function I noticed while making this
change.
Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Reviewed-on: http://gerrit.cloudera.org:8080/4374
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/455e1b74
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/455e1b74
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/455e1b74
Branch: refs/heads/master
Commit: 455e1b7460984afb9ffcae8cae7bb85b9c0837a7
Parents: cf1bd0d
Author: Todd Lipcon <to...@apache.org>
Authored: Sun Sep 11 15:51:35 2016 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Mon Sep 12 05:38:40 2016 +0000
----------------------------------------------------------------------
src/kudu/integration-tests/linked_list-test.cc | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/455e1b74/src/kudu/integration-tests/linked_list-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/linked_list-test.cc b/src/kudu/integration-tests/linked_list-test.cc
index 111d7d3..04092a1 100644
--- a/src/kudu/integration-tests/linked_list-test.cc
+++ b/src/kudu/integration-tests/linked_list-test.cc
@@ -89,6 +89,10 @@ class LinkedListTest : public tserver::TabletServerIntegrationTestBase {
common_flags.push_back("--skip_remove_old_recovery_dir");
+ // Set history retention to one day, so that we don't GC history in this test.
+ // We rely on verifying "back in time" with snapshot scans.
+ common_flags.push_back("--tablet_history_max_age_sec=86400");
+
vector<string> ts_flags(common_flags);
if (FLAGS_stress_flush_compact) {
// Set the flush threshold low so that we have a mix of flushed and unflushed
@@ -129,16 +133,6 @@ class LinkedListTest : public tserver::TabletServerIntegrationTestBase {
}
protected:
- void AddExtraFlags(const string& flags_str, vector<string>* flags) {
- if (flags_str.empty()) {
- return;
- }
- vector<string> split_flags = strings::Split(flags_str, " ");
- for (const string& flag : split_flags) {
- flags->push_back(flag);
- }
- }
-
shared_ptr<KuduClient> client_;
gscoped_ptr<LinkedListTester> tester_;
};