You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/19 18:04:39 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
xiaoxiang781216 opened a new pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606
## Summary
specified here:
https://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_attr_getdetachstate.html
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606#discussion_r473640293
##########
File path: include/pthread.h
##########
@@ -241,7 +246,7 @@ struct pthread_attr_s
uint8_t priority; /* Priority of the pthread */
uint8_t policy; /* Pthread scheduler policy */
uint8_t inheritsched; /* Inherit parent priority/policy? */
-
+ uint8_t detachstate; /* Initilize to the detach state */
Review comment:
Done.
##########
File path: libs/libc/pthread/pthread_attr_setdetachstate.c
##########
@@ -0,0 +1,58 @@
+/****************************************************************************
+ * libs/libc/pthread/pthread_attr_setdetachstate.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <pthread.h>
+#include <errno.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: pthread_attr_setdetachstate
+ *
+ * Description:
+ * Set the detachstate attribute
+ *
+ * Returned Value:
+ * Upon successful completion, pthread_attr_setdetachstate() shall return
+ * a value of 0; otherwise, an error number shall be returned to indicate
+ * the error.
+ *
+ ****************************************************************************/
+
+int pthread_attr_setdetachstate(FAR pthread_attr_t *attr,
+ int detachstate)
+{
+ if (!attr)
+ {
+ return EINVAL;
+ }
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606#discussion_r473442310
##########
File path: libs/libc/pthread/pthread_attr_setdetachstate.c
##########
@@ -0,0 +1,58 @@
+/****************************************************************************
+ * libs/libc/pthread/pthread_attr_setdetachstate.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <pthread.h>
+#include <errno.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: pthread_attr_setdetachstate
+ *
+ * Description:
+ * Set the detachstate attribute
+ *
+ * Returned Value:
+ * Upon successful completion, pthread_attr_setdetachstate() shall return
+ * a value of 0; otherwise, an error number shall be returned to indicate
+ * the error.
+ *
+ ****************************************************************************/
+
+int pthread_attr_setdetachstate(FAR pthread_attr_t *attr,
+ int detachstate)
+{
+ if (!attr)
+ {
+ return EINVAL;
+ }
Review comment:
> The pthread_attr_setdetachstate() function shall fail if:
[EINVAL]
The value of detachstate was not valid
We need to also check for `detachstate` to be valid, either: PTHREAD_CREATE_DETACHED or PTHREAD_CREATE_JOINABLE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606#discussion_r473455078
##########
File path: libs/libc/pthread/pthread_attr_setdetachstate.c
##########
@@ -0,0 +1,58 @@
+/****************************************************************************
+ * libs/libc/pthread/pthread_attr_setdetachstate.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <pthread.h>
+#include <errno.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: pthread_attr_setdetachstate
+ *
+ * Description:
+ * Set the detachstate attribute
+ *
+ * Returned Value:
+ * Upon successful completion, pthread_attr_setdetachstate() shall return
+ * a value of 0; otherwise, an error number shall be returned to indicate
+ * the error.
+ *
+ ****************************************************************************/
+
+int pthread_attr_setdetachstate(FAR pthread_attr_t *attr,
+ int detachstate)
+{
+ if (!attr)
+ {
+ return EINVAL;
+ }
Review comment:
BTW, just a note: [Issue 7](https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_attr_getdetachstate.html#tag_16_404) specifies that the return is undefined if `attr` is not valid, which is different from issue 6 (the link in the description) where it explicitly specifies that EINVAL should be returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1606: sched/pthread: Implement pthread_attr_[get|set]detachstate
Posted by GitBox <gi...@apache.org>.
ghn-certi commented on a change in pull request #1606:
URL: https://github.com/apache/incubator-nuttx/pull/1606#discussion_r473253866
##########
File path: include/pthread.h
##########
@@ -241,7 +246,7 @@ struct pthread_attr_s
uint8_t priority; /* Priority of the pthread */
uint8_t policy; /* Pthread scheduler policy */
uint8_t inheritsched; /* Inherit parent priority/policy? */
-
+ uint8_t detachstate; /* Initilize to the detach state */
Review comment:
```suggestion
uint8_t detachstate; /* Initialize to the detach state */
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org