You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "TheRealHaui (via GitHub)" <gi...@apache.org> on 2025/12/01 15:42:38 UTC

Re: [PR] Added new tests for the main Levenshtein algorithm implementations [commons-text]

TheRealHaui commented on PR #728:
URL: https://github.com/apache/commons-text/pull/728#issuecomment-3597276318

   @garydgregory,
   sure!
   No problem.
   
   However, I propose one class after another.
   
   Additionally the following statement is however unreachable.
   <img width="1144" height="317" alt="image" src="https://github.com/user-attachments/assets/fac147f9-851b-46f4-ab94-aeb14b70dc17" />
   This because the constructor already does the validity verification of the threshold.
   <img width="975" height="309" alt="image" src="https://github.com/user-attachments/assets/8b56b97c-4d94-4860-81ec-d1f94041a92e" />
   
   Can of course remove it if you want?
   
   Aside of that missing line in class LevenshteinDistance now tested with the update to the Pull Request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org