You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/08/30 14:08:41 UTC
[PR] fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep [superset]
hainenber opened a new pull request, #30069:
URL: https://github.com/apache/superset/pull/30069
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #29995
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
AFTER
<img width="606" alt="image" src="https://github.com/user-attachments/assets/ba4b6cad-60f7-4cfd-a705-77b551ab6397">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Follow instructions in `howtos.mdx` in `Creating a simple Hello World viz plugin` section and confirms that `npm run build` is successful
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: 29995
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #30069:
URL: https://github.com/apache/superset/pull/30069#issuecomment-2329428607
I have no idea why E2E tests are failing though. Seems to be a bit flaky these days, judging from recent commits in `master` branch :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30069:
URL: https://github.com/apache/superset/pull/30069#issuecomment-2321520599
Thanks for fixing this @hainenber ! @rusackas do you have time to validate this? If not I can try to carve out some time for it next week..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30069:
URL: https://github.com/apache/superset/pull/30069#issuecomment-2321566951
@villebro sadly it's not likely... I have a couple days PTO, and other things cooking.
Thank you @hainenber for continuing to help us with this. As always, we're appreciating your help around here immensely.
For anyone who's interested, I'm thinking it might be time to step away from the generator. My two cents is that we really just need a sample plugin in the repo, which would be testable in CI/Storybook, but not actually instantiated in Superset. Then whenever we bump packages, change components, mess with controls, we'll know more about what we're breaking, and The "how to build a plugin" tutorial would basically be "copy the directory, and change these files:" This is obviously SIP stuff... but I'm dropping it here anyway... because it's Friday :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org